diff mbox

[FFmpeg-devel,v1] fftoos/ffmpeg_opt: avoid to display the hwaccels name twice

Message ID 20190813133841.14000-1-lance.lmwang@gmail.com
State New
Headers show

Commit Message

Lance Wang Aug. 13, 2019, 1:38 p.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 fftools/ffmpeg_opt.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Moritz Barsnick Aug. 14, 2019, 8:22 a.m. UTC | #1 
On Tue, Aug 13, 2019 at 21:38:41 +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> fftoos/ffmpeg_opt: avoid to display the hwaccels name twice
  ^
Nit: fftools/ffmpeg_opt

Moritz
Lance Wang Aug. 14, 2019, 11:19 a.m. UTC | #2 
On Wed, Aug 14, 2019 at 10:22:26AM +0200, Moritz Barsnick wrote:
> On Tue, Aug 13, 2019 at 21:38:41 +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > fftoos/ffmpeg_opt: avoid to display the hwaccels name twice
>   ^
> Nit: fftools/ffmpeg_opt

Sorry, have updated the patch.

> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Carl Eugen Hoyos Aug. 14, 2019, 11:46 a.m. UTC | #3 
Am Di., 13. Aug. 2019 um 15:39 Uhr schrieb <lance.lmwang@gmail.com>:
>
> From: Limin Wang <lance.lmwang@gmail.com>
>
> videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c

Please mention ticket #7464 in the commit message if this patch
is supposed to fix it.

Carl Eugen
Lance Wang Aug. 15, 2019, 1:21 a.m. UTC | #4 
On Wed, Aug 14, 2019 at 01:46:29PM +0200, Carl Eugen Hoyos wrote:
> Am Di., 13. Aug. 2019 um 15:39 Uhr schrieb <lance.lmwang@gmail.com>:
> >
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > videotoolbox and qsv have been defined by hw_type_names[] in hwcontext.c
> 
> Please mention ticket #7464 in the commit message if this patch
> is supposed to fix it.
The patch should fix ticket #7464 although I got the issue myself in my iMac，
I'll update the commit message to mention it.

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index f5ca18a..8baa898 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -66,12 +66,6 @@ 
 }
 
 const HWAccel hwaccels[] = {
-#if CONFIG_VIDEOTOOLBOX
-    { "videotoolbox", videotoolbox_init, HWACCEL_VIDEOTOOLBOX, AV_PIX_FMT_VIDEOTOOLBOX },
-#endif
-#if CONFIG_LIBMFX
-    { "qsv",   qsv_init,   HWACCEL_QSV,   AV_PIX_FMT_QSV },
-#endif
 #if CONFIG_CUVID
     { "cuvid", cuvid_init, HWACCEL_CUVID, AV_PIX_FMT_CUDA },
 #endif