From patchwork Thu Aug 15 20:16:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: elliottk X-Patchwork-Id: 14528 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4CD06448E11 for ; Thu, 15 Aug 2019 23:22:25 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 36DF868ABFA; Thu, 15 Aug 2019 23:22:25 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f201.google.com (mail-qt1-f201.google.com [209.85.160.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 641FA6804E1 for ; Thu, 15 Aug 2019 23:22:18 +0300 (EEST) Received: by mail-qt1-f201.google.com with SMTP id 41so3767951qtm.4 for ; Thu, 15 Aug 2019 13:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to; bh=fQxlwewBHSVzJP+adOgLc55Mf/7MpyLL+w0zgXltSLY=; b=j1dh3kzqf6OxLOyai5Wb8PED3os2r22RnHNU4nezkuNh/WbRoT8OpDaGr9OVNe+XUO pkwW/dKXNBIv2kxO4cBxeL3uzs3OW4oXLmbXFabG685oTXY/Qm5lbcxX1phqtxuDQwdU torvjwEtYTSX0wdgToWebiWvNv9caruQ0PYRgsUb+6SBpJDY19dT/Ud37mo/ej1S+qst QNugdgd6Lgm6FxS+egOZRJLoQOp32et/bwnKSpVXuyu4c2KodfpnqUhWntZok5Uvf7O9 VmBxFm4cdpYXP93mJvwXFaLPbzD93O+1Eo65JXk0hYhvq1E67+q22ewc0z0JgVIyjlhw SMzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to; bh=fQxlwewBHSVzJP+adOgLc55Mf/7MpyLL+w0zgXltSLY=; b=DOCWHx3mFoS/qPxin+v+nUJmTAsoKG5y1oVH78pvgUCnVXtn1Xkt+bcwOh3T3h0AE5 LX9Hliyd0TME5nR2ZWLKiM76779Pd8HSZS1iHjsUYyZ6Atd7qZIg2HdiKy0Lw5p81bml pbw0GA/uHb/SSIeiQaw25f798MTg/DUWaUNOZGPY1SPFK2KOBxj8zLTft2LWO4LbXgg5 7QY5TDAKvw1sh8nb4ixn9Au4Tb0M9Y2666mOU/npXot6DLi/VlHyQM8eCB31pGk1CdcQ QMg7CqelqHwVQJCOzZH39p05ikrdkFxdoW8DdDynYNVBrV7Y5HeO3Dxvz9ZhYoxqVJU6 bLiw== X-Gm-Message-State: APjAAAUZRAiudPtdn9kKklZMZzV6+rkzRnpajQRrqzAjjgC5Vdq+3LcK y91hn9QxyfFMMCcrvpvv+xncsd4e7eAiCkklfJp7s8kdSf2XZNYvM9sb7sEB0ovR3kHVUo5MdEX r22BO4pegI6VE6bGaZg7NnzqfjVwEI7X3P12SOGujAlMTIqPr6dyqs0TGMQyLE2NaPXs= X-Google-Smtp-Source: APXvYqwPKInj0M1dYF20ll1qr+uwdzng2LOMiOmnwoMRdN9E3F7Vf38YMUD1XVcqZEWvqgH64cOIsH7vhzoJwA== X-Received: by 2002:a0c:eccf:: with SMTP id o15mr2274959qvq.15.1565900182970; Thu, 15 Aug 2019 13:16:22 -0700 (PDT) Date: Thu, 15 Aug 2019 13:16:20 -0700 In-Reply-To: Message-Id: <20190815201620.203849-1-elliottk@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog From: elliottk To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] Change libaom default to crf=28. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Current default is 256kbps, which produces inconsistent results (too high for low-res, too low for hi-res). Use CRF instead, which will adapt. --- libavcodec/libaomenc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 9b4fb3b4eb..621e897672 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -575,10 +575,11 @@ static av_cold int aom_init(AVCodecContext *avctx, if (enccfg.rc_end_usage == AOM_CQ) { enccfg.rc_target_bitrate = 1000000; } else { - avctx->bit_rate = enccfg.rc_target_bitrate * 1000; + enccfg.rc_end_usage = AOM_Q; + ctx->crf = 28; av_log(avctx, AV_LOG_WARNING, - "Neither bitrate nor constrained quality specified, using default bitrate of %dkbit/sec\n", - enccfg.rc_target_bitrate); + "Neither bitrate nor constrained quality specified, using default CRF of %d\n", + ctx->crf); } } @@ -1091,7 +1092,7 @@ static const AVOption options[] = { }; static const AVCodecDefault defaults[] = { - { "b", "256*1000" }, + { "b", "0" }, { "qmin", "-1" }, { "qmax", "-1" }, { "g", "-1" },