From patchwork Wed Aug 21 19:18:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: elliottk X-Patchwork-Id: 14644 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 9DC92449EFC for ; Wed, 21 Aug 2019 22:18:31 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87F2268A9BE; Wed, 21 Aug 2019 22:18:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 071A268A42C for ; Wed, 21 Aug 2019 22:18:24 +0300 (EEST) Received: by mail-pl1-f202.google.com with SMTP id x5so2070968pln.5 for ; Wed, 21 Aug 2019 12:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to; bh=k3RCYVYgaoBEYx0ajdTQBUwsMb4KCHz07FFVoQf0MXA=; b=gbSrshHdZidLHf0IeIlCTDEj5TepaBJnhFUB7OLywnElwdbCIv3eQhG6Ge55f+Dmrl X1tG1KFw/RLVAxYPTerpIo0DLJQm3moW3Z1arOOtWvcMlXWjZ9UjQ+vtPVf/xKTlxPID gFxOcj+1ndohRoVSYw3wLUwI9s5C8pjUg76FybY5Fc7sm3lNWHnbItrGbKnZsRYFlN0V nrW4WucSuXjwbpL6SmBS9ih0GZZIVb4wXHjIqvVFsu40ji9RV7YBUcIGFM8yGVFz/eiH VHJ+wHKknwWNX9+MDCn4D/ElAtby8zqAgbILp6QZ9KouqBwXcLOTewFrmSRx5NK6mzBQ SUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to; bh=k3RCYVYgaoBEYx0ajdTQBUwsMb4KCHz07FFVoQf0MXA=; b=K+nn9fgiVHfyHmlpXXP1M1wzS+AIJp/5gLqkpPfHwHDkksG/hANSUCSeBbk6ircQPW rnrn+Vly5ogI6jvMrdJ99LOh6UynFvKRo0OFTHlwc8O+MjwK0vz3FmjKOdjQmq8ZxatM x6tJJcPTnv1QxAfRaFlaQJQwpFc3/1aapImiSbmGhdqDLnSqdzTencYpVS+UV0KPmrzx Ccz22wh7oV9B5f+0iURyAJfVbvsWDogqgYlLIDbVv6jaGRAXyaFC+y6mslaidLgIfrlk bDOSsdQjqT2ZVZWvk0g0ANE8XOjeVgzJChT0nO9r2QTvUfqShjitJt54GQ7wKEAYHSxK IyQw== X-Gm-Message-State: APjAAAWPXp9IsR+P0g0ODXDSF0FX4JrQYBfqHn2Xn6ft6T3er39MV1x+ /fbP2tiFZMonKaSWE4hQj5TYAozJAkc0HczWN4vP/7yLjweemhkurEeQdN6FaPPntX9LOwqrovO 1WCg31CA+CgWdRrCpYjYU6K3gzoxKCLxj03XzLvjgBrgG8UF3zo/P5zj3XCKbmdL9X0s= X-Google-Smtp-Source: APXvYqy1AskntErj+rz9uQBxum3UTqErh/tNauolDwkm4Yb5O411C0DaQwT29SS1lOh75TjV6sMJ6SOSdicBHA== X-Received: by 2002:a63:ff0c:: with SMTP id k12mr29218364pgi.186.1566415102822; Wed, 21 Aug 2019 12:18:22 -0700 (PDT) Date: Wed, 21 Aug 2019 12:18:20 -0700 Message-Id: <20190821191820.50178-1-elliottk@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog From: Elliott Karpilovsky To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] Change libaom default to crf=32. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: elliottk Current default is 256kbps, which produces inconsistent results (too high for low-res, too low for hi-res). Use CRF instead, which will adapt. --- libavcodec/libaomenc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 9b4fb3b4eb..7f47707a09 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -575,10 +575,11 @@ static av_cold int aom_init(AVCodecContext *avctx, if (enccfg.rc_end_usage == AOM_CQ) { enccfg.rc_target_bitrate = 1000000; } else { - avctx->bit_rate = enccfg.rc_target_bitrate * 1000; + enccfg.rc_end_usage = AOM_Q; + ctx->crf = 32; av_log(avctx, AV_LOG_WARNING, - "Neither bitrate nor constrained quality specified, using default bitrate of %dkbit/sec\n", - enccfg.rc_target_bitrate); + "Neither bitrate nor constrained quality specified, using default CRF of %d\n", + ctx->crf); } } @@ -1091,7 +1092,7 @@ static const AVOption options[] = { }; static const AVCodecDefault defaults[] = { - { "b", "256*1000" }, + { "b", "0" }, { "qmin", "-1" }, { "qmax", "-1" }, { "g", "-1" },