diff mbox

[FFmpeg-devel,v1] avformat/mxfenc: fix warning: unused function 'klv_ber_length' [-Wunused-function]

Message ID 20190829072135.24648-1-lance.lmwang@gmail.com
State Rejected
Headers show

Commit Message

Lance Wang Aug. 29, 2019, 7:21 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/mxfenc.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Marton Balint Aug. 29, 2019, 8:12 a.m. UTC | #1 
On Thu, 29 Aug 2019, lance.lmwang@gmail.com wrote:

> From: Limin Wang <lance.lmwang@gmail.com>

See https://patchwork.ffmpeg.org/patch/14141/

Thanks,
Marton

>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavformat/mxfenc.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 8b3d599a6f..b5d9bb5f46 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -542,14 +542,6 @@ static void mxf_write_refs_count(AVIOContext *pb, int ref_count)
>     avio_wb32(pb, 16);
> }
> 
> -static int klv_ber_length(uint64_t len)
> -{
> -    if (len < 128)
> -        return 1;
> -    else
> -        return (av_log2(len) >> 3) + 2;
> -}
> -
> static int klv_encode_ber_length(AVIOContext *pb, uint64_t len)
> {
>     // Determine the best BER size
> -- 
> 2.21.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Lance Wang Aug. 29, 2019, 8:47 a.m. UTC | #2 
On Thu, Aug 29, 2019 at 10:12:23AM +0200, Marton Balint wrote:
> 
> On Thu, 29 Aug 2019, lance.lmwang@gmail.com wrote:
> 
> >From: Limin Wang <lance.lmwang@gmail.com>
> 
> See https://patchwork.ffmpeg.org/patch/14141/
Haven't notice it, however the patch isn't continue anymore. I submit the update patch
by the Tomas comments.

> 
> Thanks,
> Marton
> 
> >
> >Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> >---
> >libavformat/mxfenc.c | 8 --------
> >1 file changed, 8 deletions(-)
> >
> >diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> >index 8b3d599a6f..b5d9bb5f46 100644
> >--- a/libavformat/mxfenc.c
> >+++ b/libavformat/mxfenc.c
> >@@ -542,14 +542,6 @@ static void mxf_write_refs_count(AVIOContext *pb, int ref_count)
> >    avio_wb32(pb, 16);
> >}
> >
> >-static int klv_ber_length(uint64_t len)
> >-{
> >-    if (len < 128)
> >-        return 1;
> >-    else
> >-        return (av_log2(len) >> 3) + 2;
> >-}
> >-
> >static int klv_encode_ber_length(AVIOContext *pb, uint64_t len)
> >{
> >    // Determine the best BER size
> >-- 
> >2.21.0
> >
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel@ffmpeg.org
> >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >To unsubscribe, visit link above, or email
> >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox

Patch

diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 8b3d599a6f..b5d9bb5f46 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
@@ -542,14 +542,6 @@  static void mxf_write_refs_count(AVIOContext *pb, int ref_count)
     avio_wb32(pb, 16);
 }
 
-static int klv_ber_length(uint64_t len)
-{
-    if (len < 128)
-        return 1;
-    else
-        return (av_log2(len) >> 3) + 2;
-}
-
 static int klv_encode_ber_length(AVIOContext *pb, uint64_t len)
 {
     // Determine the best BER size