From patchwork Mon Sep 2 07:01:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Koshevoy X-Patchwork-Id: 14843 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A0A4D4498FF for ; Mon, 2 Sep 2019 10:27:37 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 78251687F47; Mon, 2 Sep 2019 10:27:37 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C75ED687F42 for ; Mon, 2 Sep 2019 10:27:30 +0300 (EEST) Received: by mail-pg1-f179.google.com with SMTP id l21so7040759pgm.3 for ; Mon, 02 Sep 2019 00:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=A7L//f6vX4JIZaS0+MvMoFHp/UAiIRelD2myIZN1T5E=; b=rMAbB1f++Gyh5+iv0lwBm8d+q2Z9uQocaGDD+0NB5jDUq22uJJNTxD6zgiCywehpfa m9+vIOZpp1uu2rIefWanMeM0amLnT6N3331mA6toYDFkVOb9Z+wf6+uVmLS/AgFZG7r8 43rGmGz5+hYmkNEZxL+0iIYF1Jo4t6+y3FWJRHhio4+LHJRtlDexFMwgBsgDFb7zKUSp K/KLVXGtPK1VSYXAsLjW70JU9VAco0duYDkTzgTHVgYbn/9aNPBqa3wI3DFAL7f4NP/X o651fUH7QlHY25swTJIjKCgahpqJHfZJS+1gaJTB//WRXwiwwOyStlM+zQI0EL5yHIkk 9TNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=A7L//f6vX4JIZaS0+MvMoFHp/UAiIRelD2myIZN1T5E=; b=Bf9jUBi+Gj4GQCD3hRroMrWRSZ6QJmM6JfGPvxCBO/QvIQW6esSYEZv2QCZOnoYuIk 8VeBDlMFzlbbDuV2PCfYwHfo66xq28yRVc15GSqFBFYIWoo2NtkutW82dpScCVaYXJMA Ax/XxiBl9M3Tb2Dsyi4aSb7zjXIv9v6SWA22pmK1RK+HY7SYfpoDOlg8NpJ6skUciP04 l+6A7KFZ2r139ZjEEBkO4OQyTfCMGWNYGiv/VQcUwNQMIpvdnkAH+7/PqhdZJ4i6d0VT qok1Oo51d5JG2qTrAWg7k6Ax5cSkXwmyoyjErluqthrgKgW2g0tcc0504Mrvhm+Cfivp lFwQ== X-Gm-Message-State: APjAAAU/W/jtGAQQTP9ZMxhQWp1SHn/dZaMyYTRA/Dh3EPtkJ1gE6nWo OFEhm4lTzjNXyBzTt0plyWH5Xn3f X-Google-Smtp-Source: APXvYqzO/efGI9YbxHmjBIe83TsGM0ugjuqN1hI9Fc4bh22135dCztVBO507l3nFMfGuKTBeR74ptQ== X-Received: by 2002:a62:d143:: with SMTP id t3mr28617139pfl.213.1567407662495; Mon, 02 Sep 2019 00:01:02 -0700 (PDT) Received: from homestead.aragog.com ([2605:a601:a9ae:9100:b62e:99ff:fe37:7032]) by smtp.gmail.com with ESMTPSA id 64sm8231541pfx.31.2019.09.02.00.01.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Sep 2019 00:01:01 -0700 (PDT) From: Pavel Koshevoy To: ffmpeg-devel@ffmpeg.org Date: Mon, 2 Sep 2019 01:01:00 -0600 Message-Id: <20190902070100.12997-1-pkoshevoy@gmail.com> X-Mailer: git-send-email 2.16.4 Subject: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pavel Koshevoy MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init failed and v4l2_m2m_destroy_context closed file descriptor 0 even though it didn't belong to V4L2m2mContext. --- libavcodec/v4l2_m2m.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 427e165f58..ac583c811f 100644 --- a/libavcodec/v4l2_m2m.c +++ b/libavcodec/v4l2_m2m.c @@ -401,6 +401,7 @@ int ff_v4l2_m2m_create_context(AVCodecContext *avctx, V4L2m2mContext **s) priv->context->capture.num_buffers = priv->num_capture_buffers; priv->context->output.num_buffers = priv->num_output_buffers; priv->context->self_ref = priv->context_ref; + priv->context->fd = -1; return 0; }