diff mbox

[FFmpeg-devel] configure: check for a sufficiently recent enough AMF version

Message ID 20190908225120.1875-1-h.leppkes@gmail.com
State Accepted
Commit 4e759b56754a2d9843502c4a177bb66eb95d5ed8
Headers show

Commit Message

Hendrik Leppkes Sept. 8, 2019, 10:51 p.m. UTC 
Due to the recent addition of Vulkan support to AMF, we require more
recent headers that include the new structures, which have been
available since AMF 1.4.9 released in September 2018.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Almer Sept. 9, 2019, 2:24 a.m. UTC | #1 
On 9/8/2019 7:51 PM, Hendrik Leppkes wrote:
> Due to the recent addition of Vulkan support to AMF, we require more
> recent headers that include the new structures, which have been
> available since AMF 1.4.9 released in September 2018.
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 4141c1e8f4..8413826f9e 100755
> --- a/configure
> +++ b/configure
> @@ -6617,7 +6617,7 @@ EOF
>  
>  enabled amf &&
>      check_cpp_condition amf "AMF/core/Version.h" \
> -        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400040001"
> +        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400090000"
>  
>  # Funny iconv installations are not unusual, so check it after all flags have been set
>  if enabled libc_iconv; then

LGTM.
Hendrik Leppkes Sept. 9, 2019, 7:57 a.m. UTC | #2 
On Mon, Sep 9, 2019 at 4:30 AM James Almer <jamrial@gmail.com> wrote:
>
> On 9/8/2019 7:51 PM, Hendrik Leppkes wrote:
> > Due to the recent addition of Vulkan support to AMF, we require more
> > recent headers that include the new structures, which have been
> > available since AMF 1.4.9 released in September 2018.
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 4141c1e8f4..8413826f9e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6617,7 +6617,7 @@ EOF
> >
> >  enabled amf &&
> >      check_cpp_condition amf "AMF/core/Version.h" \
> > -        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400040001"
> > +        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400090000"
> >
> >  # Funny iconv installations are not unusual, so check it after all flags have been set
> >  if enabled libc_iconv; then
>
> LGTM.

Applied with a reference to the trac issue
diff mbox

Patch

diff --git a/configure b/configure
index 4141c1e8f4..8413826f9e 100755
--- a/configure
+++ b/configure
@@ -6617,7 +6617,7 @@  EOF
 
 enabled amf &&
     check_cpp_condition amf "AMF/core/Version.h" \
-        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400040001"
+        "(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400090000"
 
 # Funny iconv installations are not unusual, so check it after all flags have been set
 if enabled libc_iconv; then