From patchwork Mon Sep 16 15:55:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 15105 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 6BA4F448C5D for ; Mon, 16 Sep 2019 19:03:39 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D39B6881BD; Mon, 16 Sep 2019 19:03:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F87B6881A0 for ; Mon, 16 Sep 2019 19:03:31 +0300 (EEST) Received: by mail-wm1-f45.google.com with SMTP id 7so41895wme.1 for ; Mon, 16 Sep 2019 09:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d06rtpUcr/N9KKBShfY7w6THLUDxavd4TNbI6Zb55Xk=; b=iOtUeE8jxHBcNsm7ctqS4mJz01yb6xxYP4Uo2NHssq2RATMjeHoqUzC+GVe5VCqErz UuZYIpSXODEowrMcqMddj/b95jQ8Zp+pW1uQBkGuTp5qkkaq7Kq4n02bg6/Ovjluc1Ie rset5n1P2vTeks49gD/DzfVagYjHIrf2pUL6M2q1aVOUVv4bbRA8Zf2T5671T7dTzkpK /Orhm94/E8EIIMINKccgkD/iEmgvGeTSOb4GjU/NTKSrmfCzjjnlL1D8/5d1KazPFot5 5o4t9n8caI2cTaqofX69Ht+vEAN5VZ4RGQHazfE+cXRDBpt6IcsG6hwGfkooZHyNTxG9 jGGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d06rtpUcr/N9KKBShfY7w6THLUDxavd4TNbI6Zb55Xk=; b=F2BTU4dZz8c9FFJvmv6YCHDeU+hmYRCy+C0q7TyGLuoZvWXZvASAENN2S1dKklq8Qd 8MfENr9JB+EiNyFWJwZVAr2mp1zQ/hv5oCpkviXRRP5XEyprS+x9fs6zofPvD4x+lkWI oWoI9iRx+2IyMK4uEFZ8DpkrgWAo9Bv4YQOjZrrIf6dQRupimb1jYgWTi9xqLCBmxBLy dWAuNKifKMPwz3/nMwFXrJ1wWaVZBph43qry686wHFNOaFqyslnUs0vLHFPx9WrK46i7 1lpX7fpEAgC8dXQ2oHq9qpX8Lv0NSIOBQ3lM9G2s0auxQPgSfpNqP9qgdPZMkL4PVc2d Gsvw== X-Gm-Message-State: APjAAAVu5FtuQUAEZKSVHeLiiOPJx7HXRUPJEY+XpfD8Mcp6zHq4IyMl 4MfeT2cp5ZzxINRZxgSPcBXut7ZB3AI= X-Google-Smtp-Source: APXvYqxrtBoIbKAEKSKYHVJB/FOipfi/sPT7t+JhHqujgvwwKHZCkxBseprdKwec6zzbqjppOBnw+g== X-Received: by 2002:a1c:4886:: with SMTP id v128mr237849wma.176.1568649810844; Mon, 16 Sep 2019 09:03:30 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc0f857.dynamic.kabel-deutschland.de. [188.192.248.87]) by smtp.gmail.com with ESMTPSA id d28sm48111628wrb.95.2019.09.16.09.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 09:03:30 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Sep 2019 17:55:02 +0200 Message-Id: <20190916155502.17579-5-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190916155502.17579-1-andreas.rheinhardt@gmail.com> References: <20190916155502.17579-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 5/5] avformat/utils: Fix always true check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Found via PVS-Studio (ticket #8156). Signed-off-by: Andreas Rheinhardt --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index b83a740500..1cd7aa211c 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4837,7 +4837,7 @@ int ff_mkdir_p(const char *path) } } - if ((*(pos - 1) != '/') || (*(pos - 1) != '\\')) { + if ((*(pos - 1) != '/') && (*(pos - 1) != '\\')) { ret = mkdir(temp, 0755); }