From patchwork Wed Sep 18 03:26:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 15130 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 20EF3449FBC for ; Wed, 18 Sep 2019 06:32:42 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 044A56898A1; Wed, 18 Sep 2019 06:32:42 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 409196897FA for ; Wed, 18 Sep 2019 06:32:34 +0300 (EEST) Received: by mail-wm1-f65.google.com with SMTP id i16so712636wmd.3 for ; Tue, 17 Sep 2019 20:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/dFNM09AKcq9JGc9nDmY6Aw8Y+zsgDBfOp4mvJzWol4=; b=Uj14OFUXnkFDxhtMJVWBCYX4t2LSYnX047qarIFX2gIw6Kp1JKHE/GJHmAdrjADILM VYxsSINQSY0otsAb8Ssr0uge7SDfdAtkJ9KjcXkETgKSkbm683S4cG397Nhhia5vZ60B X+58nQIiZMak/sIEY7MFvoXwpfYV+j7oL7C2WuLE80305/4VCmNWrZvNg1SOi2N+A7t2 tio63wm4z0xxIvdpv3MnrpGqxXg2YS0U6sFFuhUEEj2BtZLU/3UA+Cgok069NIHeii58 RxbfvxLXc7rjefHWen/niI/wRVZ4dfw59KDCONV3XzzWItm35Vi2cQOP0BZUL5cvc1hJ HUPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/dFNM09AKcq9JGc9nDmY6Aw8Y+zsgDBfOp4mvJzWol4=; b=nK4B1Va4IzBGrC2qxP/PZgublQuqS9lolysZQ/61AZhJMi+mRIoe1lUOaToYdM/1Tb 5FFPagtPUxEC6gc9IGpFYThKIKMNzgBYGdtU5OuWY6kYRLYWDwXGZiLKlJq1Vvilprko FQQxhEtKfdlot9S6eRH9QDjRav6M8GnL9WLYBCSkHHTzvoZG6PLejH9k2sj9bYrB+AiP nWNu19gMRRQ9pvKEXjTi1TsiGD3FR3/aZTAfOf5w/+3OYnpeSZL9Mn+RzfqfYu9Ubi5P 4ovRNepVRRt+4A1eTW9YisM2OI2ZpMDla8HeQR1JIt33mv/OkWKZu8v0uWvaRfkjLjaO 1UKQ== X-Gm-Message-State: APjAAAUEmJz7qEkKAvjtIXKhDsimZg6La43CmJF98ShI+qJC3qnufjhf iPC9di9WWbQNi9Oo1Rg42VJZd8JLWx0= X-Google-Smtp-Source: APXvYqzBkxV6xYoY+A3ocfL/4QKdabm0py2FNe/WLhXe3jvdFoz8m1gpwuKlJKifExbLiD42jhuznA== X-Received: by 2002:a7b:c7c9:: with SMTP id z9mr738782wmk.61.1568777553569; Tue, 17 Sep 2019 20:32:33 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc0f857.dynamic.kabel-deutschland.de. [188.192.248.87]) by smtp.gmail.com with ESMTPSA id 189sm806891wmz.19.2019.09.17.20.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 20:32:33 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 18 Sep 2019 05:26:03 +0200 Message-Id: <20190918032607.11774-6-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190918032607.11774-1-andreas.rheinhardt@gmail.com> References: <20190918032607.11774-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 06/10] avformat/asfdec_o: Don't reset twice X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" A variable has been assigned a value twice consecutively; essentially the same happens when one performs av_init_packet on an AVPacket after a call to av_packet_unref. Found via PVS-Studio (see ticket #8156). Signed-off-by: Andreas Rheinhardt --- libavformat/asfdec_o.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index 26f9609f27..e90820373e 100644 --- a/libavformat/asfdec_o.c +++ b/libavformat/asfdec_o.c @@ -1142,9 +1142,7 @@ static void reset_packet(ASFPacket *asf_pkt) asf_pkt->duration = 0; asf_pkt->flags = 0; asf_pkt->dts = 0; - asf_pkt->duration = 0; av_packet_unref(&asf_pkt->avpkt); - av_init_packet(&asf_pkt->avpkt); } static int asf_read_replicated_data(AVFormatContext *s, ASFPacket *asf_pkt)