| Message ID | 20190920070905.239662-1-jzern@google.com |
|---|---|
| State | Accepted |
| Commit | ba24b24aab3b9c4fb9444b00c77834f21b8fe969 |
| Headers | show |
LGTM On 9/20/19, James Zern <jzern-at-google.com@ffmpeg.org> wrote: > this conflicts with the current contributing guidance: > http://ffmpeg.org/developer.html#Contributing > FFmpeg is programmed in the ISO C90 language with a few additional > features from ISO C99, namely: > ... > for loops with variable definition (‘for (int i = 0; i < 8; i++)’); > > Signed-off-by: James Zern <jzern@google.com> > --- > tools/patcheck | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/patcheck b/tools/patcheck > index 101a542ff3..fe52938f29 100755 > --- a/tools/patcheck > +++ b/tools/patcheck > @@ -50,7 +50,6 @@ hiegrep ';;' 'double ;' $* > hiegrep2 '\b_[a-zA-Z0-9_]{1,}' '__(asm|attribute)([^a-zA-Z0-9]|$)' > 'reserved identifer' $* > hiegrep '//[-/<\* ]*$' 'empty comment' $* > hiegrep '/\*[-<\* ]*\*/' 'empty comment' $* > -hiegrep 'for *\( *'"$ERE_PRITYP"' ' 'not gcc 2.95 compatible' $* > hiegrep '(static|inline|const) *\1[^_a-zA-Z]' 'duplicate word' $* > hiegrep 'INIT_VLC_USE_STATIC' 'forbidden ancient vlc type' $* > hiegrep '=[-+\*\&] ' 'looks like compound assignment' $* > -- > 2.23.0.351.gc4317032e6-goog > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Fri, Sep 20, 2019 at 12:38 AM Paul B Mahol <onemda@gmail.com> wrote: > > LGTM > > On 9/20/19, James Zern <jzern-at-google.com@ffmpeg.org> wrote: > > this conflicts with the current contributing guidance: > > http://ffmpeg.org/developer.html#Contributing > > FFmpeg is programmed in the ISO C90 language with a few additional > > features from ISO C99, namely: > > ... > > for loops with variable definition (‘for (int i = 0; i < 8; i++)’); > > > > Signed-off-by: James Zern <jzern@google.com> > > --- > > tools/patcheck | 1 - > > 1 file changed, 1 deletion(-) > > applied.
diff --git a/tools/patcheck b/tools/patcheck index 101a542ff3..fe52938f29 100755 --- a/tools/patcheck +++ b/tools/patcheck @@ -50,7 +50,6 @@ hiegrep ';;' 'double ;' $* hiegrep2 '\b_[a-zA-Z0-9_]{1,}' '__(asm|attribute)([^a-zA-Z0-9]|$)' 'reserved identifer' $* hiegrep '//[-/<\* ]*$' 'empty comment' $* hiegrep '/\*[-<\* ]*\*/' 'empty comment' $* -hiegrep 'for *\( *'"$ERE_PRITYP"' ' 'not gcc 2.95 compatible' $* hiegrep '(static|inline|const) *\1[^_a-zA-Z]' 'duplicate word' $* hiegrep 'INIT_VLC_USE_STATIC' 'forbidden ancient vlc type' $* hiegrep '=[-+\*\&] ' 'looks like compound assignment' $*
this conflicts with the current contributing guidance: http://ffmpeg.org/developer.html#Contributing FFmpeg is programmed in the ISO C90 language with a few additional features from ISO C99, namely: ... for loops with variable definition (‘for (int i = 0; i < 8; i++)’); Signed-off-by: James Zern <jzern@google.com> --- tools/patcheck | 1 - 1 file changed, 1 deletion(-)