From patchwork Sun Oct 6 05:49:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andriy Gelman X-Patchwork-Id: 15530 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id EBE2D446EF0 for ; Sun, 6 Oct 2019 08:50:22 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6897687F89; Sun, 6 Oct 2019 08:50:22 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A25A8680249 for ; Sun, 6 Oct 2019 08:50:16 +0300 (EEST) Received: by mail-qt1-f196.google.com with SMTP id c4so1953725qtn.10 for ; Sat, 05 Oct 2019 22:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4E+VGAhW3UTjJqPMST5GTzvjW4xOxWz+00c4ZYaVKS8=; b=pWXrJwMF3TumFyZbgOPUs0/oqh7UGcnqxHsVPuOOgYNP0A0lAFS+z9QJqFcnpf/YXa hYHZKeXIxpHTUZN/Jc2NpwU5dQZASCDhTxAExWPk/+Xd3gZUM8bI6qDdMxbbVNTkxEWR 3ClRPAdncS+ijAxfBpa/0pWVzmHhPcNAlY6kcEP3tuVJe47UQg88SEBm4E+VOzy8B3RX bKMmPqoM1IV2eVNywKbA1Ktb9UXe+NQR3aDJsjw2sCY6f6+r3RhAujlh1WB5STBp27Y9 vOKWTpV7OPiL+9763yBvrulEDFaq9uL3di0h9qyaxFKw/EKTkKt762wg5/EZ7JUYJ9zr vjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4E+VGAhW3UTjJqPMST5GTzvjW4xOxWz+00c4ZYaVKS8=; b=c1+gmyQPXWRz504ybreljRN8wtS6JmJX7CIE6hCAUEuOFBVfXzMOyiVjU0wVymjXZZ S5Ez7AmyzSNqStwsmF6ta9u5ItzzHbRVtQiBnl5gFmltz83KsmGrDn2ulksMLUy1BTMZ QqDyyDnouHCgmmkaJrxCpEWn94k7PBxggK9Ccj/Wvd7EwjT0OIQdXNN4YAjcurUQQw5F 6UlBDNMnP3QLqvlO7YbaH82tfh0wqG7+yLxfLka+Beobd3KryM3z0CldunJrtWRptqA4 HY9Lmd5gz8NJrkQdEv1Fg8H8xZ4a4GLTLMX5YaB6bPgg8zqSpHHWQEZw3PrGy65uCsgm Jv6w== X-Gm-Message-State: APjAAAVROx5fsW5Gu0OiK8s7X8mUGh2P6EF7gBLrgzlVFsZrxbUKaY3M ZDmAuB+HocxUDF/GhRRR2lMldeLW X-Google-Smtp-Source: APXvYqy5iR0+tqFR0oEdXMcnKwtppD8Nx59CgRC37Xrzgn22iYKbEaBR5WVNZ23MneoV3x4SfJq7Tg== X-Received: by 2002:ac8:6d21:: with SMTP id r1mr24054445qtu.256.1570341015129; Sat, 05 Oct 2019 22:50:15 -0700 (PDT) Received: from localhost.localdomain (c-71-232-27-28.hsd1.ma.comcast.net. [71.232.27.28]) by smtp.gmail.com with ESMTPSA id 54sm8267073qts.75.2019.10.05.22.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2019 22:50:14 -0700 (PDT) From: Andriy Gelman X-Google-Original-From: Andriy Gelman To: ffmpeg-devel@ffmpeg.org Date: Sun, 6 Oct 2019 01:49:48 -0400 Message-Id: <20191006054950.30374-3-andriy.gelman@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006054950.30374-1-andriy.gelman@gmail.com> References: <20191006054950.30374-1-andriy.gelman@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 3/5] avformat/chromaprint: Improve logging message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andriy Gelman Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Andriy Gelman Setting silence_threshold requires that -algorithm 3 option is also set. Add this to the logging message. --- libavformat/chromaprint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c index 547e801cdd..a4c0b97d99 100644 --- a/libavformat/chromaprint.c +++ b/libavformat/chromaprint.c @@ -73,7 +73,7 @@ static int write_header(AVFormatContext *s) if (cpr->silence_threshold != -1) { #if CPR_VERSION_INT >= AV_VERSION_INT(0, 7, 0) if (!chromaprint_set_option(cpr->ctx, "silence_threshold", cpr->silence_threshold)) { - av_log(s, AV_LOG_ERROR, "Failed to set silence threshold.\n"); + av_log(s, AV_LOG_ERROR, "Failed to set silence threshold. Setting silence_threshold requires -algorithm 3 option.\n"); goto fail; } #else