From patchwork Mon Oct 7 05:06:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 15538 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 24125444F68 for ; Mon, 7 Oct 2019 08:07:58 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED3A868049A; Mon, 7 Oct 2019 08:07:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from qq.com (smtpbg562.qq.com [183.3.255.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8384268046A for ; Mon, 7 Oct 2019 08:07:51 +0300 (EEST) X-QQ-mid: bizesmtp20t1570424781t0zwly8w Received: from localhost (unknown [111.192.118.67]) by esmtp6.qq.com (ESMTP) with id ; Mon, 07 Oct 2019 13:06:20 +0800 (CST) X-QQ-SSF: 01100000002000K0ZRF0B00A0000000 X-QQ-FEAT: Tf10PgKjoHzOPkkdbjSXx0MQt9yKUdDG/ih+Bz+175/3n2Oso3t+lbZiWbkhK iizR+gVP7zBZYyxecaxNBzGYthy48wOpovDTEb3Th/SaKFl12DYTVgBNv7h/t6USFOVoWAZ 9uC/yfa+WmEIWaKSjFNoybDTwnRFAs2keNOrOm/3fb+fM+SbRPXxeC0umWgvhoz0IxwikyT 03j6Jg57Fg4lW4K/3EDYFhdtRUgINoFl8bYo/lDOBcVmejVsFam+XCDrLV+1N5AnZ73WFal qX3OSFqLbFVb2apO37stO2pjX4UNc8jTc3vYtsYu8KCP0RoS1bBlO+KQM= X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Mon, 7 Oct 2019 13:06:17 +0800 Message-Id: <20191007050617.93185-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.17.2 (Apple Git-113) X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgforeign:qybgforeign2 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH v1] avfilter/vf_delogo: make the interp value compute method simple X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" because the interp >= 0UL comparison of an unsigned value is always true fix CID: 1454642 Signed-off-by: Steven Liu --- libavfilter/vf_delogo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 376c5e850f..27a769982f 100644 --- a/libavfilter/vf_delogo.c +++ b/libavfilter/vf_delogo.c @@ -168,7 +168,7 @@ static void apply_delogo(uint8_t *dst, int dst_linesize, botleft[x-logo_x1-1] + botleft[x-logo_x1+1]) * weightb; weight = (weightl + weightr + weightt + weightb) * 3U; - interp = ROUNDED_DIV(interp, weight); + interp += weight >> 1; if (y >= logo_y+band && y < logo_y+logo_h-band && x >= logo_x+band && x < logo_x+logo_w-band) {