From patchwork Wed Oct 9 07:35:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 15591 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A5890447223 for ; Wed, 9 Oct 2019 10:36:06 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8DDBE6881CE; Wed, 9 Oct 2019 10:36:06 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07F726881BF for ; Wed, 9 Oct 2019 10:36:03 +0300 (EEST) X-QQ-mid: bizesmtp21t1570606541tiv3efme Received: from localhost (unknown [47.90.47.25]) by esmtp6.qq.com (ESMTP) with id ; Wed, 09 Oct 2019 15:35:41 +0800 (CST) X-QQ-SSF: 01100000002000K0ZRF1000A0000000 X-QQ-FEAT: fVZeSYFzHq0bJYdYRg3nznZxNVt7Uu+6+jABYBUGKUKasZWg9xeXWlLfemD2U 9gumSazKKFROmlV9fNEkpyS88X3p9xL8nX8nROPrZy8Bn5b7AVoETRDX+P0GTn/Oai8pySl 2SK9IB51pxoec5U7mO0QfLRE7xxEpqNeRURrcgQqXhGiZJBQb7nYBqtnZ8IVGRnN5J08Fzd DMeBntmrex2PyyPti9r0bzkNCko6Knn8j3hWplZMsuhsh3HJyeRQrcfbcrvZBY5td3GXGdw yhn+y9S1+O7STBC0nsJkMfSlXvLVjH1hHK/4zLZWPWpflfYKzGyE37Twkiw3V54qnt4iSid xu/fMca X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Wed, 9 Oct 2019 15:35:24 +0800 Message-Id: <20191009073530.4505-5-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.10.1.382.ga23ca1b.dirty In-Reply-To: <20191009073530.4505-1-lq@chinaffmpeg.org> References: <20191009073530.4505-1-lq@chinaffmpeg.org> X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH v1 05/11] avformat/libmodplug: fix memleak when load modplug failed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Steven Liu --- libavformat/libmodplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/libmodplug.c b/libavformat/libmodplug.c index 314bdae3e7..d4f78d99b1 100644 --- a/libavformat/libmodplug.c +++ b/libavformat/libmodplug.c @@ -216,9 +216,10 @@ static int modplug_read_header(AVFormatContext *s) ModPlug_SetSettings(&settings); modplug->f = ModPlug_Load(modplug->buf, sz); - if (!modplug->f) + if (!modplug->f) { + av_freep(&modplug->buf); return AVERROR_INVALIDDATA; - + } st = avformat_new_stream(s, NULL); if (!st) return AVERROR(ENOMEM);