From patchwork Thu Oct 10 03:40:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Steven X-Patchwork-Id: 15661 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id AD02544A020 for ; Thu, 10 Oct 2019 06:40:46 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 92D816881E9; Thu, 10 Oct 2019 06:40:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9B1F46881D3 for ; Thu, 10 Oct 2019 06:40:40 +0300 (EEST) X-QQ-mid: bizesmtp18t1570678836tsji73o8 Received: from localhost (unknown [47.90.47.25]) by esmtp6.qq.com (ESMTP) with id ; Thu, 10 Oct 2019 11:40:36 +0800 (CST) X-QQ-SSF: 01100000002000K0ZRF1000A0000000 X-QQ-FEAT: fkIUhKLesWxsOhdK6fNybPS26xbKRaoYIzP+nNZRvgNepprhqB14FHJY+oJCS 7o3Ds84JLAn1k53JwZwaziTHYmzxDV1A1AaA4j/vR5DZW6AwYNBSwiOkEs5qiH7EuOOuuK+ GaNHDNRrMFMzqDnwINYMZkNxhbWbPXmHe5fzyX5RN0/NN5mpfMI/zW5D1fUbEwIyFz2Zmch w5MppO5xXDbLt3cxu5MLC1Cdy8hF7KGDQyb3s8des5keKuWAbZQySjXuoXpD87EZUA5Yl60 X9BpbCS0xJW3K2SPGZQ03DbVJWXMTyCBdwqVAkPV+T8JGtlzWaX85Om2qsl+rSYoUeb7hUc s0yINKQ X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Thu, 10 Oct 2019 11:40:11 +0800 Message-Id: <20191010034011.1205-8-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.10.1.382.ga23ca1b.dirty In-Reply-To: <20191010034011.1205-1-lq@chinaffmpeg.org> References: <20191010034011.1205-1-lq@chinaffmpeg.org> X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH v1 8/8] avformat/sapdec: check av_strdup() return value and fix memleak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Steven Liu --- libavformat/sapdec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavformat/sapdec.c b/libavformat/sapdec.c index eddeddeaea..4cce700b40 100644 --- a/libavformat/sapdec.c +++ b/libavformat/sapdec.c @@ -142,6 +142,10 @@ static int sap_read_header(AVFormatContext *s) } sap->sdp = av_strdup(&recvbuf[pos]); + if (!sap->sdp) { + ret = AVERROR(ENOMEM); + goto fail; + } break; } @@ -183,6 +187,7 @@ static int sap_read_header(AVFormatContext *s) return 0; fail: + av_freep(&sap->sdp); sap_read_close(s); return ret; }