Message ID | 20191010060354.2357-1-lance.lmwang@gmail.com |
---|---|
State | Accepted |
Commit | 81271b3cce3dea9543feb13d41f6ab285d19b770 |
Headers | show |
> 在 2019年10月10日,14:03,lance.lmwang@gmail.com 写道: > > From: Limin Wang <lance.lmwang@gmail.com> > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com> > --- > libavfilter/f_metadata.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c > index 2ed1393cba..3bf4bb17f5 100644 > --- a/libavfilter/f_metadata.c > +++ b/libavfilter/f_metadata.c > @@ -320,13 +320,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > av_dict_set(metadata, s->key, s->value, 0); > } > return ff_filter_frame(outlink, frame); > - break; > case METADATA_MODIFY: > if (e && e->value) { > av_dict_set(metadata, s->key, s->value, 0); > } > return ff_filter_frame(outlink, frame); > - break; > case METADATA_PRINT: > if (!s->key && e) { > s->print(ctx, "frame:%-4"PRId64" pts:%-7s pts_time:%s\n", > @@ -341,7 +339,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > s->print(ctx, "%s=%s\n", s->key, e->value); > } > return ff_filter_frame(outlink, frame); > - break; > case METADATA_DELETE: > if (!s->key) { > av_dict_free(metadata); > @@ -349,7 +346,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > av_dict_set(metadata, s->key, NULL, 0); > } > return ff_filter_frame(outlink, frame); > - break; > default: > av_assert0(0); > }; > -- > 2.21.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". LGTM Thanks Steven
On Thu, Oct 10, 2019 at 02:07:13PM +0800, Steven Liu wrote: > > > > 在 2019年10月10日,14:03,lance.lmwang@gmail.com 写道: > > > > From: Limin Wang <lance.lmwang@gmail.com> > > > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com> > > --- > > libavfilter/f_metadata.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c > > index 2ed1393cba..3bf4bb17f5 100644 > > --- a/libavfilter/f_metadata.c > > +++ b/libavfilter/f_metadata.c > > @@ -320,13 +320,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > > av_dict_set(metadata, s->key, s->value, 0); > > } > > return ff_filter_frame(outlink, frame); > > - break; > > case METADATA_MODIFY: > > if (e && e->value) { > > av_dict_set(metadata, s->key, s->value, 0); > > } > > return ff_filter_frame(outlink, frame); > > - break; > > case METADATA_PRINT: > > if (!s->key && e) { > > s->print(ctx, "frame:%-4"PRId64" pts:%-7s pts_time:%s\n", > > @@ -341,7 +339,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > > s->print(ctx, "%s=%s\n", s->key, e->value); > > } > > return ff_filter_frame(outlink, frame); > > - break; > > case METADATA_DELETE: > > if (!s->key) { > > av_dict_free(metadata); > > @@ -349,7 +346,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > > av_dict_set(metadata, s->key, NULL, 0); > > } > > return ff_filter_frame(outlink, frame); > > - break; > > default: > > av_assert0(0); > > }; > > -- > > 2.21.0 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > LGTM ping, please help to push if no more comments. > > Thanks > Steven > > > > >
> 在 2019年11月8日,19:26,Limin Wang <lance.lmwang@gmail.com> 写道: > > On Thu, Oct 10, 2019 at 02:07:13PM +0800, Steven Liu wrote: >> >> >>> 在 2019年10月10日,14:03,lance.lmwang@gmail.com 写道: >>> >>> From: Limin Wang <lance.lmwang@gmail.com> >>> >>> Signed-off-by: Limin Wang <lance.lmwang@gmail.com> >>> --- >>> libavfilter/f_metadata.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c >>> index 2ed1393cba..3bf4bb17f5 100644 >>> --- a/libavfilter/f_metadata.c >>> +++ b/libavfilter/f_metadata.c >>> @@ -320,13 +320,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) >>> av_dict_set(metadata, s->key, s->value, 0); >>> } >>> return ff_filter_frame(outlink, frame); >>> - break; >>> case METADATA_MODIFY: >>> if (e && e->value) { >>> av_dict_set(metadata, s->key, s->value, 0); >>> } >>> return ff_filter_frame(outlink, frame); >>> - break; >>> case METADATA_PRINT: >>> if (!s->key && e) { >>> s->print(ctx, "frame:%-4"PRId64" pts:%-7s pts_time:%s\n", >>> @@ -341,7 +339,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) >>> s->print(ctx, "%s=%s\n", s->key, e->value); >>> } >>> return ff_filter_frame(outlink, frame); >>> - break; >>> case METADATA_DELETE: >>> if (!s->key) { >>> av_dict_free(metadata); >>> @@ -349,7 +346,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) >>> av_dict_set(metadata, s->key, NULL, 0); >>> } >>> return ff_filter_frame(outlink, frame); >>> - break; >>> default: >>> av_assert0(0); >>> }; >>> -- >>> 2.21.0 >>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> >> LGTM > > ping, please help to push if no more comments. Pushed > >> >> Thanks >> Steven >> >> >> >> >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". Thanks Steven
diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c index 2ed1393cba..3bf4bb17f5 100644 --- a/libavfilter/f_metadata.c +++ b/libavfilter/f_metadata.c @@ -320,13 +320,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) av_dict_set(metadata, s->key, s->value, 0); } return ff_filter_frame(outlink, frame); - break; case METADATA_MODIFY: if (e && e->value) { av_dict_set(metadata, s->key, s->value, 0); } return ff_filter_frame(outlink, frame); - break; case METADATA_PRINT: if (!s->key && e) { s->print(ctx, "frame:%-4"PRId64" pts:%-7s pts_time:%s\n", @@ -341,7 +339,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) s->print(ctx, "%s=%s\n", s->key, e->value); } return ff_filter_frame(outlink, frame); - break; case METADATA_DELETE: if (!s->key) { av_dict_free(metadata); @@ -349,7 +346,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) av_dict_set(metadata, s->key, NULL, 0); } return ff_filter_frame(outlink, frame); - break; default: av_assert0(0); };