From patchwork Thu Oct 17 09:24:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 15812 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4C4B9448088 for ; Thu, 17 Oct 2019 12:27:05 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2986668A67C; Thu, 17 Oct 2019 12:27:05 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4AA05687FD3 for ; Thu, 17 Oct 2019 12:26:59 +0300 (EEST) Received: by mail-wr1-f65.google.com with SMTP id j11so1507001wrp.1 for ; Thu, 17 Oct 2019 02:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gsOMEvP1HrH3u5Imghgc4JcsiW8NaN3h8MPIrf/HrLc=; b=djWs61qdJ5qbZwSVJE+PC3s535GZyfWZHX8NRii8G9DaNsLzlKnoCH9C+tZp9KXzK4 H2L9XW3zCpPyEsu/SgO54tMqboR2UNSbAp8XId3JF0rR3XSc2qJMruOGcmpczmIE01za gnUdwltCqPdcZ043lz23oj3guN0w9ubhqTj1zD/Ka7XL9o7Z2iadOz6zaKauJwPyeV7N YmVFqQeWTxJNFVEQRvv9+N0p5n6ND337ImOkuri8p14sdOFB2dgVycZPypXm9QYq8rXO m0gKpK6173C+n58f+4OicKr3EsDcmsUownn0Mh/aJjNN5+GnhrDqnAE1TR0iXYGbxjcX J5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gsOMEvP1HrH3u5Imghgc4JcsiW8NaN3h8MPIrf/HrLc=; b=cdnTO6dbZOrtrI+0Ald+a93eHE7SGlG+05eXExqRk3p9XdK0kVvn61L+l7buapwo7F li+fpOIdUCak8wqqiz2K2V5yxPRA4pi6LWae70frfDuUVtatTvDPzlOk6lbJFDAjHzoL I3h58ULu7piBkHSROU4Dfnri/xQk1VTovi7jXA3yZGIAW8zlRGAMKmCC/mKa6ikxZkRW 0DgITnvFXWFTvKt+YJj7XTKhjsy0YznYb2DkprBngfSPjyf9PKnKbw8+80igg8eyx8fD CN+4zujZQGEixZ2rZQWvKk6LQc/xmCl9bO17twCmW2oxIKSqRkJHtkkqLGvTzdrK8Pks b1Qg== X-Gm-Message-State: APjAAAW2PCRsjvAjodIzaZPOGkXvKVITTWafThcFsyXE99wIzhA8EA5h tCb6YGL9c5uIBGSqWqo7uRc9TbZb X-Google-Smtp-Source: APXvYqxOEqjBC6sEHzoz3p3F89wdapLCojBI9CqkiG9RAhfaX8qBZBUDpK3AE9Ozrz4XWyJtyChxAA== X-Received: by 2002:a5d:6447:: with SMTP id d7mr2108074wrw.247.1571304418616; Thu, 17 Oct 2019 02:26:58 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc08937.dynamic.kabel-deutschland.de. [188.192.137.55]) by smtp.gmail.com with ESMTPSA id b5sm1576450wmj.18.2019.10.17.02.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 02:26:58 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 17 Oct 2019 11:24:55 +0200 Message-Id: <20191017092454.24706-1-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/af_arnndn: Remove superfluous qualifier X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" remove_doubling() returned a const float, but returning qualified types is pointless anyway. This is all the more important given that GCC 4.2.1 (and maybe other compilers, too) seems to treat this as an error as several FATE units that don't compile any more show. Signed-off-by: Andreas Rheinhardt --- Example compilation log: http://fate.ffmpeg.org/log.cgi?slot=x86_64-openbsd5.6-gcc4.2&time=20191012220632&log=compile libavfilter/af_arnndn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_arnndn.c b/libavfilter/af_arnndn.c index 7688b31b0c..7a26f89709 100644 --- a/libavfilter/af_arnndn.c +++ b/libavfilter/af_arnndn.c @@ -782,8 +782,8 @@ static float compute_pitch_gain(float xy, float xx, float yy) } static const int second_check[16] = {0, 0, 3, 2, 3, 2, 5, 2, 3, 2, 3, 2, 5, 2, 3, 2}; -static const float remove_doubling(float *x, int maxperiod, int minperiod, - int N, int *T0_, int prev_period, float prev_gain) +static float remove_doubling(float *x, int maxperiod, int minperiod, int N, + int *T0_, int prev_period, float prev_gain) { int k, i, T, T0; float g, g0;