From patchwork Sat Oct 26 02:09:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 15968 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4DA51448538 for ; Sat, 26 Oct 2019 05:09:17 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3974468B4F7; Sat, 26 Oct 2019 05:09:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F27168AF04 for ; Sat, 26 Oct 2019 05:09:11 +0300 (EEST) Received: by mail-pg1-f193.google.com with SMTP id u23so2807045pgo.0 for ; Fri, 25 Oct 2019 19:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=b+e1aJMKNikvHx2y4A0PGM1bJz7fq4axXH+I92g9nVw=; b=FCHJdYGJ6RX6i0sRtGoYc+FfRFfqwqDAqGGAU+jQjIK/zdcc9CtBFBPunaHdWLtyp5 mYi1LHf7y+FbZ8Xmj0fb4g37g+3I15FDN6Akq179yY3WhUePXo30noYl8zNnalD/AwAN 9pOO78DqYFV0ZJnzB2QENeWCXTa2wg0bNVjPemGffp+DRqfHBDNUM7tY5gU9kKaV0V7O UjUo+H51nE6FacptVosZ6weEUZVdo3xr5rvF6W7gtQ5lx2+n/e/cchaeJ8lWF3SgS3mh 39kz1A+O8ZLycs27latoCUKT7QTOMOBDj7p6Wf5oTVHXr6dqpZuiCnKmOG6VLYXiPzss C27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=b+e1aJMKNikvHx2y4A0PGM1bJz7fq4axXH+I92g9nVw=; b=cnLA6H6rn3B1ywJ4viz8k2EdlBLccwNrjaNZjQ1WSCHTtdrwELs/B6MqYVf9QAnay5 gokjTQbyeXxJ0cp4VPRjBXZYGWm4W2ah4DJP5bV+8I4DSKrFyvgRPGy4M2pIRgg1fRAi KNRL1bKyJzRZ4esvOaCM8u61SL4prGN19Ebvb+T/sLLMmroJj5JstoWlMzScX+V6s5Jc T8OlPSIWffCnu1AVOgI8GTC8jFNhhOB8YMUw+jUTi8mVMrbTaB5FufVqNGA2Kj4eB+4A gIBmLaoC3lgUS9OAZEtPD+I/SiuEuYo49xzgeEXHZGV3E1EDBjBGAc7Tt/BodbvLzzW/ hF0w== X-Gm-Message-State: APjAAAUflmHkCI/Hp2OuFWEzu2YwpHU4AD9skyOZi940Wf5zhEQZBhRs qDCRTNBs3I3kxoxXHGgzRVKDd6ktUyE= X-Google-Smtp-Source: APXvYqxN2Yghywcxos65f9IicjBmW48U+EPVKTMJyyXvqnMNadvlegJrMqm/cdGGGDu4z0btxMlJLA== X-Received: by 2002:a17:90a:244a:: with SMTP id h68mr7877737pje.79.1572055749160; Fri, 25 Oct 2019 19:09:09 -0700 (PDT) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id ev14sm3303896pjb.32.2019.10.25.19.09.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2019 19:09:08 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 26 Oct 2019 10:09:04 +0800 Message-Id: <20191026020904.5775-1-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 Subject: [FFmpeg-devel] [PATCH v1] avfilter/asrc_anoisesrc: change type to TYPE_INT64 for color is int64_t X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang Or it'll cause invalid color and s->filter is NULL. Please reproduce it with below command on big endian system: $ ./ffmpeg -f lavfi -i "anoisesrc=d=60:c=1:r=48000" -f s16le -c:a pcm_s16le -f null - Segmentation fault (core dumped) Signed-off-by: Limin Wang --- libavfilter/asrc_anoisesrc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/asrc_anoisesrc.c b/libavfilter/asrc_anoisesrc.c index 78f0af4fde..8a6ef89dd1 100644 --- a/libavfilter/asrc_anoisesrc.c +++ b/libavfilter/asrc_anoisesrc.c @@ -60,9 +60,9 @@ static const AVOption anoisesrc_options[] = { { "a", "set amplitude", OFFSET(amplitude), AV_OPT_TYPE_DOUBLE, {.dbl = 1.}, 0., 1., FLAGS }, { "duration", "set duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, INT64_MAX, FLAGS }, { "d", "set duration", OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0}, 0, INT64_MAX, FLAGS }, - { "color", "set noise color", OFFSET(color), AV_OPT_TYPE_INT, {.i64 = 0}, 0, NM_NB - 1, FLAGS, "color" }, - { "colour", "set noise color", OFFSET(color), AV_OPT_TYPE_INT, {.i64 = 0}, 0, NM_NB - 1, FLAGS, "color" }, - { "c", "set noise color", OFFSET(color), AV_OPT_TYPE_INT, {.i64 = 0}, 0, NM_NB - 1, FLAGS, "color" }, + { "color", "set noise color", OFFSET(color), AV_OPT_TYPE_INT64, {.i64 = 0}, 0, NM_NB - 1, FLAGS, "color" }, + { "colour", "set noise color", OFFSET(color), AV_OPT_TYPE_INT64, {.i64 = 0}, 0, NM_NB - 1, FLAGS, "color" }, + { "c", "set noise color", OFFSET(color), AV_OPT_TYPE_INT64, {.i64 = 0}, 0, NM_NB - 1, FLAGS, "color" }, { "white", 0, 0, AV_OPT_TYPE_CONST, {.i64 = NM_WHITE}, 0, 0, FLAGS, "color" }, { "pink", 0, 0, AV_OPT_TYPE_CONST, {.i64 = NM_PINK}, 0, 0, FLAGS, "color" }, { "brown", 0, 0, AV_OPT_TYPE_CONST, {.i64 = NM_BROWN}, 0, 0, FLAGS, "color" },