From patchwork Wed Nov 13 11:09:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 16242 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 52625449F35 for ; Wed, 13 Nov 2019 13:10:08 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23EDA68A8AA; Wed, 13 Nov 2019 13:10:08 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 989AC68A471 for ; Wed, 13 Nov 2019 13:10:01 +0200 (EET) Received: by mail-pl1-f194.google.com with SMTP id o9so935855plk.6 for ; Wed, 13 Nov 2019 03:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Np7mdUkrWUrjtlLhLpcYISXhC22X2hpSc2j4EQiFejQ=; b=rSjQ7RdPKzTRCTnD2RxdZAcDQqbGF5UJ+6Pw2r1N8bCIgLOJGeJDvca8c+cFVaIh+J 1Yv2PEqkoO+f98I5kIxnlLxa+W1VECDiDpAMy89LZD/DLXPuNh9/YTxB9Ay7/OUmNxY9 ttAe6AIg2x3/P2v2Df6zsJJaWU0N4L70AVZohI1e+QFLyNVCFDBw4egm1qiox7VHjlId t3C047cp5e4cr54u6NzuSOGCLH/qo+Y3LHDDRAxtf3SAk94pNON99N9piCAymtEVL7dY S1Hn++whpXB0xOWTHOAvtLqNK7U72m/9YZY5JE4Xcz5Adqd7KBo22RmxRG4uUwZpuAwg UaYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Np7mdUkrWUrjtlLhLpcYISXhC22X2hpSc2j4EQiFejQ=; b=aVPw+qvjDnvKKWw1q3vT1GCXG5jmzjHtHw6zIRwgKq6D94yom8UgYayuMHl9Ko9T1E Xh6QldIE3BvYrTxtkr9P8/u5mQgYU1EMN6IVkwNM2lotxzfTBcKstdsHp1BRGDgb2BHi 6wR/uDjPot4U+bTuzLLyO4DbXnIji6oi7iGTinooAhhbr/TWdyq6xtVkoK3pTzmxakSG TKXBZ6Y9cNSXsOuHHmI8oNJ5d1x68YuZjhiaItDMbKsF+jczsSE9tkEhQSDv4W+d0EwH wZ0YihA+38JUBcWy/lYBJAP2TKjscdCQoey8ZJfejLETCeQyKPOdihYFOUpjPw5Gz/63 veqA== X-Gm-Message-State: APjAAAWOuW01OBYpeWUlZy356CJDY8WybR2wYF+PbdO2hXXYdKauJgvr ttfFTB3O7qsULB1pF0bx2DEU4mbH X-Google-Smtp-Source: APXvYqzXeI1/1IaCCQDIOEJqqkU4mi+SlXn0JavGxHOjrxjLUdl//z6ghzoEytx5M67BeZVAAJcRDw== X-Received: by 2002:a17:902:47:: with SMTP id 65mr3073326pla.94.1573643399533; Wed, 13 Nov 2019 03:09:59 -0800 (PST) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id k5sm2133348pju.14.2019.11.13.03.09.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Nov 2019 03:09:58 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 13 Nov 2019 19:09:45 +0800 Message-Id: <20191113110947.7767-1-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 Subject: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_colorbalance: Fix for the wrong step value for 16bit format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang Please try to reproduce with below command: ./ffplay -vf format=rgba64,colorbalance=rm=.2 ../fate-suite/mpeg2/t.mpg Without the patch, the step is 8 if you check it by gdb or print out. Signed-off-by: Limin Wang --- libavfilter/vf_colorbalance.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_colorbalance.c b/libavfilter/vf_colorbalance.c index eb870ac2ad..3fd1426696 100644 --- a/libavfilter/vf_colorbalance.c +++ b/libavfilter/vf_colorbalance.c @@ -303,6 +303,7 @@ static int config_output(AVFilterLink *outlink) ColorBalanceContext *s = ctx->priv; const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(outlink->format); const int depth = desc->comp[0].depth; + const int is16bit = depth > 8; const int max = 1 << depth; const int planar = av_pix_fmt_count_planes(outlink->format) > 1; @@ -319,7 +320,7 @@ static int config_output(AVFilterLink *outlink) } ff_fill_rgba_map(s->rgba_map, outlink->format); - s->step = av_get_padded_bits_per_pixel(desc) >> 3; + s->step = av_get_padded_bits_per_pixel(desc) >> (3 + is16bit); return 0; }