From patchwork Wed Nov 13 15:29:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Derek Buitenhuis X-Patchwork-Id: 16248 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 1AF1A448F2F for ; Wed, 13 Nov 2019 17:37:37 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CBB4D68A3A6; Wed, 13 Nov 2019 17:37:36 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 47DAC689E26 for ; Wed, 13 Nov 2019 17:37:30 +0200 (EET) Received: by mail-wm1-f49.google.com with SMTP id t26so2517629wmi.4 for ; Wed, 13 Nov 2019 07:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Ic+h7IcSBViDo5gRCzdjlHCr/obdxlvmZZzlxFMT/7U=; b=Kgwc2cvAuKd5p7dOPzR0d0Ay3WO/Ene6NwZJK5m5JJ3gsF0oI7rOcnrBah0QSB4cM5 jBKq3J77zelr3LW2D+gk9gpx0mCUCfkKYVJg7rIq6VO8Or9cDKBF5HrjAhGy7tDaP2hl pGt5M+bTwrgkPIPYXIEyL7nyWR2OIXCKACMmYChaCGOaA3sHZQsfhCMbGHbgouhjT6jn Dbp3/v2LxaZIEZN6KmKePNTYwV+RkQESf4nFOepUJpZHIL8JjI4FtxnoJu3lLBrAUtdo HwTjGb/ES0wxDKyww5kS+xrMQsdMY1+zd9k+3+G7oiuO3AweMtTdHpltM4htzGCt/M1/ WqPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ic+h7IcSBViDo5gRCzdjlHCr/obdxlvmZZzlxFMT/7U=; b=S9S/rUPRE8Jlh5bvRKd1bumQ026IvCcT9kL9gCcBj/Tw93esr1YY2yrJOs0Uvawxfh tasqSzsvnnOSgq1RXJuwQVYvAnlCfwuhYyI7jUn29PClCEFwXB7yQEfRp5lcc28sEKg+ xtmBYXn/4GZ1s10cvnpX0AH0kNvKUQhKBVI2B2Y6EwCrhGWcHLaS9ThpEyzN1ZSWd+rk bVE/QuNPOgYrRLH43RFTBTfeMqgx+u2UWCBXo9vea+CQgfGz8ekVEfDwh/Zf9OUkIx5m aQba9TBy+/YOAHmqq4PW6hAW0aib8NJpQkkloAWPHfGGxNSDDevEKks+BS3biPjZ4rkA rJew== X-Gm-Message-State: APjAAAVQjgEonGJ4U4enZVyP5eo3FgmGp9l3usakeVwJG4uTBn+GXen1 6ZUid/rShXUjytKt0UXGLCXK9lrz X-Google-Smtp-Source: APXvYqzgd39bIVuBOyGnhSGIs0RmQv8kLM3/64rEpjmKHsM30w0vmMUmwtXGOmAHFCKRIPDGxXccPw== X-Received: by 2002:a05:600c:214a:: with SMTP id v10mr3274880wml.102.1573658971866; Wed, 13 Nov 2019 07:29:31 -0800 (PST) Received: from localhost.localdomain ([82.129.88.112]) by smtp.gmail.com with ESMTPSA id h140sm3171160wme.22.2019.11.13.07.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 07:29:30 -0800 (PST) From: Derek Buitenhuis To: ffmpeg-devel@ffmpeg.org Date: Wed, 13 Nov 2019 15:29:22 +0000 Message-Id: <20191113152922.9143-1-derek.buitenhuis@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <99f28741-0edc-98fd-ccf7-bdef64a83fbb@gmail.com> References: <99f28741-0edc-98fd-ccf7-bdef64a83fbb@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Derek Buitenhuis --- libavcodec/librav1e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 5052cac896..a5835ee6be 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -533,7 +533,7 @@ retry: #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM static const AVOption options[] = { - { "qp", "use constant quantizer mode", OFFSET(quantizer), AV_OPT_TYPE_INT, { .i64 = 100 }, -1, 255, VE }, + { "qp", "use constant quantizer mode (defaults to 100 if no bit rate is set)", OFFSET(quantizer), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 255, VE }, { "speed", "what speed preset to use", OFFSET(speed), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 10, VE }, { "tiles", "number of tiles encode with", OFFSET(tiles), AV_OPT_TYPE_INT, { .i64 = 0 }, -1, INT64_MAX, VE }, { "tile-rows", "number of tiles rows to encode with", OFFSET(tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, -1, INT64_MAX, VE },