From patchwork Mon Dec 2 18:19:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas George X-Patchwork-Id: 16542 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 858D4447FAC for ; Mon, 2 Dec 2019 20:19:10 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6193C68B0C5; Mon, 2 Dec 2019 20:19:10 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FB7068AE90 for ; Mon, 2 Dec 2019 20:19:04 +0200 (EET) X-ENS-nef-client: 129.199.129.80 Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id xB2IJ39N014681 for ; Mon, 2 Dec 2019 19:19:04 +0100 Received: by phare.normalesup.org (Postfix, from userid 1001) id 8B0E3EB5B7; Mon, 2 Dec 2019 19:19:03 +0100 (CET) From: Nicolas George To: ffmpeg-devel@ffmpeg.org Date: Mon, 2 Dec 2019 19:19:01 +0100 Message-Id: <20191202181901.1124-1-george@nsup.org> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Mon, 02 Dec 2019 19:19:04 +0100 (CET) Subject: [FFmpeg-devel] [PATCH] ffmpeg_filter: enhance reporting of unconnected pads. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Nicolas George --- fftools/ffmpeg_filter.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 72838de1e2..ff46ffab01 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -269,6 +269,13 @@ static void init_input_filter(FilterGraph *fg, AVFilterInOut *in) char *p; int file_idx = strtol(in->name, &p, 0); + av_log(0, 16, "name = %s\n", in->name); + if (p == in->name) { + av_log(NULL, AV_LOG_FATAL, + "Unconnected pad [%s] is not a stream selector in filtergraph description %s.\n", + in->name, fg->graph_desc); + exit_program(1); + } if (file_idx < 0 || file_idx >= nb_input_files) { av_log(NULL, AV_LOG_FATAL, "Invalid file index %d in filtergraph description %s.\n", file_idx, fg->graph_desc);