From patchwork Tue Dec 10 20:11:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 16701 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 1B4974470A7 for ; Tue, 10 Dec 2019 22:11:10 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 00ECF68B29E; Tue, 10 Dec 2019 22:11:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC20668AFDD for ; Tue, 10 Dec 2019 22:11:03 +0200 (EET) Received: by mail-lj1-f170.google.com with SMTP id a13so21328527ljm.10 for ; Tue, 10 Dec 2019 12:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=Re/cthARO105nAH0POaH3P+/WA/Ga1XV6pYOUwqB5w4=; b=RdrOMdf20jmNgUzvtlXJI6RJgKPUqicky/8+hzy0pzFpY24hhv6t6sveTiAdqcpVlR b/N6oqdDK4SHq4Fy7EiE+wsUl84Eo5rFeZxbDYl5QjR00zEvym8SetuFwU2Ib5bAH1ir XkEzLn5yTEls8TqaZqHu4LKUQQZegz+X34gCkwizqpBRswEWQg3JY5qAkLSDUslw/cAS AtVtABXaMumVxEmniYYXnYQRw0a/ivjCs2T/cxoWKQkuJ/p4rgoHVuljeDrsXFAQDdK7 o/O6Pt1rwfVq8KobiAejRB+dYhhVqBlAYUcVpCAxGpl3YWaE9loDyUMTYy8aoXw4XTsL q/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Re/cthARO105nAH0POaH3P+/WA/Ga1XV6pYOUwqB5w4=; b=l5KvK1qC+IHgkqQuiFEPSfepINJlg09VVmpeznRA+wfbTjQjrLfl7kXghmyMLY3t6D ukAKUrRyBZ+ckbV1e87LPI4j/0yyFxFDH9qHEeEleEaaB7RIPyORupBDhddp+sF1EKSe 9prpz+d7zUNQrdJ3FLpY/bEbSUGQECISpaGxz14sGpQjGvKdWtsBxeEz/zGe5D7RIqzU /on13oKShts5UUBGIXUDOOcK9FwZtxRod7HhddCsAKAQV3mUNbfGa4BeQpX41vJnO9F9 8af2u2e1VXZvL4PjAn4wIv/eY/HBiSNv6SZy+sqM5kullyHfLbmkZfjx7+rVLJCQUMsp 2LfQ== X-Gm-Message-State: APjAAAXs12WrA/vOkBpnoj1y1UoHuB7ufQscyF5GyvD4JKTsA4xj4FM+ XIxWtbCdNAfA9oxgWSkeNU5WaEZCYFE= X-Google-Smtp-Source: APXvYqwmxGyHYaH7TBKlwO4EZZrqreglN1kQX5UEUcFEmYQsgu5YbCYumOz8ASkhZp7PpjZ1JCq+2A== X-Received: by 2002:a2e:7d0c:: with SMTP id y12mr21502242ljc.39.1576008662604; Tue, 10 Dec 2019 12:11:02 -0800 (PST) Received: from localhost.localdomain (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id i1sm2361456lji.71.2019.12.10.12.11.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 12:11:02 -0800 (PST) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 10 Dec 2019 22:11:01 +0200 Message-Id: <20191210201101.22386-1-martin@martin.st> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] fate: Use a oneoff test for the tremolo filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The tremolo filter uses floating point internally, and uses multiplication factors derived from sin(fmod()), neither of which is bitexact for use with framecrc. This fixes running this test with mingw/x86_32 binaries when run in wine on linux (unsure if the same issue is present when run on actual windows). In this case, a 1 ulp difference in the output from fmod() would end up in an output from the filter that differs by 1 ulp, but which makes the lrint() in swresample/audioconvert.c round in a different direction. --- This change requires uploading a new reference file. --- tests/fate/filter-audio.mak | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index fed2644ccf..b1dcb9787a 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@ -189,7 +189,10 @@ fate-filter-stereotools: CMD = framecrc -i $(SRC) -frames:a 20 -af stereotools=m FATE_AFILTER-$(call FILTERDEMDECENCMUX, TREMOLO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-tremolo fate-filter-tremolo: tests/data/asynth-44100-2.wav fate-filter-tremolo: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav -fate-filter-tremolo: CMD = framecrc -i $(SRC) -frames:a 20 -af tremolo +fate-filter-tremolo: CMD = ffmpeg -i $(SRC) -frames:a 20 -af tremolo -f wav -f s16le - +fate-filter-tremolo: REF = $(SAMPLES)/filter/tremolo.pcm +fate-filter-tremolo: CMP = oneoff +fate-filter-tremolo: CMP_UNIT = s16 FATE_AFILTER-$(call FILTERDEMDECENCMUX, COMPAND, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-compand fate-filter-compand: tests/data/asynth-44100-2.wav