From patchwork Wed Dec 11 07:43:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 16720 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 50EE444996A for ; Wed, 11 Dec 2019 09:43:21 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DCE968AF24; Wed, 11 Dec 2019 09:43:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A72968ACCA for ; Wed, 11 Dec 2019 09:43:14 +0200 (EET) Received: by mail-lj1-f182.google.com with SMTP id m6so22909472ljc.1 for ; Tue, 10 Dec 2019 23:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=I+dEtWC3hmhcIQ8MnOCITkKFGWwPOFLIF/aDHYsAn/k=; b=aL3BWk0wNBT/6LTzAvRtK6Ar2gbZibXTqNU7ntlvZMbVwx5U5+EAJ/Xy9vUloIeIQH rdK9JTdFaDleF5fehWLgcB3Tld+XqZnI+/STxT384a9toXJ+PUobc/m4FAIv/N46sXrq SDQAcyZpQSha0k4WaPOEE/cMlbGy32ngTE7VKvmEzikk0x1McIBcK9U3tBpArwqCQqMF 7xGms1634bnpsp0Lqt65NG4gWNxjvGDKV+nC37K0r1DNUxpkpNsXgp+XBX7/OqP25GX7 OD0ArVVZ4q9XNrvmXZbD1VMnf6IOPy1ljNpBVJULA2A570FCCiOCJBuzdTYrPsJ2HvX5 ZDZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=I+dEtWC3hmhcIQ8MnOCITkKFGWwPOFLIF/aDHYsAn/k=; b=fNwus/LTr6LxR5Q+7AWpFCqWRvxIKvkrMqqo0iLTTw2CAg+bi6OK+U2pOc1Sz3nXHJ ba5bDVI4uffuiNJocnHv1s2qOvkW3GcTvtPB/D2MR0uRmusXcDgTCnWH1oFUYwFuUTI4 jgOpjI+r4q5ZLbe2UU6co1YRV/8zCSWHzGZ7TpZC6z2znflAVhlESBVU3Q3ZGlUAq6ET 8PCLqJOVugTCd7zqOAicahDXAzGFl+BVper3XuMgOvFIJ8XRdWF4jqhIXKOUKD0vDB2c qUmYgvFOGYjBAwkxGjcGQ23zSwzE8Xw+93Z1pnko49sRnIgdlPtk7e+k7FBPMa9TuuVH ddXw== X-Gm-Message-State: APjAAAWWux3BfZ/Wqo8WmdQrWyC/+5gQKiDxyAinZoO9VAD9aiq2zGyP fXHktqm4/1bekMFAPHeFmsr8a5NuukM= X-Google-Smtp-Source: APXvYqxJyj59q0wKXgiCFywYe4+I17SjIAIshcZt/eAvJmDslh+WEZOLg+3les0vw9qvr35Uo4tsCw== X-Received: by 2002:a2e:7f08:: with SMTP id a8mr999171ljd.164.1576050193490; Tue, 10 Dec 2019 23:43:13 -0800 (PST) Received: from localhost.localdomain (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id a21sm638303lfg.44.2019.12.10.23.43.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 23:43:13 -0800 (PST) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 11 Dec 2019 09:43:12 +0200 Message-Id: <20191211074312.26817-1-martin@martin.st> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Subject: [FFmpeg-devel] [PATCHv2] fate: Use a oneoff test for the tremolo filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The tremolo filter uses floating point internally, and uses multiplication factors derived from sin(fmod()), neither of which is bitexact for use with framecrc. This fixes running this test with mingw/x86_32 binaries when run in wine on linux (unsure if the same issue is present when run on actual windows). In this case, a 1 ulp difference in the output from fmod() would end up in an output from the filter that differs by 1 ulp, but which makes the lrint() in swresample/audioconvert.c round in a different direction. --- Updated with the existing reference file removed. --- tests/fate/filter-audio.mak | 5 ++++- tests/ref/fate/filter-tremolo | 26 -------------------------- 2 files changed, 4 insertions(+), 27 deletions(-) delete mode 100644 tests/ref/fate/filter-tremolo diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index fed2644ccf..b1dcb9787a 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@ -189,7 +189,10 @@ fate-filter-stereotools: CMD = framecrc -i $(SRC) -frames:a 20 -af stereotools=m FATE_AFILTER-$(call FILTERDEMDECENCMUX, TREMOLO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-tremolo fate-filter-tremolo: tests/data/asynth-44100-2.wav fate-filter-tremolo: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav -fate-filter-tremolo: CMD = framecrc -i $(SRC) -frames:a 20 -af tremolo +fate-filter-tremolo: CMD = ffmpeg -i $(SRC) -frames:a 20 -af tremolo -f wav -f s16le - +fate-filter-tremolo: REF = $(SAMPLES)/filter/tremolo.pcm +fate-filter-tremolo: CMP = oneoff +fate-filter-tremolo: CMP_UNIT = s16 FATE_AFILTER-$(call FILTERDEMDECENCMUX, COMPAND, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-compand fate-filter-compand: tests/data/asynth-44100-2.wav diff --git a/tests/ref/fate/filter-tremolo b/tests/ref/fate/filter-tremolo deleted file mode 100644 index c6cff52c0e..0000000000 --- a/tests/ref/fate/filter-tremolo +++ /dev/null @@ -1,26 +0,0 @@ -#tb 0: 1/44100 -#media_type 0: audio -#codec_id 0: pcm_s16le -#sample_rate 0: 44100 -#channel_layout 0: 3 -#channel_layout_name 0: stereo -0, 0, 0, 1024, 4096, 0x5d3be907 -0, 1024, 1024, 1024, 4096, 0xea151fbe -0, 2048, 2048, 1024, 4096, 0xa5bc19f4 -0, 3072, 3072, 1024, 4096, 0x8706ec6d -0, 4096, 4096, 1024, 4096, 0x334ff275 -0, 5120, 5120, 1024, 4096, 0xcd0ff7ad -0, 6144, 6144, 1024, 4096, 0x29a1e9c9 -0, 7168, 7168, 1024, 4096, 0x1d41e77f -0, 8192, 8192, 1024, 4096, 0x99e7fe07 -0, 9216, 9216, 1024, 4096, 0x4bbf09ce -0, 10240, 10240, 1024, 4096, 0x94600236 -0, 11264, 11264, 1024, 4096, 0xc8af0c9e -0, 12288, 12288, 1024, 4096, 0x70eef88f -0, 13312, 13312, 1024, 4096, 0xb222ec47 -0, 14336, 14336, 1024, 4096, 0x1071ee27 -0, 15360, 15360, 1024, 4096, 0x7c390bd2 -0, 16384, 16384, 1024, 4096, 0x68bdf655 -0, 17408, 17408, 1024, 4096, 0x810cfacb -0, 18432, 18432, 1024, 4096, 0x9639e41f -0, 19456, 19456, 1024, 4096, 0xa30be70f