| Message ID | 20200114031336.24096-4-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,1/7] avformat/segafilmenc: Fix undefined left shift of 1 by 31 places | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
Andreas Rheinhardt: > This muxer does not have any private options and so does not need a > private class. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavformat/segafilmenc.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c > index bd7c03faf5..5ac60ea5c3 100644 > --- a/libavformat/segafilmenc.c > +++ b/libavformat/segafilmenc.c > @@ -45,7 +45,6 @@ typedef struct FILMPacket { > } FILMPacket; > > typedef struct FILMOutputContext { > - const AVClass *class; > int audio_index; > int video_index; > int64_t stab_pos; > @@ -377,12 +376,6 @@ static int film_write_header(AVFormatContext *format_context) > return 0; > } > > -static const AVClass film_muxer_class = { > - .class_name = "Sega FILM muxer", > - .item_name = av_default_item_name, > - .version = LIBAVUTIL_VERSION_INT, > -}; > - > AVOutputFormat ff_segafilm_muxer = { > .name = "film_cpk", > .long_name = NULL_IF_CONFIG_SMALL("Sega FILM / CPK"), > @@ -393,5 +386,4 @@ AVOutputFormat ff_segafilm_muxer = { > .init = film_init, > .write_trailer = film_write_header, > .write_packet = film_write_packet, > - .priv_class = &film_muxer_class, > }; > Ping. - Andreas
LGTM On 1/14/20, Andreas Rheinhardt <andreas.rheinhardt@gmail.com> wrote: > This muxer does not have any private options and so does not need a > private class. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavformat/segafilmenc.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c > index bd7c03faf5..5ac60ea5c3 100644 > --- a/libavformat/segafilmenc.c > +++ b/libavformat/segafilmenc.c > @@ -45,7 +45,6 @@ typedef struct FILMPacket { > } FILMPacket; > > typedef struct FILMOutputContext { > - const AVClass *class; > int audio_index; > int video_index; > int64_t stab_pos; > @@ -377,12 +376,6 @@ static int film_write_header(AVFormatContext > *format_context) > return 0; > } > > -static const AVClass film_muxer_class = { > - .class_name = "Sega FILM muxer", > - .item_name = av_default_item_name, > - .version = LIBAVUTIL_VERSION_INT, > -}; > - > AVOutputFormat ff_segafilm_muxer = { > .name = "film_cpk", > .long_name = NULL_IF_CONFIG_SMALL("Sega FILM / CPK"), > @@ -393,5 +386,4 @@ AVOutputFormat ff_segafilm_muxer = { > .init = film_init, > .write_trailer = film_write_header, > .write_packet = film_write_packet, > - .priv_class = &film_muxer_class, > }; > -- > 2.20.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On Sat, Feb 15, 2020 at 01:30:33PM +0100, Paul B Mahol wrote:
> LGTM
will apply
[...]
diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c index bd7c03faf5..5ac60ea5c3 100644 --- a/libavformat/segafilmenc.c +++ b/libavformat/segafilmenc.c @@ -45,7 +45,6 @@ typedef struct FILMPacket { } FILMPacket; typedef struct FILMOutputContext { - const AVClass *class; int audio_index; int video_index; int64_t stab_pos; @@ -377,12 +376,6 @@ static int film_write_header(AVFormatContext *format_context) return 0; } -static const AVClass film_muxer_class = { - .class_name = "Sega FILM muxer", - .item_name = av_default_item_name, - .version = LIBAVUTIL_VERSION_INT, -}; - AVOutputFormat ff_segafilm_muxer = { .name = "film_cpk", .long_name = NULL_IF_CONFIG_SMALL("Sega FILM / CPK"), @@ -393,5 +386,4 @@ AVOutputFormat ff_segafilm_muxer = { .init = film_init, .write_trailer = film_write_header, .write_packet = film_write_packet, - .priv_class = &film_muxer_class, };
This muxer does not have any private options and so does not need a private class. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavformat/segafilmenc.c | 8 -------- 1 file changed, 8 deletions(-)