diff mbox series

[FFmpeg-devel] avcodec/libaomenc: add an option to set the encoder "usage"

Message ID 20200123000843.377-1-jamrial@gmail.com
State Accepted
Headers show
Series [FFmpeg-devel] avcodec/libaomenc: add an option to set the encoder "usage" | expand

Checks

Context Check Description
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

James Almer Jan. 23, 2020, 12:08 a.m. UTC 
This allows the user enable the realtime encoding speed mode

Signed-off-by: James Almer <jamrial@gmail.com>
---
The g_usage field is present since 1.0.0, but the AOM_USAGE_* defines were
introduced with the real time mode about a year ago. Builds before that
addition simply ignore the field.

 libavcodec/libaomenc.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

James Zern Jan. 23, 2020, 10:21 p.m. UTC | #1 
On Thu, Jan 23, 2020 at 2:26 AM James Almer <jamrial@gmail.com> wrote:
>
> This allows the user enable the realtime encoding speed mode
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> The g_usage field is present since 1.0.0, but the AOM_USAGE_* defines were
> introduced with the real time mode about a year ago. Builds before that
> addition simply ignore the field.
>
>  libavcodec/libaomenc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>

lgtm.
diff mbox series

Patch

diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
index c36313bf9d..096aadbe1c 100644
--- a/libavcodec/libaomenc.c
+++ b/libavcodec/libaomenc.c
@@ -93,6 +93,7 @@  typedef struct AOMEncoderContext {
     int enable_global_motion;
     int enable_intrabc;
     int enable_restoration;
+    int usage;
 } AOMContext;
 
 static const char *const ctlidstr[] = {
@@ -551,6 +552,8 @@  static av_cold int aom_init(AVCodecContext *avctx,
     enccfg.g_threads      =
         FFMIN(avctx->thread_count ? avctx->thread_count : av_cpu_count(), 64);
 
+    enccfg.g_usage        = ctx->usage;
+
     if (ctx->lag_in_frames >= 0)
         enccfg.g_lag_in_frames = ctx->lag_in_frames;
 
@@ -1090,6 +1093,9 @@  static const AVOption options[] = {
     { "enable-global-motion",  "Enable global motion",             OFFSET(enable_global_motion), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
     { "enable-intrabc",  "Enable intra block copy prediction mode", OFFSET(enable_intrabc), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
     { "enable-restoration", "Enable Loop Restoration filtering", OFFSET(enable_restoration), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
+    { "usage",           "Quality and compression efficiency vs speed tradeof", OFFSET(usage), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "usage"},
+    { "good",            "Good quality",      0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"},
+    { "realtime",        "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */},     0, 0, VE, "usage"},
     { NULL },
 };