From patchwork Sun Jan 26 15:08:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 17559 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 01F2244BE0F for ; Sun, 26 Jan 2020 17:15:20 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D53AE68AD52; Sun, 26 Jan 2020 17:15:19 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF1AB688075 for ; Sun, 26 Jan 2020 17:15:13 +0200 (EET) Received: by mail-qk1-f195.google.com with SMTP id w25so1517361qki.3 for ; Sun, 26 Jan 2020 07:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=gst1RQujh2kaV+6nJQDlEUFe0sU0gq3Cx29xfu3qjeY=; b=n+Nabz5QQLr/ZRu1V8//dpakFAokBE+7T5EY1o39Xs+End78UyYftxHbnVFC/4KXnz EGBcTN0Q4rAmy8GErr4KgA1YBdFyyRy7IRItd/lnx/1jY97tXZU76kEFgHIWz3GGwfQZ Q9rddaJvxkS/SpnENgmr7ieqR2PwQG3bkSOn5NOqsA/owsoRqCPkDYUYRuXZT8ivSejN gmFvFNCHTqRX/CChzZPkcNgZ0txFoqzNQROrP2bGo84zUBxytbOPyLebfLwENLi2xTPy f9RBIL0vBhYC0eu7RgzL+p+fA+l328/rin7GFb9IOx9LbTWdnED/tONxF9f0lHQOJOlE SFBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=gst1RQujh2kaV+6nJQDlEUFe0sU0gq3Cx29xfu3qjeY=; b=a6tl/cE7qVxfPepkszsjlxqg7r2I6e7z0QXafqHD2dj2Y0XzldOwglYhQapu79GKxC zK9XmZWaDDVG2aHP6QmHqsgl/Fl+Bdw5dqiM5H/uV/iEGiZyK2zcg//eRC6frWSvpAih oFSU46RiUzkPjhim3z8cWhFG+vI903roOVywX4IdL8/frooxAiOzdLArMVOgWizrSdjC 6AJ55QlTwTebduhMjdtgGRLSJbYLUHb4VqgjmYBvTLdoK3pe2ssH08zunSn1UdHLem+Q Uvk3dPNJ2GIJsSQq0E3I5alGjvTqZwzB4TxFb22NrQXak6o7y1u9Ue90SUcuJPdrCkju VxHg== X-Gm-Message-State: APjAAAU5VNH8firNijqhbiM9YEzDfl0RX2w7lwbvo4kgRLSQ9wfh/aYt QQmYTqslZyXbW79YX6mZ7+uCMeYK X-Google-Smtp-Source: APXvYqyuusENHxED3e9anr5WBZhHH9lUHNCmLJ/7PCX+RiT0+S4KBqbzetCRuR++aY6Odg2ECANx7A== X-Received: by 2002:a37:4702:: with SMTP id u2mr12619327qka.106.1580051333607; Sun, 26 Jan 2020 07:08:53 -0800 (PST) Received: from localhost.localdomain ([191.83.211.22]) by smtp.gmail.com with ESMTPSA id 135sm7038476qkl.68.2020.01.26.07.08.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2020 07:08:53 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Sun, 26 Jan 2020 12:08:26 -0300 Message-Id: <20200126150826.15349-1-jamrial@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] configure: don't enable $ARCH_external if $ARCH is disabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The check_x86asm() checks would force enable these variables on success, bypassing any --disable-* command line option. This is important in the case of AVX512, where the relevant define is used to choose between different values for memory alignment and strides in some allocations. Signed-off-by: James Almer --- configure | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index c02dbcc8b2..f7c55c0830 100755 --- a/configure +++ b/configure @@ -5925,10 +5925,10 @@ EOF elf*) enabled debug && append X86ASMFLAGS $x86asm_debug ;; esac - check_x86asm avx512_external "vmovdqa32 [eax]{k1}{z}, zmm0" - check_x86asm avx2_external "vextracti128 xmm0, ymm0, 0" - check_x86asm xop_external "vpmacsdd xmm0, xmm1, xmm2, xmm3" - check_x86asm fma4_external "vfmaddps ymm0, ymm1, ymm2, ymm3" + enabled avx512 && check_x86asm avx512_external "vmovdqa32 [eax]{k1}{z}, zmm0" + enabled avx2 && check_x86asm avx2_external "vextracti128 xmm0, ymm0, 0" + enabled xop && check_x86asm xop_external "vpmacsdd xmm0, xmm1, xmm2, xmm3" + enabled fma4 && check_x86asm fma4_external "vfmaddps ymm0, ymm1, ymm2, ymm3" check_x86asm cpunop "CPU amdnop" fi