diff mbox series

[FFmpeg-devel,1/2] avcodec/audiodsp: Fix integer overflow in scalarproduct_int16_c()

Message ID 20200202215202.16736-1-michael@niedermayer.cc
State Accepted
Commit abb5762e985f4ce34e97c1b2fa6d1108ce8a881f
Headers show
Series [FFmpeg-devel,1/2] avcodec/audiodsp: Fix integer overflow in scalarproduct_int16_c() | expand

Checks

Context Check Description
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Michael Niedermayer Feb. 2, 2020, 9:52 p.m. UTC
Fixes: signed integer overflow: 2145417478 + 76702564 cannot be represented in type 'int'
Fixes: 20313/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RA_144_fuzzer-5734487724130304

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/audiodsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer April 15, 2020, 10:56 p.m. UTC | #1
On Sun, Feb 02, 2020 at 10:52:01PM +0100, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 2145417478 + 76702564 cannot be represented in type 'int'
> Fixes: 20313/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RA_144_fuzzer-5734487724130304
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/audiodsp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply

[...]
diff mbox series

Patch

diff --git a/libavcodec/audiodsp.c b/libavcodec/audiodsp.c
index 3c7a3a7583..efcb0a8e8a 100644
--- a/libavcodec/audiodsp.c
+++ b/libavcodec/audiodsp.c
@@ -79,7 +79,7 @@  static void vector_clipf_c(float *dst, const float *src, int len,
 static int32_t scalarproduct_int16_c(const int16_t *v1, const int16_t *v2,
                                      int order)
 {
-    int res = 0;
+    unsigned res = 0;
 
     while (order--)
         res += *v1++ **v2++;