diff mbox series

[FFmpeg-devel] vf_ssim: Fix loading doubles to float registers on i386

Message ID 20200205113253.75281-1-martin@martin.st
State New
Headers show
Series [FFmpeg-devel] vf_ssim: Fix loading doubles to float registers on i386
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Martin Storsjö Feb. 5, 2020, 11:32 a.m. UTC
This fixes the tests filter-refcmp-ssim-yuv and filter-refcmp-ssim-rgb
on i386 after breaking in fcc0424c933742c8fc852371e985d16b6eb4bfe9.
---
 libavfilter/x86/vf_ssim.asm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol Feb. 5, 2020, 2:25 p.m. UTC | #1
LGTM, will you push it or me?

On 2/5/20, Martin Storsjö <martin@martin.st> wrote:
> This fixes the tests filter-refcmp-ssim-yuv and filter-refcmp-ssim-rgb
> on i386 after breaking in fcc0424c933742c8fc852371e985d16b6eb4bfe9.
> ---
>  libavfilter/x86/vf_ssim.asm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/x86/vf_ssim.asm b/libavfilter/x86/vf_ssim.asm
> index 1e682fe452..78809305de 100644
> --- a/libavfilter/x86/vf_ssim.asm
> +++ b/libavfilter/x86/vf_ssim.asm
> @@ -255,6 +255,6 @@ cglobal ssim_end_line, 3, 3, 7, sum0, sum1, w
>      addpd             m0, m4
>  %if ARCH_X86_32
>      movsd            r0m, m0
> -    fld             r0mp
> +    fld        qword r0m
>  %endif
>      RET
> --
> 2.21.1 (Apple Git-122.3)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Martin Storsjö Feb. 5, 2020, 2:52 p.m. UTC | #2
On Wed, 5 Feb 2020, Paul B Mahol wrote:

> LGTM, will you push it or me?

I pushed it now - thanks!

// Martin
diff mbox series

Patch

diff --git a/libavfilter/x86/vf_ssim.asm b/libavfilter/x86/vf_ssim.asm
index 1e682fe452..78809305de 100644
--- a/libavfilter/x86/vf_ssim.asm
+++ b/libavfilter/x86/vf_ssim.asm
@@ -255,6 +255,6 @@  cglobal ssim_end_line, 3, 3, 7, sum0, sum1, w
     addpd             m0, m4
 %if ARCH_X86_32
     movsd            r0m, m0
-    fld             r0mp
+    fld        qword r0m
 %endif
     RET