diff mbox series

[FFmpeg-devel] avcodec/h264_metadata_bsf: give warning when display_orientation set to EXTRACT

Message ID 20200209051005.7238-1-lq@chinaffmpeg.org
State New
Headers show
Series [FFmpeg-devel] avcodec/h264_metadata_bsf: give warning when display_orientation set to EXTRACT
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Steven Liu Feb. 9, 2020, 5:10 a.m. UTC
because it cannot get result now.

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavcodec/h264_metadata_bsf.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gyan Doshi Feb. 9, 2020, 7:57 a.m. UTC | #1
On 9 February 2020 10:40:05 AM IST, Steven Liu <lq@chinaffmpeg.org> wrote:
>because it cannot get result now.
>
>Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>---
> libavcodec/h264_metadata_bsf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/libavcodec/h264_metadata_bsf.c
>b/libavcodec/h264_metadata_bsf.c
>index d96a50dbf7..712b54dacc 100644
>--- a/libavcodec/h264_metadata_bsf.c
>+++ b/libavcodec/h264_metadata_bsf.c
>@@ -438,6 +438,8 @@ static int h264_metadata_filter(AVBSFContext *bsf,
>AVPacket *pkt)
>     }
> 
>     if (ctx->display_orientation != PASS) {
>+        if (ctx->display_orientation == EXTRACT)
>+            av_log(bsf, AV_LOG_WARNING, "h264_metadata
>display_orientation have not support extract yet!\n");

"Extraction of h264_metadata display_orientation not implemented."

Maybe add a patchwelcome msg as well.

>         for (i = au->nb_units - 1; i >= 0; i--) {
>             H264RawSEI *sei;
>             if (au->units[i].type != H264_NAL_SEI)
>-- 
>2.15.1
>
>
>
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Steven Liu Feb. 9, 2020, 8:25 a.m. UTC | #2
> 在 2020年2月9日,15:57,Gyan Doshi <ffmpeg@gyani.pro> 写道:
> 
> 
> 
> On 9 February 2020 10:40:05 AM IST, Steven Liu <lq@chinaffmpeg.org> wrote:
>> because it cannot get result now.
>> 
>> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>> ---
>> libavcodec/h264_metadata_bsf.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/libavcodec/h264_metadata_bsf.c
>> b/libavcodec/h264_metadata_bsf.c
>> index d96a50dbf7..712b54dacc 100644
>> --- a/libavcodec/h264_metadata_bsf.c
>> +++ b/libavcodec/h264_metadata_bsf.c
>> @@ -438,6 +438,8 @@ static int h264_metadata_filter(AVBSFContext *bsf,
>> AVPacket *pkt)
>>    }
>> 
>>    if (ctx->display_orientation != PASS) {
>> +        if (ctx->display_orientation == EXTRACT)
>> +            av_log(bsf, AV_LOG_WARNING, "h264_metadata
>> display_orientation have not support extract yet!\n");
> 
> "Extraction of h264_metadata display_orientation not implemented.”
Ok,
> 
> Maybe add a patchwelcome msg as well.
Just give a warning message, don’t want break the other workflow, so warning maybe better than return AVERROR_PATCHWELCOME.
> 
>>        for (i = au->nb_units - 1; i >= 0; i--) {
>>            H264RawSEI *sei;
>>            if (au->units[i].type != H264_NAL_SEI)
>> -- 
>> 2.15.1
>> 
>> 
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks
Steven
diff mbox series

Patch

diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c
index d96a50dbf7..712b54dacc 100644
--- a/libavcodec/h264_metadata_bsf.c
+++ b/libavcodec/h264_metadata_bsf.c
@@ -438,6 +438,8 @@  static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt)
     }
 
     if (ctx->display_orientation != PASS) {
+        if (ctx->display_orientation == EXTRACT)
+            av_log(bsf, AV_LOG_WARNING, "h264_metadata display_orientation have not support extract yet!\n");
         for (i = au->nb_units - 1; i >= 0; i--) {
             H264RawSEI *sei;
             if (au->units[i].type != H264_NAL_SEI)