| Message ID | 20200209141723.19095-1-lq@chinaffmpeg.org |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v2] avcodec/h264_metadata_bsf: give warning when display_orientation set to EXTRACT | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
On 09/02/2020 14:17, Steven Liu wrote: > Extraction of h264_metadata display_orientation not implemented yet. > > Suggested-by: Gyan Doshi <ffmpeg@gyani.pro> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org> > --- > libavcodec/h264_metadata_bsf.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c > index d96a50dbf7..89b8d01679 100644 > --- a/libavcodec/h264_metadata_bsf.c > +++ b/libavcodec/h264_metadata_bsf.c > @@ -438,6 +438,9 @@ static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt) > } > > if (ctx->display_orientation != PASS) { > + if (ctx->display_orientation == EXTRACT) > + av_log(bsf, AV_LOG_WARNING, "Extraction of h264_metadata display_orientation not implemented.\n"); > + > for (i = au->nb_units - 1; i >= 0; i--) { > H264RawSEI *sei; > if (au->units[i].type != H264_NAL_SEI) > ??? Look at the code immediately below that. - Mark
diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index d96a50dbf7..89b8d01679 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h264_metadata_bsf.c @@ -438,6 +438,9 @@ static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt) } if (ctx->display_orientation != PASS) { + if (ctx->display_orientation == EXTRACT) + av_log(bsf, AV_LOG_WARNING, "Extraction of h264_metadata display_orientation not implemented.\n"); + for (i = au->nb_units - 1; i >= 0; i--) { H264RawSEI *sei; if (au->units[i].type != H264_NAL_SEI)
Extraction of h264_metadata display_orientation not implemented yet. Suggested-by: Gyan Doshi <ffmpeg@gyani.pro> Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavcodec/h264_metadata_bsf.c | 3 +++ 1 file changed, 3 insertions(+)