From patchwork Sun Feb 9 18:33:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Ramakrishnan X-Patchwork-Id: 17738 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 256D7449C49 for ; Sun, 9 Feb 2020 20:59:04 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F79E68A7B8; Sun, 9 Feb 2020 20:59:04 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1C5068A717 for ; Sun, 9 Feb 2020 20:58:57 +0200 (EET) Received: by mail-oi1-f195.google.com with SMTP id c16so7195777oic.3 for ; Sun, 09 Feb 2020 10:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=PwXf/8DaHcVjL5FutwaoacWnUQQxWMSk4vO945hhbMA=; b=jPLbQjj9JH27WI7aNzRsL4Jr7c5OXKFXBt+/Xy7l/djXoMS1FQGosI5v42MTHmsgAp XlY/qs0/ame0i+9rYs6tuyiKqAyBbMRHbHxWRNpfqEoS1eqmb5wAHV4lNqoGrCL/1jyw 0oWXnqiNNHGHQb40HqsQi2Aw10Wgh+Yi1GbWe6892X0qN3igCoX9lq6W2Q0wf0p5ismM nmBBpAdHhub4whNZ6Rve55LqgEt6afKtVI1RUnSilBoZqMJ9WymQkhTU+y/YOzhlA0dr EeaPU2F6+b1vQSNce4SojxRhu2tCkVnwQYXfCKilS1aRdEK4xtMn6KW17jxb3LCbUqpI vG7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PwXf/8DaHcVjL5FutwaoacWnUQQxWMSk4vO945hhbMA=; b=YFywFkBc3wU0q10ci6B9g9qzpEB9OsO3E68mcoP32z1s37Ga+wuN8jsGUSRrBBRFKt xz/fwgpB3+PYnJ/I5SQqsF0WeheuENDE89mR+gy1nT469LmFk5iuog7cDgoYLionR7f9 MuIJGnlXghBLnY8xpcPD9YdXSty8igWi1Sl06eiU0Dm9OS0qjhCo1CJebopStxbOR0A7 wVSqwLOiXoJRMamjPIV8j759G2VKDyctNW1H3gEZzI+++HUos6Jwcmhc+KGEu20hhwdH 5pvE7nG8LquMCafqAtd2nt/F786SafY2Y+qWvxtNOyAv5H1AP2CP1EqBf9l7D2ekbm17 NmZQ== X-Gm-Message-State: APjAAAVd2yHar8wo75rVZB3LcUrp1zae9MjFx7rNZssOCyAZ7ejhkmIh mWv/fnRfZUb8O3Fx9oz5v22y5zCh7QZcWg== X-Google-Smtp-Source: APXvYqy3OhzbMKMcds81nfsJQQ+JNrZGuit0XHqAY7BPmKlEAC2nwf04uHGWyh1N/GXMhOWPNkIeLw== X-Received: by 2002:a17:90a:c78f:: with SMTP id gn15mr16139638pjb.64.1581273200342; Sun, 09 Feb 2020 10:33:20 -0800 (PST) Received: from localhost.localdomain ([223.186.195.248]) by smtp.gmail.com with ESMTPSA id h7sm10088876pfq.36.2020.02.09.10.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2020 10:33:19 -0800 (PST) From: gautamramk@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 10 Feb 2020 00:03:09 +0530 Message-Id: <20200209183309.11939-1-gautamramk@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [FFmpeg][PATCH] libswscale/utils.c: Fix bug #8255 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Gautam Ramakrishnan MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Gautam Ramakrishnan Bug #8255 points out a double free error in libwscale/utils.c file. The double free is because the pointer to cascaded_context of an sw_context is not set to NULL after freeing it. When the sw_context is later freed, sws_freeContext is called on the cascaded_context, causing a double free. --- libswscale/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libswscale/utils.c b/libswscale/utils.c index b2c08a5983..e9c66aeb4f 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1502,6 +1502,7 @@ av_cold int sws_init_context(SwsContext *c, SwsFilter *srcFilter, ff_free_filters(c2); if (ff_init_filters(c2) < 0) { sws_freeContext(c2); + c->cascaded_context[1] = NULL; return -1; }