From patchwork Wed Feb 12 18:12:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Ramakrishnan X-Patchwork-Id: 17763 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 71EA6447579 for ; Wed, 12 Feb 2020 20:19:21 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EB7368AAF2; Wed, 12 Feb 2020 20:19:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 51A55689B4D for ; Wed, 12 Feb 2020 20:19:14 +0200 (EET) Received: by mail-pg1-f196.google.com with SMTP id z7so1629238pgk.7 for ; Wed, 12 Feb 2020 10:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Whl0gBSmIjfcPwuOv8on5wA2SpW2O5r5PSZXVSXdBeI=; b=UtKcR7ln6Xj52wJwoFTCZO+XHkCxSdLFBGtIz6G4F/qhjRR/+kiMZN+3nn9t99Ka4P IToMrcBH1ZyznSlciy52os+nje8kk5SgjcAsbGPpkrCX8Q68sim3mvwwZhpFGuy+RWsS KpfhAoaY+vY9eAuTx0Y3uPKYewN3vgGyuAd52daI1++9SjfwBW9ALnZnFjeWOYbQOHmp xYYOm1jL3Oo0U+I2AOc6UeEo/y3A99pXXp6jvStZEzRwiLJCd/CJrzm8RUn3xaAjoELD f17Q7Vk6JqT+n7JRBSte5Jy3j6CRg2sIabRA1cp80LUwmwZWB/+40mVqMEFQ2QH6EhwN /hIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Whl0gBSmIjfcPwuOv8on5wA2SpW2O5r5PSZXVSXdBeI=; b=VbX2/qWqxwAIINHA+6b3Ya5XSFtybv2ZrpcHgoQFB9zb1+xGgjV3UgRLCDP0C9wPrB KXfCqY0S9F3qMt7b2/Fla5nC7APAcQviHbM49Ss7b8LLJ0EHSuKTzd3ePi7aEnFyLhug 8dY8zkMj/JdGDcIcesqCPzjcOQiR0Tudq2DXm+Dnr8VjY5Af7PpcVLOd4rlhW9HBfKtX ygkkQKL7CsfjoWJHymW9MKoL7XuGHytcVth2dBADq8/4qiv0iCgZ4r879YgljZXbbA2H Q0tHCwa7HNz7ginWKqFa25X3Rn+cJal/MESNnrSnvijTLHvpH6CFdVj2A49OmZiNYleK 3aRQ== X-Gm-Message-State: APjAAAWMZCGS98kkhOl4f4YzSdwAoXLmTu9oKEG2A6HXzv1rQARrSQCP 6wtnhX8P+C7oDps/cdn0uUhih7G/Tys= X-Google-Smtp-Source: APXvYqxNKdIPNmUCsh1uu1q2shr+kjaSC3ybJ8T1rvtby2301hi6wlHOMuaALK1YpJZrCkQLlgwaMA== X-Received: by 2002:a63:f744:: with SMTP id f4mr10197782pgk.345.1581531167246; Wed, 12 Feb 2020 10:12:47 -0800 (PST) Received: from localhost.localdomain ([223.186.237.132]) by smtp.gmail.com with ESMTPSA id o1sm1662932pfg.60.2020.02.12.10.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 10:12:46 -0800 (PST) From: gautamramk@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 12 Feb 2020 23:42:30 +0530 Message-Id: <20200212181230.24531-1-gautamramk@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Gautam Ramakrishnan MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Gautam Ramakrishnan This commit fixes bug #8466 wherein URLs with query string not preceeded by the '/' symbol in a URL was failing to get parsed. The av_url_split() function now checks if the path starts with a '/' and prepends it if it does not. --- libavformat/utils.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 81ea239a66..a14d4ef90d 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4819,6 +4819,13 @@ void av_url_split(char *proto, int proto_size, av_strlcpy(path, ls, path_size); else ls = &p[strlen(p)]; // XXX + /* if path does not start with a /, prepend a / */ + if (path[0] != '/') { + char temp[1024]; + av_strlcpy(temp, path, path_size); + path[0] = '/'; + av_strlcpy(path + 1, temp, path_size - 1); + } /* the rest is hostname, use that to parse auth/port */ if (ls != p) {