diff mbox series

[FFmpeg-devel] OpenBSD suport

Message ID 20200215202941.GA36927@humpty.home.comstyle.com
State New
Headers show
Series [FFmpeg-devel] OpenBSD suport
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Brad Smith Feb. 15, 2020, 8:29 p.m. UTC
- Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile.
- Enable section_data_rel_ro for ARM support.

Comments

Michael Niedermayer Feb. 16, 2020, 2:51 p.m. UTC | #1
On Sat, Feb 15, 2020 at 03:29:41PM -0500, Brad Smith wrote:
> - Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile.
> - Enable section_data_rel_ro for ARM support.

are these 2 changes related ?
if not, then they should not be in the same patch

thx

[...]
Brad Smith Feb. 16, 2020, 7:25 p.m. UTC | #2
On Sun, Feb 16, 2020 at 03:51:26PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 15, 2020 at 03:29:41PM -0500, Brad Smith wrote:
> > - Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile.
> > - Enable section_data_rel_ro for ARM support.
> 
> are these 2 changes related ?
> if not, then they should not be in the same patch
> 
> thx
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Complexity theory is the science of finding the exact solution to an
> approximation. Benchmarking OTOH is finding an approximation of the exact

Ok, separated out the first part.


Enable section_data_rel_ro for ARM support.

diff --git a/configure b/configure
index ab761c7183..06e3a7b2a8 100755
--- a/configure
+++ b/configure
@@ -5305,6 +5305,7 @@ case $target_os in
         ;;
     openbsd|bitrig)
         disable symver
+        enable section_data_rel_ro
         striptype=""
         SHFLAGS='-shared'
         SLIB_INSTALL_NAME='$(SLIBNAME).$(LIBMAJOR).$(LIBMINOR)'
Michael Niedermayer Feb. 16, 2020, 11:23 p.m. UTC | #3
On Sun, Feb 16, 2020 at 02:25:28PM -0500, Brad Smith wrote:
> On Sun, Feb 16, 2020 at 03:51:26PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 15, 2020 at 03:29:41PM -0500, Brad Smith wrote:
> > > - Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile.
> > > - Enable section_data_rel_ro for ARM support.
> > 
> > are these 2 changes related ?
> > if not, then they should not be in the same patch
> > 
> > thx
> > 
> > [...]
> > -- 
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > 
> > Complexity theory is the science of finding the exact solution to an
> > approximation. Benchmarking OTOH is finding an approximation of the exact
> 
> Ok, separated out the first part.
> 
> 
> Enable section_data_rel_ro for ARM support.
> 
> diff --git a/configure b/configure
> index ab761c7183..06e3a7b2a8 100755
> --- a/configure
> +++ b/configure
> @@ -5305,6 +5305,7 @@ case $target_os in
>          ;;
>      openbsd|bitrig)
>          disable symver
> +        enable section_data_rel_ro
>          striptype=""
>          SHFLAGS='-shared'
>          SLIB_INSTALL_NAME='$(SLIBNAME).$(LIBMAJOR).$(LIBMINOR)'

If no arm or openbsd experts reply/review then this is probably ok

thx

[...]
Brad Smith Feb. 16, 2020, 11:29 p.m. UTC | #4
On 2/16/2020 6:23 PM, Michael Niedermayer wrote:

> On Sun, Feb 16, 2020 at 02:25:28PM -0500, Brad Smith wrote:
>> On Sun, Feb 16, 2020 at 03:51:26PM +0100, Michael Niedermayer wrote:
>>> On Sat, Feb 15, 2020 at 03:29:41PM -0500, Brad Smith wrote:
>>>> - Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile.
>>>> - Enable section_data_rel_ro for ARM support.
>>> are these 2 changes related ?
>>> if not, then they should not be in the same patch
>>>
>>> thx
>>>
>>> [...]
>>> -- 
>>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>>
>>> Complexity theory is the science of finding the exact solution to an
>>> approximation. Benchmarking OTOH is finding an approximation of the exact
>> Ok, separated out the first part.
>>
>>
>> Enable section_data_rel_ro for ARM support.
>>
>> diff --git a/configure b/configure
>> index ab761c7183..06e3a7b2a8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5305,6 +5305,7 @@ case $target_os in
>>           ;;
>>       openbsd|bitrig)
>>           disable symver
>> +        enable section_data_rel_ro
>>           striptype=""
>>           SHFLAGS='-shared'
>>           SLIB_INSTALL_NAME='$(SLIBNAME).$(LIBMAJOR).$(LIBMINOR)'
> If no arm or openbsd experts reply/review then this is probably ok
>
> thx
>

This is from our current OpenBSD port / package that I maintain.

http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/graphics/ffmpeg/patches/patch-configure?rev=1.61&content-type=text/plain&hideattic=1 
<http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/graphics/ffmpeg/patches/patch-configure?rev=1.61&content-type=text/plain&hideattic=1>
Michael Niedermayer Feb. 16, 2020, 11:34 p.m. UTC | #5
On Sun, Feb 16, 2020 at 06:29:46PM -0500, Brad Smith wrote:
> On 2/16/2020 6:23 PM, Michael Niedermayer wrote:
> 
> >On Sun, Feb 16, 2020 at 02:25:28PM -0500, Brad Smith wrote:
> >>On Sun, Feb 16, 2020 at 03:51:26PM +0100, Michael Niedermayer wrote:
> >>>On Sat, Feb 15, 2020 at 03:29:41PM -0500, Brad Smith wrote:
> >>>>- Garbage collect bitrig. Was a OpenBSD derivative that has been dead for quite awhile.
> >>>>- Enable section_data_rel_ro for ARM support.
> >>>are these 2 changes related ?
> >>>if not, then they should not be in the same patch
> >>>
> >>>thx
> >>>
> >>>[...]
> >>>-- 
> >>>Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >>>
> >>>Complexity theory is the science of finding the exact solution to an
> >>>approximation. Benchmarking OTOH is finding an approximation of the exact
> >>Ok, separated out the first part.
> >>
> >>
> >>Enable section_data_rel_ro for ARM support.
> >>
> >>diff --git a/configure b/configure
> >>index ab761c7183..06e3a7b2a8 100755
> >>--- a/configure
> >>+++ b/configure
> >>@@ -5305,6 +5305,7 @@ case $target_os in
> >>          ;;
> >>      openbsd|bitrig)
> >>          disable symver
> >>+        enable section_data_rel_ro
> >>          striptype=""
> >>          SHFLAGS='-shared'
> >>          SLIB_INSTALL_NAME='$(SLIBNAME).$(LIBMAJOR).$(LIBMINOR)'
> >If no arm or openbsd experts reply/review then this is probably ok
> >
> >thx
> >
> 
> This is from our current OpenBSD port / package that I maintain.
> 
> http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/graphics/ffmpeg/patches/patch-configure?rev=1.61&content-type=text/plain&hideattic=1 <http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/graphics/ffmpeg/patches/patch-configure?rev=1.61&content-type=text/plain&hideattic=1>

can you provide a git patch with commit message and author metadata?

thx

[...]
diff mbox series

Patch

diff --git a/configure b/configure
index ab761c7183..9221621bd1 100755
--- a/configure
+++ b/configure
@@ -5303,8 +5303,9 @@  case $target_os in
         oss_outdev_extralibs="-lossaudio"
         enabled gcc || check_ldflags -Wl,-zmuldefs
         ;;
-    openbsd|bitrig)
+    openbsd)
         disable symver
+        enable section_data_rel_ro
         striptype=""
         SHFLAGS='-shared'
         SLIB_INSTALL_NAME='$(SLIBNAME).$(LIBMAJOR).$(LIBMINOR)'