From patchwork Sun Feb 16 19:31:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andriy Gelman X-Patchwork-Id: 17798 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id B03C24483C9 for ; Sun, 16 Feb 2020 21:37:36 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 853F7689BB1; Sun, 16 Feb 2020 21:37:36 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1FBF968809B for ; Sun, 16 Feb 2020 21:37:30 +0200 (EET) Received: by mail-qk1-f194.google.com with SMTP id o28so12916292qkj.9 for ; Sun, 16 Feb 2020 11:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=otCF0O0hinHRWQCmvwoq6Hsdv2oHLvwyIDqEoHSBFUs=; b=LNytUGG2RG2HjD0xzN/YDyiunfQeRA8lLbxGt0Fjfuj+WAJPVctdxWMR2rDJana0yE e+wDllyITxsZkLYcRmSq8361v9h0cdN4yqj2l/WD/7p4/u+LKcKDkUIwxrBKVksSZrSv /LwJVPTCwz/fCU0noiCCRALhA5AQWR4A7DkfFGv82KTLjhga5e1+C8NRGr/dKB6CuWlT f6bDOwLEAy2lLSH0byinelHqiWJUtM6jWjrtVEN4uWhpikUsWChQCHmXJSz/KDfWic5W f5hMvqQAEA3D5K0ELAXS1l5aH2gNmkp20PZKePlFYtIfuG3gHkyMLqOLnrx3A1WgOoK3 TSZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=otCF0O0hinHRWQCmvwoq6Hsdv2oHLvwyIDqEoHSBFUs=; b=a+0icCZU4EUI/z4dYIXQFpI9bruTLuXKTEpxNS2CIfMyjnw2EklQ855YfC54hiFr6u uztSHqJQWQlJxorrV+05/Q6/MyVOplsW/YtiGdFM2gxOBjVQpJo0sVoEPbDKI4h1G5UR 6d33j/gcIaT+S7vthVzaJUpXKcAtTzjQIrvBEX6BXgCz2oft+eOJsfrjSVYN4d3ErfoW rSZ4IHRFfJ+mdyBQZBsJV47chGxK13BbPvnVhuQqL7QgQsaXVkq1Kpj9/HprH4O7dRM6 cRGH3LjSxBPyifyok5OD367B9KIaSc6cCDIhHRvowfTQBQFa3soNWFS1angS3Qv1Zr1F +Btg== X-Gm-Message-State: APjAAAWrD0yMqAo5daiGKkbZIrK0OXfquQEImwYkjsFXk8OmkHoassm0 BRbdDg3qaj21IZodqKtpupOiq5OI X-Google-Smtp-Source: APXvYqyrROI0zkrVHnAHbhSW+puUqP5GWXcvOTaNwruV2cwB9FVU+HMQroNVwOh7pE1jiqrIRgZTqQ== X-Received: by 2002:ac8:7b9a:: with SMTP id p26mr10757722qtu.281.1581881515178; Sun, 16 Feb 2020 11:31:55 -0800 (PST) Received: from localhost.localdomain (c-71-232-27-28.hsd1.ma.comcast.net. [71.232.27.28]) by smtp.gmail.com with ESMTPSA id k5sm7617348qkk.117.2020.02.16.11.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2020 11:31:54 -0800 (PST) From: Andriy Gelman X-Google-Original-From: Andriy Gelman To: ffmpeg-devel@ffmpeg.org Date: Sun, 16 Feb 2020 14:31:42 -0500 Message-Id: <20200216193144.14169-1-andriy.gelman@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 1/3] avcodec/v4l2_m2m_enc: Enable frame level rate control by default X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andriy Gelman Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Andriy Gelman Without this setting, bitrate and qmin/qmax options have no affect on the s5p-mfc hardware encoder. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index 98b9dfc2c0b..94373b3b6e7 100644 --- a/libavcodec/v4l2_m2m_enc.c +++ b/libavcodec/v4l2_m2m_enc.c @@ -177,6 +177,7 @@ static int v4l2_prepare_encoder(V4L2m2mContext *s) /* set ext ctrls */ v4l2_set_ext_ctrl(s, MPEG_CID(HEADER_MODE), MPEG_VIDEO(HEADER_MODE_SEPARATE), "header mode"); v4l2_set_ext_ctrl(s, MPEG_CID(BITRATE) , avctx->bit_rate, "bit rate"); + v4l2_set_ext_ctrl(s, MPEG_CID(FRAME_RC_ENABLE), 1, "frame level rate control"); v4l2_set_ext_ctrl(s, MPEG_CID(GOP_SIZE), avctx->gop_size,"gop size"); av_log(avctx, AV_LOG_DEBUG,