diff mbox series

[FFmpeg-devel] web/generate-doc.sh: fix generate-doc warning for configure ffmpeg part

Message ID 20200313050639.76631-1-lq@chinaffmpeg.org
State New
Headers show
Series [FFmpeg-devel] web/generate-doc.sh: fix generate-doc warning for configure ffmpeg part
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork warning Failed to apply patch

Commit Message

Steven Liu March 13, 2020, 5:06 a.m. UTC
Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
---
 generate-doc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lou Logan March 13, 2020, 5:53 p.m. UTC | #1
On Thu, Mar 12, 2020, at 9:06 PM, Steven Liu wrote:
> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
> ---
>  generate-doc.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/generate-doc.sh b/generate-doc.sh
> index d8d01d3..e316c05 100755
> --- a/generate-doc.sh
> +++ b/generate-doc.sh
> @@ -34,7 +34,7 @@ export FA_ICONS=true
>  
>  rm -rf build-doc
>  mkdir build-doc && cd build-doc
> -$src/configure --enable-gpl --disable-yasm || die "configure failed"
> +$src/configure --enable-gpl --enable-x86asm || die "configure failed"
>  make doc || die "doc not made"
>  cp doc/*.html ../htdocs/ || die "copy failed"

LGTM, but in my opinion the commit title could be more accurate, such
as:

web/generate-doc.sh: use --enable-x86asm instead of --disable-yasm
diff mbox series

Patch

diff --git a/generate-doc.sh b/generate-doc.sh
index d8d01d3..e316c05 100755
--- a/generate-doc.sh
+++ b/generate-doc.sh
@@ -34,7 +34,7 @@  export FA_ICONS=true
 
 rm -rf build-doc
 mkdir build-doc && cd build-doc
-$src/configure --enable-gpl --disable-yasm || die "configure failed"
+$src/configure --enable-gpl --enable-x86asm || die "configure failed"
 make doc || die "doc not made"
 cp doc/*.html ../htdocs/ || die "copy failed"