diff mbox series

[FFmpeg-devel,v2] web/generate-doc.sh: use --enable-x86asm instead of --disable-yasm

Message ID 20200314013626.98712-1-lq@chinaffmpeg.org
State New
Headers show
Series [FFmpeg-devel,v2] web/generate-doc.sh: use --enable-x86asm instead of --disable-yasm
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork warning Failed to apply patch

Commit Message

Steven Liu March 14, 2020, 1:36 a.m. UTC
Reviewed-by: Lou Logan <lou@lrcd.com>
Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
---
 generate-doc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hendrik Leppkes March 14, 2020, 7:08 a.m. UTC | #1
On Sat, Mar 14, 2020 at 2:37 AM Steven Liu <lq@chinaffmpeg.org> wrote:
>
> Reviewed-by: Lou Logan <lou@lrcd.com>
> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
> ---
>  generate-doc.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/generate-doc.sh b/generate-doc.sh
> index d8d01d3..e316c05 100755
> --- a/generate-doc.sh
> +++ b/generate-doc.sh
> @@ -34,7 +34,7 @@ export FA_ICONS=true
>
>  rm -rf build-doc
>  mkdir build-doc && cd build-doc
> -$src/configure --enable-gpl --disable-yasm || die "configure failed"
> +$src/configure --enable-gpl --enable-x86asm || die "configure failed"
>  make doc || die "doc not made"
>  cp doc/*.html ../htdocs/ || die "copy failed"
>

These options do quite the opposite of each other, perhaps then
neither should be used?
Steven Liu March 14, 2020, 7:47 a.m. UTC | #2
> 2020年3月14日 下午3:08,Hendrik Leppkes <h.leppkes@gmail.com> 写道:
> 
> On Sat, Mar 14, 2020 at 2:37 AM Steven Liu <lq@chinaffmpeg.org> wrote:
>> 
>> Reviewed-by: Lou Logan <lou@lrcd.com>
>> Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
>> ---
>> generate-doc.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/generate-doc.sh b/generate-doc.sh
>> index d8d01d3..e316c05 100755
>> --- a/generate-doc.sh
>> +++ b/generate-doc.sh
>> @@ -34,7 +34,7 @@ export FA_ICONS=true
>> 
>> rm -rf build-doc
>> mkdir build-doc && cd build-doc
>> -$src/configure --enable-gpl --disable-yasm || die "configure failed"
>> +$src/configure --enable-gpl --enable-x86asm || die "configure failed"
>> make doc || die "doc not made"
>> cp doc/*.html ../htdocs/ || die "copy failed"
>> 
> 
Before patch output is attached
> These options do quite
Do you mean add --quiet option in this line?

> the opposite of each other, perhaps then
> neither should be used?
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.


Thanks

Steven
diff mbox series

Patch

diff --git a/generate-doc.sh b/generate-doc.sh
index d8d01d3..e316c05 100755
--- a/generate-doc.sh
+++ b/generate-doc.sh
@@ -34,7 +34,7 @@  export FA_ICONS=true
 
 rm -rf build-doc
 mkdir build-doc && cd build-doc
-$src/configure --enable-gpl --disable-yasm || die "configure failed"
+$src/configure --enable-gpl --enable-x86asm || die "configure failed"
 make doc || die "doc not made"
 cp doc/*.html ../htdocs/ || die "copy failed"