From patchwork Mon Mar 16 02:00:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Qian X-Patchwork-Id: 18215 Delivered-To: andriy.gelman@gmail.com Received: by 2002:a0c:ab15:0:0:0:0:0 with SMTP id h21csp679717qvb; Sun, 15 Mar 2020 19:01:08 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvnD92k2vQ/896fwMDC2390s/4J0QzzpMvntuDZ6cswWObO8rNyfnQOWbGHgTv0+7LJaQda X-Received: by 2002:a17:907:104e:: with SMTP id oy14mr21423243ejb.82.1584324068549; Sun, 15 Mar 2020 19:01:08 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q9si11770023edn.38.2020.03.15.19.01.07; Sun, 15 Mar 2020 19:01:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nxp.com header.s=selector2 header.b=Vir9oK08; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23EDD68B411; Mon, 16 Mar 2020 04:01:04 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D31568AE9E for ; Mon, 16 Mar 2020 04:00:56 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=krobenRCi+xOKu9ByBsXu84MCfC2ZFRCLmollPHh3aZed9zOdcbrBBeLZo81kB/ni+m4CVRBUCVCi1IUWkyKSb3p+I6eze7/zkWG5J8Y0YZjeJxdsvBUnyRyOA8Ly9+sevlYtlO1diqKC7McJvU4FEdn9m9OeqoBLQ5p1CzI/id8Q4++nTIAaGo3XMxldpN5OFrUglBJhkTx20rfCzfiYHEBEnuVeo7F5tDDWLIcF8BKeZa5sQAhmFoiMMOz/Q5zurbbMBTu1lYuXuVjpFk+uE7KUNh4Zxj8rx7o4oM5x40bUYuzj7rbfTD0rcKY8mDzhydYwNMn9Tjc1Fagk24LxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qpqmvCzHL4b4W/+tKeK/k4w3fiPt1DKxBDl8q3AeiG8=; b=Yf43vbxXuvE8EwA9l86wck7wm6AjUQyEaj3n7ZWNvCop+WRaSPiwJtS1AniCdDDskaLevX1NO7FSvYOocaPdNuW8fxpJX9o+tsJRDS3XpewUPAKX4tBpvsymxnJg1tJEH1JAvzIDD3FlmEU4Ze1/qR+tFFkaPAnz4+H4DDjQaTrdf1GOBKVKlRpZR5Lci4+8dFCVSRsIPzh35OPn+9FnmqXvhbDaPGtngL4mWvkISCstw89OXTRpKTMWN7ZkgYREJ0e3o9VX4WJS9ZDDoQa+cNmRES6QCWeGnkPB9PR3w42XsdXyzqNYGBQVDePsHqAWCyT4sv4RypjtdQWF97gUkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qpqmvCzHL4b4W/+tKeK/k4w3fiPt1DKxBDl8q3AeiG8=; b=Vir9oK08LFasP2KG3c67LdAkzM3y1YiWPg878itj0TW6hGtu4942h9mtY4Z5ua3mjVA9fZnQtvvqc48bZh7c8yj35ekuCMnbDRliHzx92UEBnKm+lPBeJuMPi0PQvhernpmzjaew1WrgFCkRPPIZu3mbeTubZB20B2BrJN3+oJQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ming.qian@nxp.com; Received: from VE1PR04MB6368.eurprd04.prod.outlook.com (20.179.232.146) by VE1PR04MB6606.eurprd04.prod.outlook.com (20.179.235.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18; Mon, 16 Mar 2020 02:00:55 +0000 Received: from VE1PR04MB6368.eurprd04.prod.outlook.com ([fe80::c962:b871:9b:853]) by VE1PR04MB6368.eurprd04.prod.outlook.com ([fe80::c962:b871:9b:853%7]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 02:00:55 +0000 From: Ming Qian To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Mar 2020 10:00:30 +0800 Message-Id: <20200316020030.27484-1-ming.qian@nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SG2PR03CA0105.apcprd03.prod.outlook.com (2603:1096:4:7c::33) To VE1PR04MB6368.eurprd04.prod.outlook.com (2603:10a6:803:11b::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from NXL53318.am.freescale.net (119.31.174.68) by SG2PR03CA0105.apcprd03.prod.outlook.com (2603:1096:4:7c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.11 via Frontend Transport; Mon, 16 Mar 2020 02:00:53 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.68] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e56c8002-637a-4a3b-df50-08d7c94ddcbf X-MS-TrafficTypeDiagnostic: VE1PR04MB6606: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:415; X-Forefront-PRVS: 03449D5DD1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(199004)(6486002)(86362001)(186003)(2906002)(6666004)(316002)(26005)(5660300002)(6512007)(956004)(66476007)(2616005)(8676002)(6506007)(52116002)(1076003)(66946007)(66556008)(8936002)(44832011)(16526019)(81156014)(36756003)(6916009)(478600001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6606; H:VE1PR04MB6368.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JCHLz33J+Drr9wtKfO0LA93IELXkJe1i900w/ZjMpCxYirdHaLaVCWaPqhl3V3wUv9epKbl87OOWE/xNI1jvcUMHh709KPdMAwSwi2faaUAvdumlPYKrULNbA0Ek/W3meDcX8xKYYmyUkZZSw2MuFvTcl/RCtJQbkjd/9uq+2YBmvtPutdgtuXngaaODVEvBYFLsXAEXx1xMUMPzLINLbYwPKNU2fgOD6F0dk2V3Rvl5YuEffs2iEIbWPF5Lx8m7bfAkDJMs2m013Ds6MkWTkMHTbfVzoOwZ9bHO6FRUrKabzFxo2Mk+qH0EJSSY0k6wphy/dZ1Y4UiPbDB886O6B9Zng7stgrP5k2cuQ5nZVQ5l/Ug+fu9YbZYtfbyyqgPxx9yeCkB1H25g2rlmhlCkuQa/L5dImUygrbLp4cBrHM9Mk0GJovyLGy5YU6ot7uEN X-MS-Exchange-AntiSpam-MessageData: 6ZyP9HipFuWnkL/l2w+3593z1prB/HyIXsvuxh8H+oaG3nwKVmDgy78vgW8HyPXDy5+0+J8SGbDxS6MI2ZVpu4PPELW4maYck29tRsTJhELFEoIcFcGI5AK2GQU8xjE706c3WN8VteQgLmW5rdhqqg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e56c8002-637a-4a3b-df50-08d7c94ddcbf X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2020 02:00:55.2479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l0D2vgqKcrss3EZe+y7QS4mKGcKuEkO7K+PN9CHtIq2gW965jgb3O7ZWsA5cooqysRxGYSg1RmofN4TBb7fqLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6606 Subject: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: fix setting the frame rate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /frlCSHSY+Ga Content-Length: 1930 v4l2 set the frame rate through frame intervals, not set frame rate directly. the frame rate and frame intervals are reciprocal. so in libavdevice/v4l2.c we can see the following code: tpf->numerator = framerate_q.den; tpf->denominator = framerate_q.num; Signed-off-by: Ming Qian --- libavcodec/v4l2_m2m_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index c9f1741bfd..5b954f4435 100644 --- a/libavcodec/v4l2_m2m_enc.c +++ b/libavcodec/v4l2_m2m_enc.c @@ -40,8 +40,8 @@ static inline void v4l2_set_timeperframe(V4L2m2mContext *s, unsigned int num, un struct v4l2_streamparm parm = { 0 }; parm.type = V4L2_TYPE_IS_MULTIPLANAR(s->output.type) ? V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE : V4L2_BUF_TYPE_VIDEO_OUTPUT; - parm.parm.output.timeperframe.denominator = den; - parm.parm.output.timeperframe.numerator = num; + parm.parm.output.timeperframe.denominator = num; + parm.parm.output.timeperframe.numerator = den; if (ioctl(s->fd, VIDIOC_S_PARM, &parm) < 0) av_log(s->avctx, AV_LOG_WARNING, "Failed to set timeperframe");