| Message ID | 20200316105336.16665-1-jacek.tomasiak@gmail.com |
|---|---|
| State | New |
| Delegated to: | andriy |
| Headers | show |
| Series | [FFmpeg-devel] avformat/hls: Use probing parameters for actual stream | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
Hi, Could someone please take a look at this? It's a pretty small fix and it has been sitting in the queue since March. Best Regards, Jacek pon., 16 mar 2020 o 11:54 Jacek Tomasiak <jacek.tomasiak@gmail.com> napisał(a): > HLS input streams ignored CLI parameters which control the probing > process. Each stream was initialized with fresh context and used > the default values for probing. > --- > libavformat/hls.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 1f58e745a7..5954b1d2d9 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -1919,6 +1919,14 @@ static int hls_read_header(AVFormatContext *s) > pls->needed = 1; > pls->parent = s; > > + /* Pass top-level probing parameters to actual stream */ > + pls->ctx->probesize = s->probesize; > + pls->ctx->format_probesize = s->format_probesize; > + pls->ctx->max_analyze_duration = s->max_analyze_duration; > + pls->ctx->fps_probe_size = s->fps_probe_size; > + pls->ctx->max_ts_probe = s->max_ts_probe; > + pls->ctx->max_probe_packets = s->max_probe_packets; > + > /* > * If this is a live stream and this playlist looks like it is > one segment > * behind, try to sync it up so that every substream starts at > the same > -- > 2.16.4 > >
On Mon, Mar 16, 2020 at 7:00 PM Jacek Tomasiak <jacek.tomasiak@gmail.com> wrote: > > HLS input streams ignored CLI parameters which control the probing > process. Each stream was initialized with fresh context and used > the default values for probing. > --- > libavformat/hls.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 1f58e745a7..5954b1d2d9 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c > @@ -1919,6 +1919,14 @@ static int hls_read_header(AVFormatContext *s) > pls->needed = 1; > pls->parent = s; > > + /* Pass top-level probing parameters to actual stream */ > + pls->ctx->probesize = s->probesize; > + pls->ctx->format_probesize = s->format_probesize; > + pls->ctx->max_analyze_duration = s->max_analyze_duration; I think HLS demuxer have enable the probesize/max_analyze_duration > + pls->ctx->fps_probe_size = s->fps_probe_size; > + pls->ctx->max_ts_probe = s->max_ts_probe; > + pls->ctx->max_probe_packets = s->max_probe_packets; > + > /* > * If this is a live stream and this playlist looks like it is one segment > * behind, try to sync it up so that every substream starts at the same > -- > 2.16.4 >
diff --git a/libavformat/hls.c b/libavformat/hls.c index 1f58e745a7..5954b1d2d9 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1919,6 +1919,14 @@ static int hls_read_header(AVFormatContext *s) pls->needed = 1; pls->parent = s; + /* Pass top-level probing parameters to actual stream */ + pls->ctx->probesize = s->probesize; + pls->ctx->format_probesize = s->format_probesize; + pls->ctx->max_analyze_duration = s->max_analyze_duration; + pls->ctx->fps_probe_size = s->fps_probe_size; + pls->ctx->max_ts_probe = s->max_ts_probe; + pls->ctx->max_probe_packets = s->max_probe_packets; + /* * If this is a live stream and this playlist looks like it is one segment * behind, try to sync it up so that every substream starts at the same