| Message ID | 20200318025618.5603-1-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel] fftools/ffmpeg_opt: Fix [u]int64_t specifier string | expand |
| Context | Check | Description |
|---|---|---|
| andriy/ffmpeg-patchwork | success | Make fate finished |
Quoting Andreas Rheinhardt (2020-03-18 03:56:18) > PRId64 and PRIu64 already expand to the complete specifier; adding > another 'd' at the end is wrong and just leads to warnings that say > that only an option like '-frames:v 2d' will be used, although said > option won't be accepted at all ('Expected int64 for frames:v but found > 2d'). > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- Looks ok
On Wed, 18 Mar 2020, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-03-18 03:56:18) >> PRId64 and PRIu64 already expand to the complete specifier; adding >> another 'd' at the end is wrong and just leads to warnings that say >> that only an option like '-frames:v 2d' will be used, although said >> option won't be accepted at all ('Expected int64 for frames:v but found >> 2d'). >> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> >> --- > > Looks ok Thanks, applied. Regards, Marton
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index b1b322c6ef..95001a963f 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -46,8 +46,8 @@ #define SPECIFIER_OPT_FMT_str "%s" #define SPECIFIER_OPT_FMT_i "%i" -#define SPECIFIER_OPT_FMT_i64 "%"PRId64"d" -#define SPECIFIER_OPT_FMT_ui64 "%"PRIu64"d" +#define SPECIFIER_OPT_FMT_i64 "%"PRId64 +#define SPECIFIER_OPT_FMT_ui64 "%"PRIu64 #define SPECIFIER_OPT_FMT_f "%f" #define SPECIFIER_OPT_FMT_dbl "%lf"
PRId64 and PRIu64 already expand to the complete specifier; adding another 'd' at the end is wrong and just leads to warnings that say that only an option like '-frames:v 2d' will be used, although said option won't be accepted at all ('Expected int64 for frames:v but found 2d'). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- fftools/ffmpeg_opt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)