From patchwork Fri Mar 27 16:16:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Ramakrishnan X-Patchwork-Id: 18440 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 68EAC44A902 for ; Fri, 27 Mar 2020 18:16:30 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 48DD468B81A; Fri, 27 Mar 2020 18:16:30 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 837D768B5EB for ; Fri, 27 Mar 2020 18:16:23 +0200 (EET) Received: by mail-pj1-f47.google.com with SMTP id nu11so3975228pjb.1 for ; Fri, 27 Mar 2020 09:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PCzPxyPRYE3RYysbLTFuqzxZR1joAhRrGpQUEJxy6HQ=; b=lk2H+djyy5fT3rjPbPnIdYljSRDiJTiIbGPPSETLIxNF2hl+P3X6pQG/ZSE1iGlwB5 XqKSKOgLT2k74OoKVi6LTV1TIS5GZkP2oPMGlgM2wkPmJvzTIzM8N3EKrUcOPmNxSJce VF0jpB7PfgCUlcKbvo098CrfcgkMVzF2mrhL3ragtE7q+uM7mlIrkJfG/hKLktvm8AL9 1RE9vska262zMmyd54ePTA6sDCkXIzbyNUpOd0ZyMWs1aY3N8opopbLloPyB8tx1aV/4 d3Es1XUiveon22DELMyRpwEgcgpNAIr4JpQpUb3h28GAzvzgbfWpLuZoAB/42TNWEMrI xEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PCzPxyPRYE3RYysbLTFuqzxZR1joAhRrGpQUEJxy6HQ=; b=UJnPYxYDFuNY0FCXkfDaLg3DAUusDuoBLJfnuBDJroIREsYWpl/Bmx5fcznLKlX/hK lscre888mmNOC+n6EnEXJh0ZpaSzv11Zn73yuTVVab8OSkVP3SjVcCGqnNnyD17bxpdo ZaBzr4SjfDQ7VuNoEcS9+SpdNNB0nxtZGZvYPfFUW2WniatblF3AY4tsyieBAgq5uDyz P5DgFjZm3a1Rc85KYrUJA7ga1xh/NHMgCkA80jLO/Wmoceu+DH0nE7MNatpE0EXUGQZg capxXDyVy9vTqH3YXcIAyeYZG7kNyBHnvVa3zrc+gTr0ilH/+hSCLwUZQjo29fqedZd0 UHwg== X-Gm-Message-State: ANhLgQ2Rf/LSRj9Dbh5fV+QyIaTF7ZoE/e6jEKIBV6XDUN30yaRbxeIQ o5+i9WD9KCJiO1T0FhRHz+ffLTy0gXA= X-Google-Smtp-Source: ADFU+vsLt1g1/Z9eMXBMayONEUabCydspyHRugcOf5LDLW2oeV0SVFpeSLCx4t0+s88qrqK3GpGf/w== X-Received: by 2002:a17:90a:25c8:: with SMTP id k66mr200219pje.90.1585325781093; Fri, 27 Mar 2020 09:16:21 -0700 (PDT) Received: from localhost.localdomain ([223.235.255.212]) by smtp.gmail.com with ESMTPSA id q12sm4482316pfs.48.2020.03.27.09.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 09:16:20 -0700 (PDT) From: gautamramk@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Fri, 27 Mar 2020 21:46:02 +0530 Message-Id: <20200327161602.1263-2-gautamramk@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200327161602.1263-1-gautamramk@gmail.com> References: <20200327161602.1263-1-gautamramk@gmail.com> Subject: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/jpeg2000dec.c: Functional changes to support PPT marker X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Gautam Ramakrishnan MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. It allows the PPT marker to be read in jpeg2000_read_main_headers(). --- libavcodec/jpeg2000dec.c | 270 ++++++++++++--------------------------- 1 file changed, 82 insertions(+), 188 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 7236e9b7bb..fbc025449a 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg2000dec.c @@ -1169,179 +1169,6 @@ static int jpeg2000_decode_packet_data(Jpeg2000DecoderContext *s, Jpeg2000Tile * return 0; } -static int jpeg2000_decode_packet(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile, int *tp_index, - Jpeg2000CodingStyle *codsty, - Jpeg2000ResLevel *rlevel, int precno, - int layno, uint8_t *expn, int numgbits) -{ - int bandno, cblkno, ret, nb_code_blocks; - int cwsno; - - if (layno < rlevel->band[0].prec[precno].decoded_layers) - return 0; - rlevel->band[0].prec[precno].decoded_layers = layno + 1; - - if (bytestream2_get_bytes_left(&s->g) == 0 && s->bit_index == 8) { - if (*tp_index < FF_ARRAY_ELEMS(tile->tile_part) - 1) { - s->g = tile->tile_part[++(*tp_index)].tpg; - } - } - - if (bytestream2_peek_be32(&s->g) == JPEG2000_SOP_FIXED_BYTES) - bytestream2_skip(&s->g, JPEG2000_SOP_BYTE_LENGTH); - - if (!(ret = get_bits(s, 1))) { - jpeg2000_flush(s); - return 0; - } else if (ret < 0) - return ret; - - for (bandno = 0; bandno < rlevel->nbands; bandno++) { - Jpeg2000Band *band = rlevel->band + bandno; - Jpeg2000Prec *prec = band->prec + precno; - - if (band->coord[0][0] == band->coord[0][1] || - band->coord[1][0] == band->coord[1][1]) - continue; - nb_code_blocks = prec->nb_codeblocks_height * - prec->nb_codeblocks_width; - for (cblkno = 0; cblkno < nb_code_blocks; cblkno++) { - Jpeg2000Cblk *cblk = prec->cblk + cblkno; - int incl, newpasses, llen; - void *tmp; - - if (cblk->npasses) - incl = get_bits(s, 1); - else - incl = tag_tree_decode(s, prec->cblkincl + cblkno, layno + 1) == layno; - if (!incl) - continue; - else if (incl < 0) - return incl; - - if (!cblk->npasses) { - int v = expn[bandno] + numgbits - 1 - - tag_tree_decode(s, prec->zerobits + cblkno, 100); - if (v < 0 || v > 30) { - av_log(s->avctx, AV_LOG_ERROR, - "nonzerobits %d invalid or unsupported\n", v); - return AVERROR_INVALIDDATA; - } - cblk->nonzerobits = v; - } - if ((newpasses = getnpasses(s)) < 0) - return newpasses; - av_assert2(newpasses > 0); - if (cblk->npasses + newpasses >= JPEG2000_MAX_PASSES) { - avpriv_request_sample(s->avctx, "Too many passes"); - return AVERROR_PATCHWELCOME; - } - if ((llen = getlblockinc(s)) < 0) - return llen; - if (cblk->lblock + llen + av_log2(newpasses) > 16) { - avpriv_request_sample(s->avctx, - "Block with length beyond 16 bits"); - return AVERROR_PATCHWELCOME; - } - - cblk->lblock += llen; - - cblk->nb_lengthinc = 0; - cblk->nb_terminationsinc = 0; - av_free(cblk->lengthinc); - cblk->lengthinc = av_mallocz_array(newpasses , sizeof(*cblk->lengthinc)); - if (!cblk->lengthinc) - return AVERROR(ENOMEM); - tmp = av_realloc_array(cblk->data_start, cblk->nb_terminations + newpasses + 1, sizeof(*cblk->data_start)); - if (!tmp) - return AVERROR(ENOMEM); - cblk->data_start = tmp; - do { - int newpasses1 = 0; - - while (newpasses1 < newpasses) { - newpasses1 ++; - if (needs_termination(codsty->cblk_style, cblk->npasses + newpasses1 - 1)) { - cblk->nb_terminationsinc ++; - break; - } - } - - if ((ret = get_bits(s, av_log2(newpasses1) + cblk->lblock)) < 0) - return ret; - if (ret > cblk->data_allocated) { - size_t new_size = FFMAX(2*cblk->data_allocated, ret); - void *new = av_realloc(cblk->data, new_size); - if (new) { - cblk->data = new; - cblk->data_allocated = new_size; - } - } - if (ret > cblk->data_allocated) { - avpriv_request_sample(s->avctx, - "Block with lengthinc greater than %"SIZE_SPECIFIER"", - cblk->data_allocated); - return AVERROR_PATCHWELCOME; - } - cblk->lengthinc[cblk->nb_lengthinc++] = ret; - cblk->npasses += newpasses1; - newpasses -= newpasses1; - } while(newpasses); - } - } - jpeg2000_flush(s); - - if (codsty->csty & JPEG2000_CSTY_EPH) { - if (bytestream2_peek_be16(&s->g) == JPEG2000_EPH) - bytestream2_skip(&s->g, 2); - else - av_log(s->avctx, AV_LOG_ERROR, "EPH marker not found. instead %X\n", bytestream2_peek_be32(&s->g)); - } - - for (bandno = 0; bandno < rlevel->nbands; bandno++) { - Jpeg2000Band *band = rlevel->band + bandno; - Jpeg2000Prec *prec = band->prec + precno; - - nb_code_blocks = prec->nb_codeblocks_height * prec->nb_codeblocks_width; - for (cblkno = 0; cblkno < nb_code_blocks; cblkno++) { - Jpeg2000Cblk *cblk = prec->cblk + cblkno; - if (!cblk->nb_terminationsinc && !cblk->lengthinc) - continue; - for (cwsno = 0; cwsno < cblk->nb_lengthinc; cwsno ++) { - if (cblk->data_allocated < cblk->length + cblk->lengthinc[cwsno] + 4) { - size_t new_size = FFMAX(2*cblk->data_allocated, cblk->length + cblk->lengthinc[cwsno] + 4); - void *new = av_realloc(cblk->data, new_size); - if (new) { - cblk->data = new; - cblk->data_allocated = new_size; - } - } - if ( bytestream2_get_bytes_left(&s->g) < cblk->lengthinc[cwsno] - || cblk->data_allocated < cblk->length + cblk->lengthinc[cwsno] + 4 - ) { - av_log(s->avctx, AV_LOG_ERROR, - "Block length %"PRIu16" or lengthinc %d is too large, left %d\n", - cblk->length, cblk->lengthinc[cwsno], bytestream2_get_bytes_left(&s->g)); - return AVERROR_INVALIDDATA; - } - - bytestream2_get_bufferu(&s->g, cblk->data + cblk->length, cblk->lengthinc[cwsno]); - cblk->length += cblk->lengthinc[cwsno]; - cblk->lengthinc[cwsno] = 0; - if (cblk->nb_terminationsinc) { - cblk->nb_terminationsinc--; - cblk->nb_terminations++; - cblk->data[cblk->length++] = 0xFF; - cblk->data[cblk->length++] = 0xFF; - cblk->data_start[cblk->nb_terminations] = cblk->length; - } - } - av_freep(&cblk->lengthinc); - } - } - return 0; -} - static int jpeg2000_decode_packets_po_iteration(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile, int RSpoc, int CSpoc, int LYEpoc, int REpoc, int CEpoc, @@ -1366,13 +1193,25 @@ static int jpeg2000_decode_packets_po_iteration(Jpeg2000DecoderContext *s, Jpeg2 Jpeg2000ResLevel *rlevel = tile->comp[compno].reslevel + reslevelno; ok_reslevel = 1; - for (precno = 0; precno < rlevel->num_precincts_x * rlevel->num_precincts_y; precno++) - if ((ret = jpeg2000_decode_packet(s, tile, tp_index, + for (precno = 0; precno < rlevel->num_precincts_x * rlevel->num_precincts_y; precno++) { + int process_data = 1; + if ((ret = jpeg2000_decode_packet_header(s, tile, tp_index, + codsty, rlevel, + precno, layno, + qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), + qntsty->nguardbits, &process_data)) < 0) + return ret; + + if (!process_data) + continue; + + if ((ret = jpeg2000_decode_packet_data(s, tile, tp_index, codsty, rlevel, precno, layno, qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), qntsty->nguardbits)) < 0) return ret; + } } } } @@ -1392,13 +1231,25 @@ static int jpeg2000_decode_packets_po_iteration(Jpeg2000DecoderContext *s, Jpeg2 Jpeg2000ResLevel *rlevel = tile->comp[compno].reslevel + reslevelno; ok_reslevel = 1; - for (precno = 0; precno < rlevel->num_precincts_x * rlevel->num_precincts_y; precno++) - if ((ret = jpeg2000_decode_packet(s, tile, tp_index, + for (precno = 0; precno < rlevel->num_precincts_x * rlevel->num_precincts_y; precno++) { + int process_data = 1; + if ((ret = jpeg2000_decode_packet_header(s, tile, tp_index, + codsty, rlevel, + precno, layno, + qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), + qntsty->nguardbits, &process_data)) < 0) + return ret; + + if (!process_data) + continue; + + if ((ret = jpeg2000_decode_packet_data(s, tile, tp_index, codsty, rlevel, precno, layno, qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), qntsty->nguardbits)) < 0) return ret; + } } } } @@ -1460,7 +1311,19 @@ static int jpeg2000_decode_packets_po_iteration(Jpeg2000DecoderContext *s, Jpeg2 } for (layno = 0; layno < LYEpoc; layno++) { - if ((ret = jpeg2000_decode_packet(s, tile, tp_index, codsty, rlevel, + int process_data = 1; + if ((ret = jpeg2000_decode_packet_header(s, tile, tp_index, + codsty, rlevel, + precno, layno, + qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), + qntsty->nguardbits, &process_data)) < 0) + return ret; + + if (!process_data) + continue; + + if ((ret = jpeg2000_decode_packet_data(s, tile, tp_index, + codsty, rlevel, precno, layno, qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), qntsty->nguardbits)) < 0) @@ -1530,14 +1393,25 @@ static int jpeg2000_decode_packets_po_iteration(Jpeg2000DecoderContext *s, Jpeg2 continue; } - for (layno = 0; layno < LYEpoc; layno++) { - if ((ret = jpeg2000_decode_packet(s, tile, tp_index, - codsty, rlevel, - precno, layno, - qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), - qntsty->nguardbits)) < 0) - return ret; - } + for (layno = 0; layno < LYEpoc; layno++) { + int process_data = 1; + if ((ret = jpeg2000_decode_packet_header(s, tile, tp_index, + codsty, rlevel, + precno, layno, + qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), + qntsty->nguardbits, &process_data)) < 0) + return ret; + + if (!process_data) + continue; + + if ((ret = jpeg2000_decode_packet_data(s, tile, tp_index, + codsty, rlevel, + precno, layno, + qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), + qntsty->nguardbits)) < 0) + return ret; + } } } } @@ -1601,7 +1475,19 @@ static int jpeg2000_decode_packets_po_iteration(Jpeg2000DecoderContext *s, Jpeg2 } for (layno = 0; layno < LYEpoc; layno++) { - if ((ret = jpeg2000_decode_packet(s, tile, tp_index, codsty, rlevel, + int process_data = 1; + if ((ret = jpeg2000_decode_packet_header(s, tile, tp_index, + codsty, rlevel, + precno, layno, + qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), + qntsty->nguardbits, &process_data)) < 0) + return ret; + + if (!process_data) + continue; + + if ((ret = jpeg2000_decode_packet_data(s, tile, tp_index, + codsty, rlevel, precno, layno, qntsty->expn + (reslevelno ? 3 * (reslevelno - 1) + 1 : 0), qntsty->nguardbits)) < 0) @@ -2171,6 +2057,11 @@ static int jpeg2000_read_main_headers(Jpeg2000DecoderContext *s) av_log(s->avctx, AV_LOG_ERROR, "Invalid tpend\n"); return AVERROR_INVALIDDATA; } + + if (tile->has_ppt && tile->tp_idx == 0) { + bytestream2_init(&tile->packed_headers_stream, tile->packed_headers, tile->packed_headers_size); + } + bytestream2_init(&tp->tpg, s->g.buffer, tp->tp_end - s->g.buffer); bytestream2_skip(&s->g, tp->tp_end - s->g.buffer); @@ -2233,6 +2124,10 @@ static int jpeg2000_read_main_headers(Jpeg2000DecoderContext *s) // Packet length, tile-part header ret = get_plt(s, len); break; + case JPEG2000_PPT: + // Packed headers, tile-part header + ret = get_ppt(s, len); + break; default: av_log(s->avctx, AV_LOG_ERROR, "unsupported marker 0x%.4"PRIX16" at pos 0x%X\n", @@ -2262,7 +2157,6 @@ static int jpeg2000_read_bitstream_packets(Jpeg2000DecoderContext *s) if ((ret = init_tile(s, tileno)) < 0) return ret; - s->g = tile->tile_part[0].tpg; if ((ret = jpeg2000_decode_packets(s, tile)) < 0) return ret; }