From patchwork Sat Mar 28 00:17:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 18447 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 50FCE44BC2D for ; Sat, 28 Mar 2020 02:25:26 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3626468B60C; Sat, 28 Mar 2020 02:25:26 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F0F568B3FD for ; Sat, 28 Mar 2020 02:25:20 +0200 (EET) Received: by mail-oi1-f195.google.com with SMTP id k9so10432144oia.8 for ; Fri, 27 Mar 2020 17:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6BTlOvEO0SnIEETlriJJvQXJhMuUrP2+jql/2lsvoXA=; b=P5VP3bBCoWsEfln2vPhFO3zfX7X9Uj7Jl2liQYL1invOTNR+yKIOwWS3VpMexhpeZO VcVqNbvm8ddqiueRlT55ORykyjT/+fqTEFM4vU1c52Eo5LvXYnC02wh32dQclb5oK7eO EPw10G2qeBUS0gChnM23JGkJEictuPsDE2w0gHzYACe7G8kkLhtBTkPdDS16E4oID+nD oXyV/PcPcEzRmucnzQme2u0SYgAgC1qMWNy94Xtn4BLVQyA1Z9L+YlcJeVjJVFE8e3N7 LuFSaS3fwfJvy5hqFhJXGFLehcL32bMH88MuyjDzq9XxJDm/5FYtU7LfN1NantGOhhTR 5PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6BTlOvEO0SnIEETlriJJvQXJhMuUrP2+jql/2lsvoXA=; b=Jd6rF1HHsREOqbfkvn24OXKjVJZD1w3qQCpk6Pzb0O6CjLbKa2tFV7/8wq86tEUmC2 byWXXdr9P7SPpa5uJ8iDJ65/hd16j3U53Z8wyLpikYkdRkYriQPD7QgCMzcoE58wrcS8 UgUdi1zvEnt+BvPy/ymDfMDNGlJ6+YUHazLTcNcHDDzTGA+j90Rg65VxC/7Uy1u+fDjY 1CT+wru2YBZ74lVq+IVc55sIHmojPZGkbKMm4Qr8acYh3yhCqFo0RwBZNkP8m37schaK i5uhYIe63BYTX0N9b/d/wCrIiFZdoT49YOeKspB1SqlObQBDQbN3hbXggcsSFGE+fJcq X/9A== X-Gm-Message-State: ANhLgQ1mZFEa5XQbDAOWKv5LZ4/JZq7wnhgRzRofO2ZOq8+ZPEw7kiSW 29kwNR6bcWLi0yOOl/ZBP33Drr9c X-Google-Smtp-Source: ADFU+vvqiqgBXchEdkugvQ4NcI/fyr2xFlWafQittC0aV1bcsPFmMucIVVGLO0m3FF7MciwiJzyMcQ== X-Received: by 2002:a17:90a:e016:: with SMTP id u22mr2014025pjy.65.1585354664194; Fri, 27 Mar 2020 17:17:44 -0700 (PDT) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id h26sm4950284pfr.134.2020.03.27.17.17.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2020 17:17:43 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 28 Mar 2020 08:17:33 +0800 Message-Id: <20200328001733.695-3-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200328001733.695-1-lance.lmwang@gmail.com> References: <20200325230424.2787-1-lance.lmwang@gmail.com> <20200328001733.695-1-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v2 3/3] avfilter/af_adelay: Check sscanf() return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_adelay.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index c964777..2bb05e7 100644 --- a/libavfilter/af_adelay.c +++ b/libavfilter/af_adelay.c @@ -155,7 +155,10 @@ static int config_input(AVFilterLink *inlink) ret = av_sscanf(arg, "%d%c", &d->delay, &type); if (ret != 2 || type != 'S') { div = type == 's' ? 1.0 : 1000.0; - av_sscanf(arg, "%f", &delay); + if (av_sscanf(arg, "%f", &delay) != 1) { + av_log(ctx, AV_LOG_ERROR, "Invalid syntax.\n"); + return AVERROR(EINVAL); + } d->delay = delay * inlink->sample_rate / div; }