diff mbox series

[FFmpeg-devel] avformat/mxfdec: Correct confusing struct tag

Message ID 20200329040638.7750-1-andreas.rheinhardt@gmail.com
State Accepted
Headers show
Series [FFmpeg-devel] avformat/mxfdec: Correct confusing struct tag
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Andreas Rheinhardt March 29, 2020, 4:06 a.m. UTC
Don't use typedef struct MXFTrack {...} MXFTimecodeComponent, in
particular given the fact that MXFTrack is a type of its own.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavformat/mxfdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul B Mahol March 29, 2020, 11:16 a.m. UTC | #1
lgtm

On 3/29/20, Andreas Rheinhardt <andreas.rheinhardt@gmail.com> wrote:
> Don't use typedef struct MXFTrack {...} MXFTimecodeComponent, in
> particular given the fact that MXFTrack is a type of its own.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  libavformat/mxfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 3374f36a88..fdd0dd2a88 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -131,7 +131,7 @@ typedef struct MXFSequence {
>      uint8_t origin;
>  } MXFSequence;
>
> -typedef struct MXFTrack {
> +typedef struct MXFTimecodeComponent {
>      UID uid;
>      enum MXFMetadataSetType type;
>      int drop_frame;
> --
> 2.20.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Tomas Härdin March 29, 2020, 1:22 p.m. UTC | #2
sön 2020-03-29 klockan 06:06 +0200 skrev Andreas Rheinhardt:
> Don't use typedef struct MXFTrack {...} MXFTimecodeComponent, in
> particular given the fact that MXFTrack is a type of its own.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  libavformat/mxfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 3374f36a88..fdd0dd2a88 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -131,7 +131,7 @@ typedef struct MXFSequence {
>      uint8_t origin;
>  } MXFSequence;
>  
> -typedef struct MXFTrack {
> +typedef struct MXFTimecodeComponent {
>      UID uid;
>      enum MXFMetadataSetType type;
>      int drop_frame;

I noticed this as well, just the other day. LGTM

/Tomas
diff mbox series

Patch

diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 3374f36a88..fdd0dd2a88 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -131,7 +131,7 @@  typedef struct MXFSequence {
     uint8_t origin;
 } MXFSequence;
 
-typedef struct MXFTrack {
+typedef struct MXFTimecodeComponent {
     UID uid;
     enum MXFMetadataSetType type;
     int drop_frame;