| Message ID | 20200412224537.30419-1-cus@passwd.hu |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,v2] avutil/log: update text requesting samples | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus@passwd.hu>: > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavutil/log.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/log.c b/libavutil/log.c > index 8d4945249e..965dbca5e1 100644 > --- a/libavutil/log.c > +++ b/libavutil/log.c > @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, > "occurs, it means that your file has a feature which has not " > "been implemented.\n"); > if (sample) > - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " > - "of this file to ftp://upload.ffmpeg.org/incoming/ " > - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); > + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " > + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " > + "of this file to https://streams.videolan.org/upload/\n"); Uploading a sample is of course much more important than sending an email, so this makes the patch significantly worse imo. Carl Eugen
On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus@passwd.hu>: >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> --- >> libavutil/log.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/libavutil/log.c b/libavutil/log.c >> index 8d4945249e..965dbca5e1 100644 >> --- a/libavutil/log.c >> +++ b/libavutil/log.c >> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, >> "occurs, it means that your file has a feature which has not " >> "been implemented.\n"); >> if (sample) >> - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " >> - "of this file to ftp://upload.ffmpeg.org/incoming/ " >> - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); >> + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " >> + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " >> + "of this file to https://streams.videolan.org/upload/\n"); > > Uploading a sample is of course much more important than sending an email, > so this makes the patch significantly worse imo. You wrote that we typically ask for samples we already have. So why aks for uploading them first? Regards, Marton
Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint <cus@passwd.hu>: > > > > On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > > > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus@passwd.hu>: > >> > >> Signed-off-by: Marton Balint <cus@passwd.hu> > >> --- > >> libavutil/log.c | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/libavutil/log.c b/libavutil/log.c > >> index 8d4945249e..965dbca5e1 100644 > >> --- a/libavutil/log.c > >> +++ b/libavutil/log.c > >> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, > >> "occurs, it means that your file has a feature which has not " > >> "been implemented.\n"); > >> if (sample) > >> - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " > >> - "of this file to ftp://upload.ffmpeg.org/incoming/ " > >> - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); > >> + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " > >> + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " > >> + "of this file to https://streams.videolan.org/upload/\n"); > > > > Uploading a sample is of course much more important than sending an email, > > so this makes the patch significantly worse imo. > > You wrote that we typically ask for samples we already have. So why > aks for uploading them first? Even if we already have 99% of such samples (we certainly don't), I would consider getting the remaining 1% of highest importance. Carl Eugen
On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint <cus@passwd.hu>: >> >> >> >> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: >> >> > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus@passwd.hu>: >> >> >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> >> --- >> >> libavutil/log.c | 6 +++--- >> >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> >> >> diff --git a/libavutil/log.c b/libavutil/log.c >> >> index 8d4945249e..965dbca5e1 100644 >> >> --- a/libavutil/log.c >> >> +++ b/libavutil/log.c >> >> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, >> >> "occurs, it means that your file has a feature which has not " >> >> "been implemented.\n"); >> >> if (sample) >> >> - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " >> >> - "of this file to ftp://upload.ffmpeg.org/incoming/ " >> >> - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); >> >> + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " >> >> + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " >> >> + "of this file to https://streams.videolan.org/upload/\n"); >> > >> > Uploading a sample is of course much more important than sending an email, >> > so this makes the patch significantly worse imo. >> >> You wrote that we typically ask for samples we already have. So why >> aks for uploading them first? > > Even if we already have 99% of such samples (we certainly don't), I > would consider getting the remaining 1% of highest importance. So you want to keep the text as is and only change ftp://upload.ffmpeg.org/incoming/ to https://streams.videolan.org/upload/ right? Thanks, Marton
On Mon, 13 Apr 2020, Marton Balint wrote: > > > On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > >> Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint <cus@passwd.hu>: >>> >>> >>> >>> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: >>> >>> > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint > <cus@passwd.hu>: >>> >> >>> >> Signed-off-by: Marton Balint <cus@passwd.hu> >>> >> --- >>> >> libavutil/log.c | 6 +++--- >>> >> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >> >>> >> diff --git a/libavutil/log.c b/libavutil/log.c >>> >> index 8d4945249e..965dbca5e1 100644 >>> >> --- a/libavutil/log.c >>> >> +++ b/libavutil/log.c >>> >> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void > *avc, const char *msg, >>> >> "occurs, it means that your file has a feature which has > not " >>> >> "been implemented.\n"); >>> >> if (sample) >>> >> - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a > sample " >>> >> - "of this file to ftp://upload.ffmpeg.org/incoming/ " >>> >> - "and contact the ffmpeg-devel mailing list. > (ffmpeg-devel@ffmpeg.org)\n"); >>> >> + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " >>> >> + "ffmpeg-devel@ffmpeg.org and if requested upload a > sample " >>> >> + "of this file to > https://streams.videolan.org/upload/\n"); >>> > >>> > Uploading a sample is of course much more important than sending an > email, >>> > so this makes the patch significantly worse imo. >>> >>> You wrote that we typically ask for samples we already have. So why >>> aks for uploading them first? >> >> Even if we already have 99% of such samples (we certainly don't), I >> would consider getting the remaining 1% of highest importance. > > So you want to keep the text as is and only change > ftp://upload.ffmpeg.org/incoming/ to https://streams.videolan.org/upload/ > right? Right? If not, then please propose alternate text. Thanks, Marton
Am Mo., 13. Apr. 2020 um 11:03 Uhr schrieb Marton Balint <cus@passwd.hu>: > > > > On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > > > Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint <cus@passwd.hu>: > >> > >> > >> > >> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > >> > >> > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus@passwd.hu>: > >> >> > >> >> Signed-off-by: Marton Balint <cus@passwd.hu> > >> >> --- > >> >> libavutil/log.c | 6 +++--- > >> >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> >> > >> >> diff --git a/libavutil/log.c b/libavutil/log.c > >> >> index 8d4945249e..965dbca5e1 100644 > >> >> --- a/libavutil/log.c > >> >> +++ b/libavutil/log.c > >> >> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, > >> >> "occurs, it means that your file has a feature which has not " > >> >> "been implemented.\n"); > >> >> if (sample) > >> >> - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " > >> >> - "of this file to ftp://upload.ffmpeg.org/incoming/ " > >> >> - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); > >> >> + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " > >> >> + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " > >> >> + "of this file to https://streams.videolan.org/upload/\n"); > >> > > >> > Uploading a sample is of course much more important than sending an email, > >> > so this makes the patch significantly worse imo. > >> > >> You wrote that we typically ask for samples we already have. So why > >> aks for uploading them first? > > > > Even if we already have 99% of such samples (we certainly don't), I > > would consider getting the remaining 1% of highest importance. > > So you want to keep the text as is and only change > ftp://upload.ffmpeg.org/incoming/ to https://streams.videolan.org/upload/ > right? Yes, please. Sorry for missing your mail. Carl Eugen
On Thu, 16 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 11:03 Uhr schrieb Marton Balint <cus@passwd.hu>: >> >> >> >> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: >> >> > Am Mo., 13. Apr. 2020 um 02:19 Uhr schrieb Marton Balint <cus@passwd.hu>: >> >> >> >> >> >> >> >> On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: >> >> >> >> > Am Mo., 13. Apr. 2020 um 00:45 Uhr schrieb Marton Balint <cus@passwd.hu>: >> >> >> >> >> >> Signed-off-by: Marton Balint <cus@passwd.hu> >> >> >> --- >> >> >> libavutil/log.c | 6 +++--- >> >> >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> >> >> >> >> diff --git a/libavutil/log.c b/libavutil/log.c >> >> >> index 8d4945249e..965dbca5e1 100644 >> >> >> --- a/libavutil/log.c >> >> >> +++ b/libavutil/log.c >> >> >> @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, >> >> >> "occurs, it means that your file has a feature which has not " >> >> >> "been implemented.\n"); >> >> >> if (sample) >> >> >> - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " >> >> >> - "of this file to ftp://upload.ffmpeg.org/incoming/ " >> >> >> - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); >> >> >> + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " >> >> >> + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " >> >> >> + "of this file to https://streams.videolan.org/upload/\n"); >> >> > >> >> > Uploading a sample is of course much more important than sending an email, >> >> > so this makes the patch significantly worse imo. >> >> >> >> You wrote that we typically ask for samples we already have. So why >> >> aks for uploading them first? >> > >> > Even if we already have 99% of such samples (we certainly don't), I >> > would consider getting the remaining 1% of highest importance. >> >> So you want to keep the text as is and only change >> ftp://upload.ffmpeg.org/incoming/ to https://streams.videolan.org/upload/ >> right? > > Yes, please. Ok, pushed the patch changing that text only. Thanks, Marton
diff --git a/libavutil/log.c b/libavutil/log.c index 8d4945249e..965dbca5e1 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -466,9 +466,9 @@ static void missing_feature_sample(int sample, void *avc, const char *msg, "occurs, it means that your file has a feature which has not " "been implemented.\n"); if (sample) - av_log(avc, AV_LOG_WARNING, "If you want to help, upload a sample " - "of this file to ftp://upload.ffmpeg.org/incoming/ " - "and contact the ffmpeg-devel mailing list. (ffmpeg-devel@ffmpeg.org)\n"); + av_log(avc, AV_LOG_WARNING, "If you want to help, contact " + "ffmpeg-devel@ffmpeg.org and if requested upload a sample " + "of this file to https://streams.videolan.org/upload/\n"); } void avpriv_request_sample(void *avc, const char *msg, ...)
Signed-off-by: Marton Balint <cus@passwd.hu> --- libavutil/log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)