diff mbox series

[FFmpeg-devel,4/4] avformat/matroskadec: Remove redundant setting of chapter titles

Message ID 20200413221156.20179-4-andreas.rheinhardt@gmail.com
State Accepted
Commit 3059b7746aa996d81c2dfd075f7a23efb499d7d9
Headers show
Series [FFmpeg-devel,1/4] fate: Fix dependencies for ffprobe tests with external samples | expand


Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Andreas Rheinhardt April 13, 2020, 10:11 p.m. UTC
Chapter titles are added to the chapter's metadata since 6cb6e159,
yet since 012867f0 (the predecessor of) avpriv_new_chapter() already
adds the title to the chapter's metadata. So setting it again in
matroskadec.c is redundant and expensive.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
 libavformat/matroskadec.c | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series


diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index c699ce66b8..761d8b3743 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -2933,10 +2933,6 @@  static int matroska_read_header(AVFormatContext *s)
                                    (AVRational) { 1, 1000000000 },
                                    chapters[i].start, chapters[i].end,
-            if (chapters[i].chapter) {
-                av_dict_set(&chapters[i].chapter->metadata,
-                            "title", chapters[i].title, 0);
-            }
             max_start = chapters[i].start;