diff mbox series

[FFmpeg-devel,v2] avcodec/bsf: simplify the code

Message ID 20200418041716.7436-1-lance.lmwang@gmail.com
State Accepted
Commit 56b9130fff1ab71f166995bda7583a83e86d2467
Headers show
Series [FFmpeg-devel,v2] avcodec/bsf: simplify the code | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Lance Wang April 18, 2020, 4:17 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavcodec/bsf.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Marton Balint April 25, 2020, 6:44 p.m. UTC | #1 
On Sat, 18 Apr 2020, lance.lmwang@gmail.com wrote:

> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavcodec/bsf.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
> index b9fc771..3cacbd4 100644
> --- a/libavcodec/bsf.c
> +++ b/libavcodec/bsf.c
> @@ -534,11 +534,7 @@ int av_bsf_list_parse_str(const char *str, AVBSFContext **bsf_lst)
>         goto end;
>     }
> 
> -    while (1) {
> -        bsf_str = av_strtok(buf, ",", &saveptr);
> -        if (!bsf_str)
> -            break;
> -
> +    while (bsf_str = av_strtok(buf, ",", &saveptr)) {
>         ret = bsf_parse_single(bsf_str, lst);
>         if (ret < 0)
>             goto end;

Thanks, applied.

Regards,
Marton
diff mbox series

Patch

diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c
index b9fc771..3cacbd4 100644
--- a/libavcodec/bsf.c
+++ b/libavcodec/bsf.c
@@ -534,11 +534,7 @@  int av_bsf_list_parse_str(const char *str, AVBSFContext **bsf_lst)
         goto end;
     }
 
-    while (1) {
-        bsf_str = av_strtok(buf, ",", &saveptr);
-        if (!bsf_str)
-            break;
-
+    while (bsf_str = av_strtok(buf, ",", &saveptr)) {
         ret = bsf_parse_single(bsf_str, lst);
         if (ret < 0)
             goto end;