From patchwork Sat Apr 18 11:59:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul B Mahol X-Patchwork-Id: 19051 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 5439944BA56 for ; Sat, 18 Apr 2020 15:04:57 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2D29F68BFA6; Sat, 18 Apr 2020 15:04:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8ADDE68BF9D for ; Sat, 18 Apr 2020 15:04:50 +0300 (EEST) Received: by mail-wm1-f66.google.com with SMTP id y24so5692016wma.4 for ; Sat, 18 Apr 2020 05:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=M2VYX7luywcwvlGxcnQ+Ya574xCocgJz6vNTL2PTxEg=; b=gInVadG+JgVnC4xhNEvVHTRRRa3lSSQql6NV62XU8dnlu2USEHO7Q+dgfM+iApr8yC 9y6q1g5qOizWbgUP/sS+tmO8IrZRgIou1MR/XhoA+gfTxfzuv5U9u+rgS+oZSe5AF0sd 58lab3gUDNUZagg8fDNQRJMTlx7q0tUnty2JjpMM49TijQaYtgpnTd03pNI1jRWmoHZi MTY7Ib+cgudtxCPCZlt+p+tizex2N0uQt1JZ7PFCwa1PStYwpNZKGcunpdXELRnLHM1C YXjjyYmr2VJ/6bNu/4v3fSlBooIWQGfjD/CJWJJvIHxya+rAURFo8y8oREUCBnAm36+J MkrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=M2VYX7luywcwvlGxcnQ+Ya574xCocgJz6vNTL2PTxEg=; b=p87DhwbnVi0MHsIxSHbON2+TmotNcCDQS6GCf9x2iZVhZlB5sGs77KqIUNa0F07VQE kapYU5mJ2Gb7h8BbrfYfyF+TSUp4DhFcFM3kz6jDB+f/aD0QubMWG8ZKbE+QGSR/zcvP cGitwjfC7I5hKfllo/0rZZdudGhrZ00VKI8Kbi+xOi43GLHAWqhUhVRJoWCTgxmEPxWo 53YJQW2Li2z2KBkYS2TCCyWYSvOYTfT7Yp56OC8si7LwrNEm1Mx7wr2OCRV6ypxYofdV LeKau23mpVc6Z6EwRCEukIxLqMn06XbKAs89SOqxzLOE3vP21oL+QTPdGsVjHzcIpNz2 zuWA== X-Gm-Message-State: AGi0Puaxt2pk9+/UBEbb7OJu1/WYB77uJdwezOjdVLuD+6OmoN22CTRf 8aR/R8K2HxhFvnyQuHER+hqRwsq9 X-Google-Smtp-Source: APiQypJfjEc5vJ1vAI+/qsk8Ksx/kpkk5BEPbnSCT+sTlI5OkiK5QcDha993CsUiBeUdWS8UynEoAw== X-Received: by 2002:a1c:7d4b:: with SMTP id y72mr8108715wmc.11.1587211182160; Sat, 18 Apr 2020 04:59:42 -0700 (PDT) Received: from localhost.localdomain ([94.250.184.60]) by smtp.gmail.com with ESMTPSA id t8sm35460929wrq.88.2020.04.18.04.59.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2020 04:59:41 -0700 (PDT) From: Paul B Mahol To: ffmpeg-devel@ffmpeg.org Date: Sat, 18 Apr 2020 13:59:31 +0200 Message-Id: <20200418115931.9277-2-onemda@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200418115931.9277-1-onemda@gmail.com> References: <20200418115931.9277-1-onemda@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] avfilter/avf_showspectrumpic: switch to internal queue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes filtering audio with more than 1.5h length. Signed-off-by: Paul B Mahol --- libavfilter/avf_showspectrum.c | 119 ++++++++++++++++----------------- 1 file changed, 59 insertions(+), 60 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index a4dd7b7879..9425c4ded6 100644 --- a/libavfilter/avf_showspectrum.c +++ b/libavfilter/avf_showspectrum.c @@ -1606,91 +1606,90 @@ static const AVOption showspectrumpic_options[] = { AVFILTER_DEFINE_CLASS(showspectrumpic); -static int showspectrumpic_request_frame(AVFilterLink *outlink) +static int showspectrumpic_request_frame(AVFilterLink *outlink, int64_t samples) { AVFilterContext *ctx = outlink->src; ShowSpectrumContext *s = ctx->priv; AVFilterLink *inlink = ctx->inputs[0]; - int ret, samples; + int consumed = 0; + int x = 0, sz = s->orientation == VERTICAL ? s->w : s->h; + int ret, ch, spf, spb; + AVFrame *fin = NULL; - ret = ff_request_frame(inlink); - samples = av_audio_fifo_size(s->fifo); - if (ret == AVERROR_EOF && s->outpicref && samples > 0) { - int consumed = 0; - int x = 0, sz = s->orientation == VERTICAL ? s->w : s->h; - int ch, spf, spb; - AVFrame *fin; + spf = s->win_size * (samples / ((s->win_size * sz) * ceil(samples / (float)(s->win_size * sz)))); + spf = FFMAX(1, spf); - spf = s->win_size * (samples / ((s->win_size * sz) * ceil(samples / (float)(s->win_size * sz)))); - spf = FFMAX(1, spf); + spb = (samples / (spf * sz)) * spf; - spb = (samples / (spf * sz)) * spf; - - fin = ff_get_audio_buffer(inlink, s->win_size); - if (!fin) - return AVERROR(ENOMEM); - - while (x < sz) { - ret = av_audio_fifo_peek(s->fifo, (void **)fin->extended_data, s->win_size); - if (ret < 0) { - av_frame_free(&fin); - return ret; - } - - av_audio_fifo_drain(s->fifo, spf); - - if (ret < s->win_size) { - for (ch = 0; ch < s->nb_display_channels; ch++) { - memset(fin->extended_data[ch] + ret * sizeof(float), 0, - (s->win_size - ret) * sizeof(float)); - } - } - - ctx->internal->execute(ctx, run_channel_fft, fin, NULL, s->nb_display_channels); - acalc_magnitudes(s); - - consumed += spf; - if (consumed >= spb) { - int h = s->orientation == VERTICAL ? s->h : s->w; + while (x < sz) { + ret = ff_inlink_peek_samples(inlink, s->win_size, &fin); + if (ret < 0) + return ret; + if (ret == 0) + break; - scale_magnitudes(s, 1.f / (consumed / spf)); - plot_spectrum_column(inlink, fin); - consumed = 0; - x++; - for (ch = 0; ch < s->nb_display_channels; ch++) - memset(s->magnitudes[ch], 0, h * sizeof(float)); - } + ctx->internal->execute(ctx, run_channel_fft, fin, NULL, s->nb_display_channels); + acalc_magnitudes(s); + + consumed += spf; + if (consumed >= spb) { + int h = s->orientation == VERTICAL ? s->h : s->w; + + scale_magnitudes(s, 1.f / (consumed / spf)); + plot_spectrum_column(inlink, fin); + consumed = 0; + x++; + for (ch = 0; ch < s->nb_display_channels; ch++) + memset(s->magnitudes[ch], 0, h * sizeof(float)); } - av_frame_free(&fin); - s->outpicref->pts = 0; + ff_inlink_skip_samples(inlink, spf); + } - if (s->legend) - draw_legend(ctx, samples); + s->outpicref->pts = 0; - ret = ff_filter_frame(outlink, s->outpicref); - s->outpicref = NULL; - } + if (s->legend) + draw_legend(ctx, samples); + + ret = ff_filter_frame(outlink, s->outpicref); + s->outpicref = NULL; return ret; } -static int showspectrumpic_filter_frame(AVFilterLink *inlink, AVFrame *insamples) +static int showspectrumpic_activate(AVFilterContext *ctx) { - AVFilterContext *ctx = inlink->dst; + AVFilterLink *inlink = ctx->inputs[0]; + AVFilterLink *outlink = ctx->outputs[0]; ShowSpectrumContext *s = ctx->priv; int ret; - ret = av_audio_fifo_write(s->fifo, (void **)insamples->extended_data, insamples->nb_samples); - av_frame_free(&insamples); - return ret; + FF_FILTER_FORWARD_STATUS_BACK(outlink, inlink); + + if (ff_outlink_get_status(inlink) == AVERROR_EOF && + s->outpicref) { + int64_t samples = 0; + + for (int i = 0; i < ff_inlink_queued_frames(inlink); i++) { + AVFrame *frame = ff_inlink_peek_frame(inlink, i); + + samples += frame->nb_samples; + } + + ret = showspectrumpic_request_frame(outlink, samples); + ff_outlink_set_status(outlink, AVERROR_EOF, 0); + return ret; + } + + FF_FILTER_FORWARD_WANTED(outlink, inlink); + + return FFERROR_NOT_READY; } static const AVFilterPad showspectrumpic_inputs[] = { { .name = "default", .type = AVMEDIA_TYPE_AUDIO, - .filter_frame = showspectrumpic_filter_frame, }, { NULL } }; @@ -1700,7 +1699,6 @@ static const AVFilterPad showspectrumpic_outputs[] = { .name = "default", .type = AVMEDIA_TYPE_VIDEO, .config_props = config_output, - .request_frame = showspectrumpic_request_frame, }, { NULL } }; @@ -1711,6 +1709,7 @@ AVFilter ff_avf_showspectrumpic = { .uninit = uninit, .query_formats = query_formats, .priv_size = sizeof(ShowSpectrumContext), + .activate = showspectrumpic_activate, .inputs = showspectrumpic_inputs, .outputs = showspectrumpic_outputs, .priv_class = &showspectrumpic_class,