From patchwork Tue Apr 21 14:54:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Liu X-Patchwork-Id: 19138 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id B48E2448E2C for ; Tue, 21 Apr 2020 17:55:04 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 922DB68BA00; Tue, 21 Apr 2020 17:55:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E82C68B91E for ; Tue, 21 Apr 2020 17:54:57 +0300 (EEST) X-QQ-mid: bizesmtp3t1587480881tcr25pek6 Received: from localhost (unknown [221.216.232.170]) by esmtp6.qq.com (ESMTP) with id ; Tue, 21 Apr 2020 22:54:41 +0800 (CST) X-QQ-SSF: 01100000002000K0ZUF0000A0000000 X-QQ-FEAT: JlEBx5H+23ccL2etOz9yykOr1j9V6yXoLSCQKrG0zwxJtQhq1G+qpSO/F8WXo AIFRvrife0uOVsSgmA/Qeh8uy620PDFZkEJMbZ/Q5J9+LoYHR/PVus4T1HO9FYl6TvkRPRc utmRn4oualyAB3owhqwRCfeihyktg895+LdhQpdjb1tASdF7AbCeJovBikauwMEGCKbSI9L 330zaOJ8Tz1qOjIwrQ/yuXlxWAUdUk7tnzMd8DkN71AQZt+3ifW7TZZzMAcXRTwCH//MdL0 PwXseWNTvrox+aWGae51zCxZOu4i5lBW0Ma/SUTr1pGOtJUlzA6YJTC97ELAH/YfWg7FErj N67sbUaYRAxgCU5BJU= X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Tue, 21 Apr 2020 22:54:39 +0800 Message-Id: <20200421145439.4229-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: [FFmpeg-devel] [PATCH v2] avfilter/vf_v360: adjustment out_pad and in_pad maximum value to 1/10 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu , Paul B Mahol Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Because not every user know about in_pad and out_pad reasonable value range so maybe try to set 1.0, but setting 1.0 is so hugh to get an fatal error. Suggested-by: Paul B Mahol Signed-off-by: Steven Liu --- doc/filters.texi | 1 + libavfilter/vf_v360.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 80c33f5edb..740aba0642 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -18956,6 +18956,7 @@ No padding. @end table Default value is @b{@samp{0}}. +Maximum value is @b{@samp{0.1}}. @item fin_pad @item fout_pad diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index ebc281dfca..e5b75c7226 100644 --- a/libavfilter/vf_v360.c +++ b/libavfilter/vf_v360.c @@ -133,8 +133,8 @@ static const AVOption v360_options[] = { {"out_forder", "output cubemap face order", OFFSET(out_forder), AV_OPT_TYPE_STRING, {.str="rludfb"}, 0, NB_DIRECTIONS-1, FLAGS, "out_forder"}, { "in_frot", "input cubemap face rotation", OFFSET(in_frot), AV_OPT_TYPE_STRING, {.str="000000"}, 0, NB_DIRECTIONS-1, FLAGS, "in_frot"}, { "out_frot", "output cubemap face rotation",OFFSET(out_frot), AV_OPT_TYPE_STRING, {.str="000000"}, 0, NB_DIRECTIONS-1, FLAGS, "out_frot"}, - { "in_pad", "percent input cubemap pads", OFFSET(in_pad), AV_OPT_TYPE_FLOAT, {.dbl=0.f}, 0.f, 1.f,TFLAGS, "in_pad"}, - { "out_pad", "percent output cubemap pads", OFFSET(out_pad), AV_OPT_TYPE_FLOAT, {.dbl=0.f}, 0.f, 1.f,TFLAGS, "out_pad"}, + { "in_pad", "percent input cubemap pads", OFFSET(in_pad), AV_OPT_TYPE_FLOAT, {.dbl=0.f}, 0.f, 0.1,TFLAGS, "in_pad"}, + { "out_pad", "percent output cubemap pads", OFFSET(out_pad), AV_OPT_TYPE_FLOAT, {.dbl=0.f}, 0.f, 0.1,TFLAGS, "out_pad"}, { "fin_pad", "fixed input cubemap pads", OFFSET(fin_pad), AV_OPT_TYPE_INT, {.i64=0}, 0, 100,TFLAGS, "fin_pad"}, { "fout_pad", "fixed output cubemap pads", OFFSET(fout_pad), AV_OPT_TYPE_INT, {.i64=0}, 0, 100,TFLAGS, "fout_pad"}, { "yaw", "yaw rotation", OFFSET(yaw), AV_OPT_TYPE_FLOAT, {.dbl=0.f}, -180.f, 180.f,TFLAGS, "yaw"},