From patchwork Thu Apr 30 19:00:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lou Logan X-Patchwork-Id: 19406 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A52E344A753 for ; Thu, 30 Apr 2020 22:00:39 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7652268C785; Thu, 30 Apr 2020 22:00:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9404A68BA38 for ; Thu, 30 Apr 2020 22:00:32 +0300 (EEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 441CC5C0131; Thu, 30 Apr 2020 15:00:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 30 Apr 2020 15:00:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lrcd.com; h=from :to:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=BXxhJk/G3+EdtVoGkcMiGL7aAG tiWgcc3biWyjnTYhg=; b=V7cLFpG8lAakgslhKW2+vggFlzMDgz1xihzR+PGfTL 9lecjp/DH3LdrgUbbJ4VuXbQBewuo9u/tl77VpBIIL7Ns0VsvRGU0gvcmEcIgnYG iT5UzbETR60XwMak94fpeK6SKx6pUiLkX67BBnYyV5AahFty6ySQlt4gwa/Tc94C Yk2wRqK7MwyZk7BWw/zSjMPWUAQ3EMJly1+mmhPctII+knzV8Pv5PaYR3eVYMWFu i+6MwbXRi3iUnv+uncKMZ1mxAgp0wce1j/caEJQn/uoeNYpb/99UCKUfFi1vWBcd OA/Pavmt9Rwk1oJsdtBlW/zjizeu4LaRvr6S8epp7Blg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BXxhJk/G3+EdtVoGk cMiGL7aAGtiWgcc3biWyjnTYhg=; b=d1KxWI9H/I/y6LjgfNnnlMzcx5c790bD2 3LtmuZhmARTe6kGQE6R1CEARi/WBaSCBx0ZKVawZ4X9OfZl80y53OFPLlRi/jhS0 idGLaWlmzWx0o40/BZG8Sn6iR8tZ4Iq6pCBKpysV15QlzXvAadR7JdceyLR8WzOg 7ir3UHMVH83THCFcoeeVzh4dLtTpQlYK+MjX643nEVF74RSeXUMuZ+wEG68irEf8 lWf5B12a4/1itcuWlwBLj/D7vN8aA+ugRgt0BI2ERsIZP9VWjrCCJFXQzyq30cn7 KEwFDChwwl4QV7QANyIpi4yB8LPpkRr1EuabWHEwrUULsx9KmNqkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieehgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfhouhcunfhoghgrnhcuoehlohhusehlrhgtugdrtghomheqnecu ggftrfgrthhtvghrnhepudeikefhhfdujeetleduffekgfekleehtdefueffheetfeeltd duudffkefgiedunecuffhomhgrihhnpehhhigurhhoghgvnhgruhgurdhiohenucfkphep vdegrddvfeejrddvjedrvdehvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehlohhusehlrhgtugdrtghomh X-ME-Proxy: Received: from localhost (252-27-237-24.gci.net [24.237.27.252]) by mail.messagingengine.com (Postfix) with ESMTPA id 95AAF3065F35 for ; Thu, 30 Apr 2020 15:00:30 -0400 (EDT) From: Lou Logan To: ffmpeg-devel@ffmpeg.org Date: Thu, 30 Apr 2020 11:00:27 -0800 Message-Id: <20200430190027.17905-1-lou@lrcd.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] doc/encoders: remove ffaac>fdk-aac claim X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Lou Logan --- After this claim was made in e34e3619a2b kamedo2 did in-depth ABX testing comparing these encoders: https://hydrogenaud.io/index.php?topic=111085.0 Result: FFmpeg AAC wasn't as good as libfdk_aac on average. I know some things have changed since then, "use the fast coder as the default" (fcb681ac) for example, so maybe the situation is different now. However, I am unaware of any recent comparison. So without any substantiation we shouldn't make such a blantant claim. --- doc/encoders.texi | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 18bfe8f2eb..f987e88f30 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -30,11 +30,7 @@ follows. Advanced Audio Coding (AAC) encoder. -This encoder is the default AAC encoder, natively implemented into FFmpeg. Its -quality is on par or better than libfdk_aac at the default bitrate of 128kbps. -This encoder also implements more options, profiles and samplerates than -other encoders (with only the AAC-HE profile pending to be implemented) so this -encoder has become the default and is the recommended choice. +This encoder is the default AAC encoder, natively implemented into FFmpeg. @subsection Options