diff mbox series

[FFmpeg-devel,17/26] avformat/srtdec: Fix memleak upon read header failure

Message ID 20200614223656.21338-17-andreas.rheinhardt@gmail.com
State Accepted
Commit c70409957c7332971f0e147729d769f6d2f95390
Headers show
Series [FFmpeg-devel,01/26] avformat/matroskadec: Move AVBufferRef instead of copying, fix memleak | expand


Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Andreas Rheinhardt June 14, 2020, 10:36 p.m. UTC
The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
 libavformat/srtdec.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/libavformat/srtdec.c b/libavformat/srtdec.c
index 40d324b44d..d6ff00ba6d 100644
--- a/libavformat/srtdec.c
+++ b/libavformat/srtdec.c
@@ -207,6 +207,8 @@  static int srt_read_header(AVFormatContext *s)
     ff_subtitles_queue_finalize(s, &srt->q);
+    if (res < 0)
+        ff_subtitles_queue_clean(&srt->q);
     av_bprint_finalize(&buf, NULL);
     return res;