diff mbox series

[FFmpeg-devel] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST

Message ID 20200629170442.82367-1-k@ylo.ph
State Accepted
Headers show
Series [FFmpeg-devel] configure: remove libvmaf from EXTERNAL_LIBRARY_VERSION3_LIST
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Kyle Swanson June 29, 2020, 5:04 p.m. UTC
since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent

Signed-off-by: Kyle Swanson <k@ylo.ph>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

Comments

Kyle Swanson June 29, 2020, 5:30 p.m. UTC | #1
Hi,

On Mon, Jun 29, 2020 at 10:05 AM Kyle Swanson <k@ylo.ph> wrote:
>
> since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent
>
> Signed-off-by: Kyle Swanson <k@ylo.ph>
> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7495f35faa..e0b76ac1ea 100755
> --- a/configure
> +++ b/configure
> @@ -1741,7 +1741,6 @@ EXTERNAL_LIBRARY_VERSION3_LIST="
>      liblensfun
>      libopencore_amrnb
>      libopencore_amrwb
> -    libvmaf
>      libvo_amrwbenc
>      mbedtls
>      rkmpp
> --
> 2.26.2
>

Missed the filter docs. Updated patch attached.

Thanks,
Kyle
Derek Buitenhuis June 29, 2020, 7:13 p.m. UTC | #2
On 29/06/2020 18:04, Kyle Swanson wrote:
> since libvmaf v1.5.1, libvmaf has been relicensed as BSD+Patent
> 
> Signed-off-by: Kyle Swanson <k@ylo.ph>
> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)

You'll need to update the pkg-config check too if you want to
to this, since it's at >= 1.3.9 right now.

- Derek
Kyle Swanson June 29, 2020, 9:20 p.m. UTC | #3
On Mon, Jun 29, 2020 at 12:14 PM Derek Buitenhuis
<derek.buitenhuis@gmail.com> wrote:
> You'll need to update the pkg-config check too if you want to
> to this, since it's at >= 1.3.9 right now.
>
> - Derek

Thanks. Updated patch attached.
Carl Eugen Hoyos June 29, 2020, 9:27 p.m. UTC | #4
Am Mo., 29. Juni 2020 um 23:21 Uhr schrieb Kyle Swanson <k@ylo.ph>:
>
> On Mon, Jun 29, 2020 at 12:14 PM Derek Buitenhuis
> <derek.buitenhuis@gmail.com> wrote:
> > You'll need to update the pkg-config check too if you want to
> > to this, since it's at >= 1.3.9 right now.
> >
> > - Derek
>
> Thanks. Updated patch attached.

No objections.

Carl Eugen
Kyle Swanson June 30, 2020, 6:55 p.m. UTC | #5
On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> No objections.

Thanks. I will merge in 24 hours or so, when the next libvmaf minor
release is cut.
Kyle Swanson July 2, 2020, 8:24 p.m. UTC | #6
On Tue, Jun 30, 2020 at 11:55 AM Kyle Swanson <k@ylo.ph> wrote:
>
> On Mon, Jun 29, 2020 at 2:27 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> > No objections.
>
> Thanks. I will merge in 24 hours or so, when the next libvmaf minor
> release is cut.

Pushed. Thanks.
diff mbox series

Patch

diff --git a/configure b/configure
index 7495f35faa..e0b76ac1ea 100755
--- a/configure
+++ b/configure
@@ -1741,7 +1741,6 @@  EXTERNAL_LIBRARY_VERSION3_LIST="
     liblensfun
     libopencore_amrnb
     libopencore_amrwb
-    libvmaf
     libvo_amrwbenc
     mbedtls
     rkmpp