From patchwork Sun Jul 12 17:21:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hanishkvc X-Patchwork-Id: 20975 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 71F0144AA22 for ; Sun, 12 Jul 2020 20:22:17 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 45ED468A531; Sun, 12 Jul 2020 20:22:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5AB55689F05 for ; Sun, 12 Jul 2020 20:22:10 +0300 (EEST) Received: by mail-pg1-f170.google.com with SMTP id o13so4977851pgf.0 for ; Sun, 12 Jul 2020 10:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WcZp2TMMaGX+ygkjNFqDcRhlGg4jjDGZ9j/S7xQqnRE=; b=tQmOSQpRKIQ8FI7nVYa6gDZHnB8URpk2pVK+vJ5dI+eyN9o1S2n+AUV5yVtxyMAj57 +Kp01WYDeXT+MlSMokQ9OkmVA3PK23I8I1cYHzr/f4AaWEaperRrrrLr0bO/eOarjfNJ BS5UNat8TDA2HD3k40xyQv/burqxbXE6wAoAKqrmQddAwTcTt3ujLvGbMJdw9DB/i1sH iWFlk9vGsT8/4fVKwIgC5RcHF0PZG7uEH+b8zrUOMybEP02fUduhAOPNfVEUJHBnPu+U cYE8iJt+vQDK+k5qHcNsYTtYJREncp9zRx1eR04vj0kVnLOpH8cNtnHjfsXV5w0kX1Ns Mt6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WcZp2TMMaGX+ygkjNFqDcRhlGg4jjDGZ9j/S7xQqnRE=; b=ELy+0RgT1vrEHn+SK/hUR4mm1WPNuVdadhOUXLtqOz+281kQxAw8FEoeiCQV9Y3D1I Tqa8QN3aH1QyDYmEG1XC575q+5HFBAdxV/dzGLMj1CHniK3m7VSJulyY53tANsUk8tkX J6xl/WlhhbpxVqIztNCH1Xt8W2Jo3PGbvHARBtBlAz0IOilpKLLwGqB+glJFePrAgKJG 2iXfDa+MHa+anyFm3i+ZrYpZP4hSQKVjCxuJ4K1GkJDQxDVFnoOOXD6kJlVbqyIEYDz1 MMdQWYlxUxPhCPrAESHanY282Kj8ngEkJa90zg7gaKFW6rmBLijZuafU0GTJN9QrGDNW 3Lww== X-Gm-Message-State: AOAM532ZLRmnwlcESCz80777L4Mn0GBsyJczggCh1r8I0dfTeB0vnu3N K47w8RjkXT9RO0qn3/JfmRoVp9i9 X-Google-Smtp-Source: ABdhPJwIsggSZhM6hW33qLLNSAO88KIEZ1uYz0O6s2knG6I3zu0XULmUsCgTaz2dW1rwvCuV+OofUQ== X-Received: by 2002:a62:178e:: with SMTP id 136mr70555643pfx.180.1594574528041; Sun, 12 Jul 2020 10:22:08 -0700 (PDT) Received: from localhost.localdomain ([122.171.57.136]) by smtp.gmail.com with ESMTPSA id x3sm12244944pfn.154.2020.07.12.10.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2020 10:22:07 -0700 (PDT) From: hanishkvc To: ffmpeg-devel@ffmpeg.org Date: Sun, 12 Jul 2020 22:51:00 +0530 Message-Id: <20200712172102.72406-2-hanishkvc@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200712172102.72406-1-hanishkvc@gmail.com> References: <20200712172102.72406-1-hanishkvc@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v08.01 1/3] KMSGrab: getfb2 format_modifier if user doesnt specify X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: hanishkvc Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" If user doesnt specify a format_modifier explicitly, then use GetFB2 to identify the format_modifier of the framebuffer being grabbed. This is supported on newer linux builds, where xf86drmMode.h has added support for GetFB2. --- Changelog | 1 + configure | 5 +++++ libavdevice/kmsgrab.c | 31 ++++++++++++++++++++++++++++++- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 1bb9931c0d..20ba03ae8b 100644 --- a/Changelog +++ b/Changelog @@ -5,6 +5,7 @@ version : - AudioToolbox output device - MacCaption demuxer - PGX decoder +- kmsgrab GetFB2 format_modifier, if user doesnt specify version 4.3: diff --git a/configure b/configure index bdfd731602..3bbc51053c 100755 --- a/configure +++ b/configure @@ -2325,6 +2325,7 @@ HAVE_LIST=" $TYPES_LIST makeinfo makeinfo_html + drm_getfb2 opencl_d3d11 opencl_drm_arm opencl_drm_beignet @@ -6653,6 +6654,10 @@ if enabled vaapi; then check_type "va/va.h va/va_enc_vp9.h" "VAEncPictureParameterBufferVP9" fi +if enabled libdrm; then + check_pkg_config drm_getfb2 libdrm "xf86drm.h xf86drmMode.h" drmModeGetFB2 +fi + if enabled_all opencl libdrm ; then check_type "CL/cl_intel.h" "clCreateImageFromFdINTEL_fn" && enable opencl_drm_beignet diff --git a/libavdevice/kmsgrab.c b/libavdevice/kmsgrab.c index d0de774871..c7fa2343e3 100644 --- a/libavdevice/kmsgrab.c +++ b/libavdevice/kmsgrab.c @@ -239,6 +239,9 @@ static av_cold int kmsgrab_read_header(AVFormatContext *avctx) drmModePlaneRes *plane_res = NULL; drmModePlane *plane = NULL; drmModeFB *fb = NULL; +#if HAVE_DRM_GETFB2 + drmModeFB2 *fb2 = NULL; +#endif AVStream *stream; int err, i; @@ -364,6 +367,28 @@ static av_cold int kmsgrab_read_header(AVFormatContext *avctx) goto fail; } +#if HAVE_DRM_GETFB2 + fb2 = drmModeGetFB2(ctx->hwctx->fd, plane->fb_id); + if (!fb2) { + err = errno; + av_log(avctx, AV_LOG_ERROR, "Failed to get " + "framebuffer2 %"PRIu32": %s.\n", + plane->fb_id, strerror(err)); + err = AVERROR(err); + goto fail; + } + + av_log(avctx, AV_LOG_INFO, "Template framebuffer2 is %"PRIu32": " + "%"PRIu32"x%"PRIu32", pixel_format: 0x%"PRIx32", format_modifier: 0x%"PRIx64".\n", + fb2->fb_id, fb2->width, fb2->height, fb2->pixel_format, fb2->modifier); + + if (ctx->drm_format_modifier == DRM_FORMAT_MOD_INVALID) + ctx->drm_format_modifier = fb2->modifier; +#else + if (ctx->drm_format_modifier == DRM_FORMAT_MOD_INVALID) + ctx->drm_format_modifier = DRM_FORMAT_MOD_NONE; +#endif + stream = avformat_new_stream(avctx, NULL); if (!stream) { err = AVERROR(ENOMEM); @@ -408,6 +433,10 @@ fail: drmModeFreePlane(plane); if (fb) drmModeFreeFB(fb); +#if HAVE_DRM_GETFB2 + if (fb2) + drmModeFreeFB2(fb2); +#endif return err; } @@ -433,7 +462,7 @@ static const AVOption options[] = { { .i64 = AV_PIX_FMT_BGR0 }, 0, UINT32_MAX, FLAGS }, { "format_modifier", "DRM format modifier for framebuffer", OFFSET(drm_format_modifier), AV_OPT_TYPE_INT64, - { .i64 = DRM_FORMAT_MOD_NONE }, 0, INT64_MAX, FLAGS }, + { .i64 = DRM_FORMAT_MOD_INVALID}, 0, INT64_MAX, FLAGS }, { "crtc_id", "CRTC ID to define capture source", OFFSET(source_crtc), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, UINT32_MAX, FLAGS },