diff mbox series

[FFmpeg-devel] avformat/hls: Fix memleak when url is empty

Message ID 20200814203521.29103-1-andreas.rheinhardt@gmail.com
State Accepted
Commit dfc6a9f07543e3c2bf01baaf8459558365f961d2
Headers show
Series [FFmpeg-devel] avformat/hls: Fix memleak when url is empty | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Aug. 14, 2020, 8:35 p.m. UTC 
Fixes Coverity ID 1465888.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
Why does this code actually not check the return value of
ff_make_absolute_url()?

 libavformat/hls.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libavformat/hls.c b/libavformat/hls.c
index 84f0a5f323..4a3e0d6842 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -311,8 +311,10 @@  static struct playlist *new_playlist(HLSContext *c, const char *url,
         return NULL;
     reset_packet(&pls->pkt);
     ff_make_absolute_url(pls->url, sizeof(pls->url), base, url);
-    if (!pls->url[0])
+    if (!pls->url[0]) {
+        av_free(pls);
         return NULL;
+    }
     pls->seek_timestamp = AV_NOPTS_VALUE;
 
     pls->is_id3_timestamped = -1;